mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Andreas Helmcke <ahelmcke@ela-soft.com>
To: ptxdist@pengutronix.de
Cc: Andreas Helmcke <ahelmcke@ela-soft.com>
Subject: [ptxdist] [PATCH] rauc: install service startscripts only when needed
Date: Thu, 12 Oct 2023 17:20:39 +0200	[thread overview]
Message-ID: <20231012152039.85251-1-ahelmcke@ela-soft.com> (raw)

rauc service is only needed with D-bus, so do not install startup scripts if PTXCONF_RAUC_SERVICE is unset

Signed-off-by: Andreas Helmcke <ahelmcke@ela-soft.com>
---
 rules/rauc.make | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/rules/rauc.make b/rules/rauc.make
index 0f71f12ed..f2bbcbe05 100644
--- a/rules/rauc.make
+++ b/rules/rauc.make
@@ -85,19 +85,20 @@ ifdef PTXCONF_RAUC_SERVICE
 		/usr/share/dbus-1/system-services/de.pengutronix.rauc.service)
 	@$(call install_copy, rauc, 0, 0, 0644, -, \
 		/usr/share/dbus-1/system.d/de.pengutronix.rauc.conf)
-endif
 
-ifdef PTXCONF_INITMETHOD_SYSTEMD
-	@$(call install_alternative, rauc, 0, 0, 0644, \
-		/usr/lib/systemd/system/rauc.service)
-
-	@$(call install_alternative, rauc, 0, 0, 0644, \
-		/usr/lib/systemd/system/rauc-mark-good.service)
-	@$(call install_link, rauc, ../rauc-mark-good.service, \
-		/usr/lib/systemd/system/multi-user.target.wants/rauc-mark-good.service)
-else
-	@$(call install_copy, rauc, 0, 0, 0755, -, \
-		/usr/libexec/rauc-service.sh)
+	ifdef PTXCONF_INITMETHOD_SYSTEMD
+		@$(call install_alternative, rauc, 0, 0, 0644, \
+			/usr/lib/systemd/system/rauc.service)
+
+		@$(call install_alternative, rauc, 0, 0, 0644, \
+			/usr/lib/systemd/system/rauc-mark-good.service)
+		@$(call install_link, rauc, ../rauc-mark-good.service, \
+			/usr/lib/systemd/system/multi-user.target.wants/rauc-mark-good.service)
+	else
+		@$(call install_copy, rauc, 0, 0, 0755, -, \
+			/usr/libexec/rauc-service.sh)
+	endif
+
 endif
 
 	@$(call install_finish, rauc)
-- 
2.39.2




             reply	other threads:[~2023-10-12 15:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-12 15:20 Andreas Helmcke [this message]
2023-11-17  7:20 ` [ptxdist] [APPLIED] " Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231012152039.85251-1-ahelmcke@ela-soft.com \
    --to=ahelmcke@ela-soft.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox