[ptxdist] [PATCH] uhubctl: add missing GCCLIBS_ATOMIC select

[ptxdist] [PATCH] uhubctl: add missing GCCLIBS_ATOMIC select

[Bruno Thomsen]

Without this dependency the following runtime error can be observed:

uhubctl: error while loading shared libraries: libatomic.so.1: cannot
open shared object file: No such file or directory

Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
---
 rules/uhubctl.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/rules/uhubctl.in b/rules/uhubctl.in
index ec30f6637..e638cf859 100644
--- a/rules/uhubctl.in
+++ b/rules/uhubctl.in
@@ -2,6 +2,7 @@
 
 config UHUBCTL
 	bool
+	select GCCLIBS_ATOMIC
 	select LIBUSB
 	prompt "uhubctl"
 	help

base-commit: fb8eb0719152fe1f4bc7f31d3c40087fcb721a8c
-- 
2.41.0

Re: [ptxdist] [PATCH] uhubctl: add missing GCCLIBS_ATOMIC select

[Bruno Thomsen]

Den man. 17. jul. 2023 kl. 15.52 skrev Bruno Thomsen <bruno.thomsen@gmail.com>:
>
> Without this dependency the following runtime error can be observed:
>
> uhubctl: error while loading shared libraries: libatomic.so.1: cannot
> open shared object file: No such file or directory

Please drop this patch.
I cannot recreate the issue in an ARM v7a project, only in a ARM v5te project,
so it must be a local issue.

/Bruno

>
> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> ---
>  rules/uhubctl.in | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/rules/uhubctl.in b/rules/uhubctl.in
> index ec30f6637..e638cf859 100644
> --- a/rules/uhubctl.in
> +++ b/rules/uhubctl.in
> @@ -2,6 +2,7 @@
>
>  config UHUBCTL
>         bool
> +       select GCCLIBS_ATOMIC
>         select LIBUSB
>         prompt "uhubctl"
>         help
>
> base-commit: fb8eb0719152fe1f4bc7f31d3c40087fcb721a8c
> --
> 2.41.0
>

Re: [ptxdist] [PATCH] uhubctl: add missing GCCLIBS_ATOMIC select

[Michael Olbrich]

On Thu, Jul 27, 2023 at 06:42:43PM +0200, Bruno Thomsen wrote:
> Den man. 17. jul. 2023 kl. 15.52 skrev Bruno Thomsen <bruno.thomsen@gmail.com>:
> >
> > Without this dependency the following runtime error can be observed:
> >
> > uhubctl: error while loading shared libraries: libatomic.so.1: cannot
> > open shared object file: No such file or directory
> 
> Please drop this patch.
> I cannot recreate the issue in an ARM v7a project, only in a ARM v5te project,
> so it must be a local issue.

It's an architecture issue. libatomic implements primitives that are not
available in hardware. For ARM v5 it's probably related to atomics.
So I won't apply this, because it does not effect the 'major'
architectures. Unfortunately we don't have a way to specify architecture
specific dependencies.

Michael

> > Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> > ---
> >  rules/uhubctl.in | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/rules/uhubctl.in b/rules/uhubctl.in
> > index ec30f6637..e638cf859 100644
> > --- a/rules/uhubctl.in
> > +++ b/rules/uhubctl.in
> > @@ -2,6 +2,7 @@
> >
> >  config UHUBCTL
> >         bool
> > +       select GCCLIBS_ATOMIC
> >         select LIBUSB
> >         prompt "uhubctl"
> >         help
> >
> > base-commit: fb8eb0719152fe1f4bc7f31d3c40087fcb721a8c
> > --
> > 2.41.0
> >
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [ptxdist] [PATCH] uhubctl: add missing GCCLIBS_ATOMIC select

[Bruno Thomsen]

Den fre. 28. jul. 2023 kl. 08.54 skrev Michael Olbrich
<m.olbrich@pengutronix.de>:
>
> On Thu, Jul 27, 2023 at 06:42:43PM +0200, Bruno Thomsen wrote:
> > Den man. 17. jul. 2023 kl. 15.52 skrev Bruno Thomsen <bruno.thomsen@gmail.com>:
> > >
> > > Without this dependency the following runtime error can be observed:
> > >
> > > uhubctl: error while loading shared libraries: libatomic.so.1: cannot
> > > open shared object file: No such file or directory
> >
> > Please drop this patch.
> > I cannot recreate the issue in an ARM v7a project, only in a ARM v5te project,
> > so it must be a local issue.
>
> It's an architecture issue. libatomic implements primitives that are not
> available in hardware. For ARM v5 it's probably related to atomics.
> So I won't apply this, because it does not effect the 'major'
> architectures. Unfortunately we don't have a way to specify architecture
> specific dependencies.
>

Hi, thanks for the info.

We have solved this architecture (hardware generation) issue in a
component called octopus
with a Kconfig generation choice, ex. 2GEN or 3GEN. The component
contains many small
systemd services that execute Bash scripts, so it already has many
Kconfig selects on various
command line tools. As not all services run on all hardware generations,
ex. Only 3GEN[1][2] has a TPM chip:

select TPM2_TOOLS if RUNTIME && OCTOPUS_3GEN

It's one of these services that require uhubctl so now we do:

select UHUBCTL if RUNTIME
select GCCLIBS_ATOMIC if RUNTIME && OCTOPUS_2GEN

/Bruno

[1] https://elixir.bootlin.com/linux/latest/source/arch/arm/boot/dts/imx7d-flex-concentrator.dts
[2] https://elixir.bootlin.com/barebox/latest/source/arch/arm/dts/imx7d-flex-concentrator-mfg.dts