From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: "Enrico Jörns" <ejo@pengutronix.de>
Subject: Re: [ptxdist] [APPLIED] rauc: fix PTXCONF_RAUC_CREATE handling
Date: Sat, 8 Jul 2023 09:03:02 +0200 [thread overview]
Message-ID: <20230708070302.2206323-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20230630204927.2700230-1-ejo@pengutronix.de>
Thanks, applied as 13713e62b43478e8aa5e284cd6b739c34253db71.
Michael
[sent from post-receive hook]
On Sat, 08 Jul 2023 09:03:02 +0200, Enrico Jörns <ejo@pengutronix.de> wrote:
> The existing --disable-create/--disable-create configure options were
> not removed when the PTXCONF_RAUC_CREATE kconfig was introduced.
>
> As a result of this, create could not be enabled for the target (since
> it was forced to --disable-create afterwards) and the --enable-create
> line was duplicated within the host-rauc recipe.
>
> Fixes: c2ad273712cfb89c292dd5a72e8e1ee87a997ab7
> ("RAUC: leverage --disable-create option to shrink size for target RAUC")
>
> Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
> Message-Id: <20230630204927.2700230-1-ejo@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
>
> diff --git a/rules/host-rauc.make b/rules/host-rauc.make
> index f0716da042b6..e5190bb8e60a 100644
> --- a/rules/host-rauc.make
> +++ b/rules/host-rauc.make
> @@ -27,7 +27,6 @@ HOST_RAUC_CONF_OPT := \
> --disable-Werror \
> --disable-code-coverage \
> --disable-valgrind \
> - --enable-create \
> --disable-service \
> --enable-create \
> --disable-network \
> diff --git a/rules/rauc.make b/rules/rauc.make
> index 0502fd3704ed..35a4e84457b7 100644
> --- a/rules/rauc.make
> +++ b/rules/rauc.make
> @@ -45,7 +45,6 @@ RAUC_CONF_OPT := \
> --disable-valgrind \
> --$(call ptx/endis,PTXCONF_RAUC_CREATE)-create \
> --$(call ptx/endis,PTXCONF_RAUC_SERVICE)-service \
> - --disable-create \
> --$(call ptx/endis,PTXCONF_RAUC_NETWORK)-network \
> --$(call ptx/endis,PTXCONF_RAUC_STREAMING)-streaming \
> --$(call ptx/endis,PTXCONF_RAUC_JSON)-json \
prev parent reply other threads:[~2023-07-08 7:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 20:49 [ptxdist] [PATCH 1/3] " Enrico Jorns
2023-06-30 20:49 ` [ptxdist] [PATCH 2/3] rauc: extend and align option pinning with configure order Enrico Jorns
2023-07-04 9:18 ` Michael Tretter
2023-07-04 9:25 ` Enrico Jörns
2023-07-08 7:03 ` [ptxdist] [APPLIED] " Michael Olbrich
2023-06-30 20:49 ` [ptxdist] [PATCH 3/3] rauc: version bump 1.9 -> 1.10 Enrico Jorns
2023-07-08 7:03 ` [ptxdist] [APPLIED] " Michael Olbrich
2023-07-08 7:03 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230708070302.2206323-1-m.olbrich@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ejo@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox