* [ptxdist] [PATCH] vulkan-loader: enable assembly on aarch64 and x86_64
@ 2023-05-26 8:17 Philipp Zabel
2023-05-26 8:22 ` Michael Olbrich
0 siblings, 1 reply; 2+ messages in thread
From: Philipp Zabel @ 2023-05-26 8:17 UTC (permalink / raw)
To: ptxdist; +Cc: Philipp Zabel
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
rules/vulkan-loader.make | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/rules/vulkan-loader.make b/rules/vulkan-loader.make
index 02981278de60..97c57dc21313 100644
--- a/rules/vulkan-loader.make
+++ b/rules/vulkan-loader.make
@@ -45,8 +45,18 @@ VULKAN_LOADER_CONF_OPT := \
-DLOADER_ENABLE_ADDRESS_SANITIZER=OFF \
-DLOADER_ENABLE_THREAD_SANITIZER=OFF \
-DSYSCONFDIR= \
- -DUPDATE_DEPS=OFF \
- -DUSE_GAS=OFF
+ -DUPDATE_DEPS=OFF
+
+VULKAN_LOADER_USE_GAS := OFF
+ifdef PTXCONF_ARCH_ARM64
+VULKAN_LOADER_USE_GAS := ON
+endif
+ifdef PTXCONF_ARCH_X86_64
+VULKAN_LOADER_USE_GAS := ON
+endif
+
+VULKAN_LOADER_CONF_OPT += \
+ -DUSE_GAS=$(VULKAN_LOADER_USE_GAS)
# ----------------------------------------------------------------------------
# Target-Install
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [ptxdist] [PATCH] vulkan-loader: enable assembly on aarch64 and x86_64
2023-05-26 8:17 [ptxdist] [PATCH] vulkan-loader: enable assembly on aarch64 and x86_64 Philipp Zabel
@ 2023-05-26 8:22 ` Michael Olbrich
0 siblings, 0 replies; 2+ messages in thread
From: Michael Olbrich @ 2023-05-26 8:22 UTC (permalink / raw)
To: Philipp Zabel; +Cc: ptxdist
On Fri, May 26, 2023 at 10:17:35AM +0200, Philipp Zabel wrote:
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> rules/vulkan-loader.make | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/rules/vulkan-loader.make b/rules/vulkan-loader.make
> index 02981278de60..97c57dc21313 100644
> --- a/rules/vulkan-loader.make
> +++ b/rules/vulkan-loader.make
> @@ -45,8 +45,18 @@ VULKAN_LOADER_CONF_OPT := \
> -DLOADER_ENABLE_ADDRESS_SANITIZER=OFF \
> -DLOADER_ENABLE_THREAD_SANITIZER=OFF \
> -DSYSCONFDIR= \
> - -DUPDATE_DEPS=OFF \
> - -DUSE_GAS=OFF
> + -DUPDATE_DEPS=OFF
> +
> +VULKAN_LOADER_USE_GAS := OFF
> +ifdef PTXCONF_ARCH_ARM64
> +VULKAN_LOADER_USE_GAS := ON
> +endif
> +ifdef PTXCONF_ARCH_X86_64
> +VULKAN_LOADER_USE_GAS := ON
> +endif
Can you move this above the VULKAN_LOADER_CONF_OPT definition please.
> +
> +VULKAN_LOADER_CONF_OPT += \
> + -DUSE_GAS=$(VULKAN_LOADER_USE_GAS)
And keep this in the listing above. Otherwise the order of the options is
broken.
Regards,
Michael
>
> # ----------------------------------------------------------------------------
> # Target-Install
> --
> 2.39.2
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-26 8:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-26 8:17 [ptxdist] [PATCH] vulkan-loader: enable assembly on aarch64 and x86_64 Philipp Zabel
2023-05-26 8:22 ` Michael Olbrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox