From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Robert Schwebel <r.schwebel@pengutronix.de>
Subject: Re: [ptxdist] [APPLIED] qemu / 9p: store metadata for / in correct file
Date: Tue, 2 May 2023 09:06:10 +0200 [thread overview]
Message-ID: <20230502070610.316684-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20230428080219.2971043-1-r.schwebel@pengutronix.de>
Thanks, applied as 94b4846fbe5b18327baca493b181a94a7d610fb2.
Michael
[sent from post-receive hook]
On Tue, 02 May 2023 09:06:10 +0200, Robert Schwebel <r.schwebel@pengutronix.de> wrote:
> Since qemu commit 81ffbf5ab1458e357a761f1272105a55829b351e the metadata
> for / is not stored in platform-<nnn>/.virtfs_metadata/root but instead
> in platform-<nnn>/root/.virtfs_metadata_root. For nfsroot, we also leave
> the file in the current position.
>
> Without this patch, / belongs to the user+group of the ptxdist user on
> 9p, not to root+root.
>
> Inspired-by: Michael Olbrich <m.olbrich@pengutronix.de>
> Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de>
> Message-Id: <20230428080219.2971043-1-r.schwebel@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
>
> diff --git a/scripts/lib/ptxd_make_xpkg_pkg.sh b/scripts/lib/ptxd_make_xpkg_pkg.sh
> index 1a1af0c1995b..a2fa7b99ac7e 100644
> --- a/scripts/lib/ptxd_make_xpkg_pkg.sh
> +++ b/scripts/lib/ptxd_make_xpkg_pkg.sh
> @@ -296,6 +296,10 @@ ptxd_install_virtfs() {
> virtfs.gid=${grp}
> virtfs.mode=${mod_virtfs}
> EOF
> + if [ -z "${dst}" ]; then
> + mkdir_p "${d%/*}/root" &&
> + cp $file "${d%/*}/root/.virtfs_metadata_root"
> + fi &&
> if [ -n "${major}" -a -n "${minor}" ]; then
> local rdev=$[ ${major} << 8 | ${minor} ] &&
> echo "virtfs.rdev=${rdev}" >> "${file}"
prev parent reply other threads:[~2023-05-02 7:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 8:02 [ptxdist] [PATCH v2] " Robert Schwebel
2023-05-02 7:06 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230502070610.316684-1-m.olbrich@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
--cc=r.schwebel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox