Re: [ptxdist] Regenerate license report

Re: [ptxdist] Regenerate license report

[Michael Olbrich]

Hi,

On Tue, Apr 18, 2023 at 05:18:58PM +0200, Guillermo Rodriguez Garcia wrote:
> El mar, 18 abr 2023 a las 16:37, Guillermo Rodriguez Garcia (<
> guille.rodriguez@gmail.com>) escribió:
> > Is there a way to force ptxdist to regenerate a license-report after it
> > has been generated already with "ptxdist make license-report" ?
> >
> > I didn't find any "clean" rule for this, and the naive approach of just
> > deleting the platform-xxx/report  dir doesn't work (trying to run ptxdist
> > make license-report after this results in errors).
> >
> 
> The best I have found is:
> 
> rm -rf platform-xxx/report
> rm platform-xxx/state/*.report
> 
> But I assume there is a cleaner way :-)

That depends a bit on why you want to regenerate the report. If you need to
regenerate the per package stuff in platform-xxx/report/ then removing
platform-xxx/state/*.report is the way to go. If that part remains
unchanged, then just removing the pdfs should be enough.

Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [ptxdist] Regenerate license report

[Michael Olbrich]

On Wed, Apr 19, 2023 at 09:28:02AM +0200, Guillermo Rodriguez Garcia wrote:
> El miércoles, 19 de abril de 2023, Michael Olbrich <m.olbrich@pengutronix.de>
> escribió:
> > On Tue, Apr 18, 2023 at 05:18:58PM +0200, Guillermo Rodriguez Garcia wrote:
> > > El mar, 18 abr 2023 a las 16:37, Guillermo Rodriguez Garcia (<
> > > guille.rodriguez@gmail.com>) escribió:
> > > > Is there a way to force ptxdist to regenerate a license-report after it
> > > > has been generated already with "ptxdist make license-report" ?
> > > >
> > > > I didn't find any "clean" rule for this, and the naive approach of just
> > > > deleting the platform-xxx/report  dir doesn't work (trying to run
> > ptxdist
> > > > make license-report after this results in errors).
> > > >
> > >
> > > The best I have found is:
> > >
> > > rm -rf platform-xxx/report
> > > rm platform-xxx/state/*.report
> > >
> > > But I assume there is a cleaner way :-)
> >
> > That depends a bit on why you want to regenerate the report. If you need to
> > regenerate the per package stuff in platform-xxx/report/ then removing
> > platform-xxx/state/*.report is the way to go. If that part remains
> > unchanged, then just removing the pdfs should be enough.
> 
> 
> This was because of adjustments to license info in the .make files so I
> guess I need to remove the .report files :-)
> 
> Thank you for the response,

If you change a .make file, then that should be detected automatically and
the license info for that package should be regenerated automatically.
It should not be necessary to do anything manually.

Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [ptxdist] Regenerate license report

[Michael Olbrich]

On Thu, Apr 20, 2023 at 12:24:21PM +0200, Guillermo Rodriguez Garcia wrote:
> El mié, 19 abr 2023 a las 10:18, Michael Olbrich (<m.olbrich@pengutronix.de>)
> escribió:
> > On Wed, Apr 19, 2023 at 09:28:02AM +0200, Guillermo Rodriguez Garcia wrote:
> > > El miércoles, 19 de abril de 2023, Michael Olbrich <
> > m.olbrich@pengutronix.de>
> > > escribió:
> > > > On Tue, Apr 18, 2023 at 05:18:58PM +0200, Guillermo Rodriguez Garcia
> > wrote:
> > > > > El mar, 18 abr 2023 a las 16:37, Guillermo Rodriguez Garcia (<
> > > > > guille.rodriguez@gmail.com>) escribió:
> > > > > > Is there a way to force ptxdist to regenerate a license-report
> > after it
> > > > > > has been generated already with "ptxdist make license-report" ?
> > > > > >
> > > > > > I didn't find any "clean" rule for this, and the naive approach of
> > just
> > > > > > deleting the platform-xxx/report  dir doesn't work (trying to run
> > > > ptxdist
> > > > > > make license-report after this results in errors).
> > > > > >
> > > > >
> > > > > The best I have found is:
> > > > >
> > > > > rm -rf platform-xxx/report
> > > > > rm platform-xxx/state/*.report
> > > > >
> > > > > But I assume there is a cleaner way :-)
> > > >
> > > > That depends a bit on why you want to regenerate the report. If you
> > need to
> > > > regenerate the per package stuff in platform-xxx/report/ then removing
> > > > platform-xxx/state/*.report is the way to go. If that part remains
> > > > unchanged, then just removing the pdfs should be enough.
> > >
> > >
> > > This was because of adjustments to license info in the .make files so I
> > > guess I need to remove the .report files :-)
> > >
> > > Thank you for the response,
> >
> > If you change a .make file, then that should be detected automatically and
> > the license info for that package should be regenerated automatically.
> > It should not be necessary to do anything manually.
> >
> 
> Yes; the problem is that I was not actually changing the .make files.
> Instead I have a rules/post/licenses.make file where I override some of the
> xxx_LICENSE variables. I was looking for a way to regenerate the report
> when this file was updated. Anyway I think all is clear now with your
> explanations. Thanks again!

Which PTXdist version? Since PTXdist 2021.12.0 you can use
rules/<pkg>.<something>.make for that. These files are included directly
after rules/<pkg>.make and they are part of the hash that determines if a
package needs to be rebuilt.

Regards,
Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |