From mboxrd@z Thu Jan  1 00:00:00 1970
Delivery-date: Fri, 17 Feb 2023 16:36:03 +0100
Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33])
	by lore.white.stw.pengutronix.de with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <ptxdist-bounces+lore=lore.pengutronix.de@pengutronix.de>)
	id 1pT2mJ-00AE1x-Jw
	for lore@lore.pengutronix.de; Fri, 17 Feb 2023 16:36:03 +0100
Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de)
	by metis.ext.pengutronix.de with esmtp (Exim 4.92)
	(envelope-from <ptxdist-bounces@pengutronix.de>)
	id 1pT2mG-0002Ed-UC; Fri, 17 Feb 2023 16:36:00 +0100
Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])
 by metis.ext.pengutronix.de with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <mol@pengutronix.de>)
 id 1pT2ls-00018h-8i; Fri, 17 Feb 2023 16:35:36 +0100
Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de)
 by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2)
 (envelope-from <mol@pengutronix.de>)
 id 1pT2lq-005cJl-Dw; Fri, 17 Feb 2023 16:35:35 +0100
Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.94.2)
 (envelope-from <mol@pengutronix.de>)
 id 1pT2lq-005Au1-Ug; Fri, 17 Feb 2023 16:35:34 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Date: Fri, 17 Feb 2023 16:35:34 +0100
Message-Id: <20230217153534.1232560-1-m.olbrich@pengutronix.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20230210192144.2133757-1-m.felsch@pengutronix.de>
References: <20230210192144.2133757-1-m.felsch@pengutronix.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [ptxdist] [APPLIED] blspec-entry: add linux-appendroot support
X-BeenThere: ptxdist@pengutronix.de
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Cc: Marco Felsch <m.felsch@pengutronix.de>
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
X-SA-Exim-Connect-IP: 127.0.0.1
X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false

Thanks, applied as 09f00b06b28298cbf135bee30b2d5d04874ab410.

Michael

[sent from post-receive hook]

On Fri, 17 Feb 2023 16:35:34 +0100, Marco Felsch <m.felsch@pengutronix.de> wrote:
> Add the option to add the 'linux-appendroot true' to blspec config file
> which is very useful in case of using barebox as bootlaoder.
> 
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> Message-Id: <20230210192144.2133757-1-m.felsch@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/platforms/blspec-entry.in b/platforms/blspec-entry.in
> index aed65d40a329..c2aea36dc8cc 100644
> --- a/platforms/blspec-entry.in
> +++ b/platforms/blspec-entry.in
> @@ -16,4 +16,12 @@ config BLSPEC_ENTRY_CMDLINE
>  	string
>  	prompt "kernel command-line"
>  
> +config BLSPEC_ENTRY_APPENDROOT
> +	bool
> +	prompt "Add 'linux-appendroot true'"
> +	help
> +	  If enabled this options adds 'linux-appendroot true' to the blspec
> +	  entry. This is a barebox specific blspec option which tells barebox
> +	  to add the 'root=' kernel command line automatically if set.
> +
>  endif
> diff --git a/projectroot/loader/entries/default.conf b/projectroot/loader/entries/default.conf
> index 5650907ab11b..d2815697511e 100644
> --- a/projectroot/loader/entries/default.conf
> +++ b/projectroot/loader/entries/default.conf
> @@ -3,3 +3,4 @@ version		@VERSION@
>  options		@CMDLINE@
>  linux		@KERNEL@
>  @DEVICETREE@
> +@LINUXAPPENDROOT@
> diff --git a/rules/blspec-entry.make b/rules/blspec-entry.make
> index f393b1bda162..7523009f6197 100644
> --- a/rules/blspec-entry.make
> +++ b/rules/blspec-entry.make
> @@ -35,6 +35,12 @@ else
>  BLSPEC_KERNEL_IMAGE	= $(KERNEL_IMAGE)
>  endif
>  
> +ifdef PTXCONF_BLSPEC_ENTRY_APPENDROOT
> +BLSPEC_APPENDROOT	= linux-appendroot\ttrue
> +else
> +BLSPEC_APPENDROOT	=
> +endif
> +
>  $(STATEDIR)/blspec-entry.targetinstall:
>  	@$(call targetinfo)
>  
> @@ -56,7 +62,9 @@ $(STATEDIR)/blspec-entry.targetinstall:
>  		$(call install_replace, blspec-entry, /loader/entries/$(name).conf, \
>  			@KERNEL@,'/boot/$(BLSPEC_KERNEL_IMAGE)')$(ptx/nl) \
>  		$(call install_replace, blspec-entry, /loader/entries/$(name).conf, \
> -			@DEVICETREE@,'$(call blspec/devicetree,$(name))')$(ptx/nl))
> +			@DEVICETREE@,'$(call blspec/devicetree,$(name))')$(ptx/nl) \
> +		$(call install_replace, blspec-entry, /loader/entries/$(name).conf, \
> +			@LINUXAPPENDROOT@,'$(BLSPEC_APPENDROOT)')$(ptx/nl))
>  
>  	@$(call install_finish,blspec-entry)
>