mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: "Sven Püschel" <s.pueschel@pengutronix.de>
Subject: Re: [ptxdist] [APPLIED] lshw: Set VERSION variable
Date: Fri, 10 Feb 2023 15:17:24 +0100	[thread overview]
Message-ID: <20230210141724.3534377-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20230207141307.334029-1-s.pueschel@pengutronix.de>

Thanks, applied as 27647e4b15b096b8b5e1521d8bda7181bda5731a.

Michael

[sent from post-receive hook]

On Fri, 10 Feb 2023 15:17:24 +0100, Sven Püschel <s.pueschel@pengutronix.de> wrote:
> The lshw Makefile defaults to a git describe if the version
> variable isn't set. This may cause it to use the version
> of a parent git repository like DistroKit, as lshw is extracted from a
> tarball.
> 
> Signed-off-by: Sven Püschel <s.pueschel@pengutronix.de>
> Message-Id: <20230207141307.334029-1-s.pueschel@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/lshw.make b/rules/lshw.make
> index 1feb82dba8e8..dbc911dfe7d4 100644
> --- a/rules/lshw.make
> +++ b/rules/lshw.make
> @@ -35,7 +35,7 @@ LSHW_CONF_TOOL		:= NO
>  # the "src" subdir avoids this.
>  LSHW_SUBDIR		:= src
>  
> -LSHW_MAKE_ENV		:= $(CROSS_ENV)
> +LSHW_MAKE_ENV		:= $(CROSS_ENV) VERSION=$(LSHW_VERSION)
>  LSHW_MAKE_OPT		:= all
>  LSHW_INSTALL_OPT	:= install
>  



      reply	other threads:[~2023-02-10 14:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-07 14:13 [ptxdist] [PATCH] " Sven Püschel
2023-02-10 14:17 ` Michael Olbrich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230210141724.3534377-1-m.olbrich@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    --cc=s.pueschel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox