From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 05 Jan 2023 08:27:06 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pDKeY-002F8A-R9 for lore@lore.pengutronix.de; Thu, 05 Jan 2023 08:27:06 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1pDKeX-0002oy-7h; Thu, 05 Jan 2023 08:27:05 +0100 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pDKe3-0002oo-JB; Thu, 05 Jan 2023 08:26:35 +0100 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1pDKe3-0002w7-4J; Thu, 05 Jan 2023 08:26:35 +0100 Date: Thu, 5 Jan 2023 08:26:35 +0100 From: Michael Olbrich To: Ladislav Michl Message-ID: <20230105072635.GC20148@pengutronix.de> Mail-Followup-To: Ladislav Michl , ptxdist@pengutronix.de References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [ptxdist] [RFC] Do not select INITMETHOD X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Wed, Jan 04, 2023 at 03:47:43PM +0100, Ladislav Michl wrote: > Do not force INITMETHOD to allow BSPs to use alternative inits > on their own (minit for example) > > Now that initmethod.in part of patch is questionable, but it breaks > various ways without it, for example: > WARNING: unmet direct dependencies detected for RC_ONCE > Depends on [n]: INITMETHOD [=n] > Selected by [m]: > - DROPBEAR [=m] && RUNTIME [=y] > > Any other ideas? I think it should be possible to add a source "generated/initmethod-choice.in" (name TBD) inside the initmethod choice. This way you can add your own initmethod instead of disabling it. Maybe split the existing ones into separate files for consistency. Regards, Michael > Thak you, > ladis > --- > rules/dropbear.in | 1 - > rules/initmethod.in | 4 ++-- > rules/lldpd.in | 1 - > 3 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/rules/dropbear.in b/rules/dropbear.in > index 95beb09bf..7b5736696 100644 > --- a/rules/dropbear.in > +++ b/rules/dropbear.in > @@ -6,7 +6,6 @@ menuconfig DROPBEAR > select LIBC_UTIL > select LIBC_CRYPT > select GCCLIBS_GCC_S > - select INITMETHOD > select RC_ONCE if RUNTIME > select BUSYBOX_START_STOP_DAEMON if DROPBEAR_STARTSCRIPT > select BUSYBOX_FEATURE_START_STOP_DAEMON_FANCY if DROPBEAR_STARTSCRIPT > diff --git a/rules/initmethod.in b/rules/initmethod.in > index 489fd365d..4066a05ba 100644 > --- a/rules/initmethod.in > +++ b/rules/initmethod.in > @@ -33,6 +33,6 @@ choice > > endchoice > > -source "generated/initmethod.in" > - > endif > + > +source "generated/initmethod.in" > diff --git a/rules/lldpd.in b/rules/lldpd.in > index 8b253ba83..d2afccbd0 100644 > --- a/rules/lldpd.in > +++ b/rules/lldpd.in > @@ -3,7 +3,6 @@ > menuconfig LLDPD > tristate > prompt "lldpd " > - select INITMETHOD > select LIBBSD > select LIBCAP > select LIBEVENT > -- > 2.32.0 > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |