From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 03 Jan 2023 12:09:24 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pCfAa-000MJC-Vk for lore@lore.pengutronix.de; Tue, 03 Jan 2023 12:09:24 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1pCfAZ-0005He-Dz; Tue, 03 Jan 2023 12:09:23 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pCf9n-0002U2-Ui; Tue, 03 Jan 2023 12:08:35 +0100 Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pCf9n-003YBF-9y; Tue, 03 Jan 2023 12:08:35 +0100 Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pCf9m-009Lxb-LH; Tue, 03 Jan 2023 12:08:34 +0100 From: Michael Olbrich To: ptxdist@pengutronix.de Date: Tue, 3 Jan 2023 12:08:34 +0100 Message-Id: <20230103110834.2229323-1-m.olbrich@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221216104522.116336-1-u.kleine-koenig@pengutronix.de> References: <20221216104522.116336-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [ptxdist] [APPLIED] treewide: Consistently use ':' instead to separate user and group for chown X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false Thanks, applied as f51d04cbcf2c0f5a014b319d554700ead28e5d84. Michael [sent from post-receive hook] On Tue, 03 Jan 2023 12:08:34 +0100, Uwe Kleine-König wrote: > Since coreutils 9.1 chown warns when a '.' is used as separator. Fix this > consistently also for documentation and scripts that are expected to use > busybox's chown which (up to now) has no problem with '.'. > > Signed-off-by: Uwe Kleine-König > Message-Id: <20221216104522.116336-1-u.kleine-koenig@pengutronix.de> > Signed-off-by: Michael Olbrich > > diff --git a/config/busybox/Config.in b/config/busybox/Config.in > index 199cc6ab272f..329e2f8e8a1b 100644 > --- a/config/busybox/Config.in > +++ b/config/busybox/Config.in > @@ -267,10 +267,10 @@ config BUSYBOX_FEATURE_SUID_CONFIG > > The file has to be owned by user root, group root and has to be > writeable only by root: > - (chown 0.0 /etc/busybox.conf; chmod 600 /etc/busybox.conf) > + (chown 0:0 /etc/busybox.conf; chmod 600 /etc/busybox.conf) > The busybox executable has to be owned by user root, group > root and has to be setuid root for this to work: > - (chown 0.0 /bin/busybox; chmod 4755 /bin/busybox) > + (chown 0:0 /bin/busybox; chmod 4755 /bin/busybox) > > Robert 'sandman' Griebl has more information here: > . > diff --git a/config/busybox/networking/Config.in b/config/busybox/networking/Config.in > index 3a3ad56d93f7..27e0f44ba811 100644 > --- a/config/busybox/networking/Config.in > +++ b/config/busybox/networking/Config.in > @@ -959,7 +959,7 @@ config BUSYBOX_TELNETD > FEATURE_SUID enabled. And finally, you should make > certain that busybox has been installed setuid root: > > - chown root.root /bin/busybox > + chown root:root /bin/busybox > chmod 4755 /bin/busybox > > with all that done, telnetd _should_ work.... > diff --git a/projectroot/usr/sbin/mysqlinit b/projectroot/usr/sbin/mysqlinit > index 72b6d1f10cf5..c98946025264 100644 > --- a/projectroot/usr/sbin/mysqlinit > +++ b/projectroot/usr/sbin/mysqlinit > @@ -5,7 +5,7 @@ MYSQLD_OPTS= > # since mySQL runs as a regular user, we need to give its working directory > # to it. > > -chown mysql.mysql "$1" > +chown mysql:mysql "$1" > chmod 0755 "$1" > > # now let mySQL do its initializing job > diff --git a/scripts/lib/ptxd_lib_dopermissions.awk b/scripts/lib/ptxd_lib_dopermissions.awk > index 56e951b45b75..9ab45d4979dd 100755 > --- a/scripts/lib/ptxd_lib_dopermissions.awk > +++ b/scripts/lib/ptxd_lib_dopermissions.awk > @@ -7,14 +7,14 @@ BEGIN { > > $1 ~ "[df]" { > printf("chmod %s '.%s'\n" \ > - "chown %s.%s '.%s'\n", \ > + "chown %s:%s '.%s'\n", \ > $5, $2, $3, $4, $2); > } > > $1 ~ "n" { > printf("if [ ! \\( -b '.%s' -o -c '.%s' -o -p '.%s' \\) ]; then " \ > " mknod -m %s '.%s' %s %s %s\n" \ > - " chown %s.%s '.%s'\n" \ > + " chown %s:%s '.%s'\n" \ > "fi\n", \ > $2, $2, $2, $5, $2, $6, $7, $8, $3, $4, $2); > }