From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 16 Dec 2022 11:46:06 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1p68E9-005aWy-Tt for lore@lore.pengutronix.de; Fri, 16 Dec 2022 11:46:06 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1p68E9-00072s-EB; Fri, 16 Dec 2022 11:46:05 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p68Dd-00072T-4j; Fri, 16 Dec 2022 11:45:33 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1p68Db-004txV-O0; Fri, 16 Dec 2022 11:45:32 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1p68Db-005VUL-QE; Fri, 16 Dec 2022 11:45:31 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: ptxdist@pengutronix.de Date: Fri, 16 Dec 2022 11:45:22 +0100 Message-Id: <20221216104522.116336-1-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Developer-Signature: v=1; a=openpgp-sha256; l=2965; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=QvtDHVP1MXMbwHalWJJgZcvz51t5Bx9zUyMsP6A7i2U=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBjnEw/TwWONFRVYNSW4dFW0xakybexuuR0BEDsK0QY NNenZzCJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCY5xMPwAKCRDB/BR4rcrsCfHbB/ wPaJUBAKEqxxtotoKi6e+h5nJGwCd4iXX6vKpfRI7VxDrnzvOIjYEdJsRJBTDO9vHhjMjF08d/tAF8 nEv4ukVIJqewE7pbXb8gsiz1mITDNzsQNPoTyIyzLI9wp2VMHoE7CopeyK4IUQdpb2kI1iLmjsmxdT 98PBsZhsNVKp5ypHh48X1K7y1dg2AzMdv8VXX99sgG0t8JoGFbRxlM59Pj9V0/roNUu1QnpVU757/S hv9VA9gj/LKrgq4NGHYYOxEMpaUOO+J3uAJt9nG3JbhTxupYL+Knu6AaLGl4/zqEIezd09gmmIcIKK RtEq0xE8hoReeaCxMZzyIQn0E4Lav+ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: 8bit Subject: [ptxdist] [PATCH] treewide: Consistently use ':' instead to separate user and group for chown X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false Since coreutils 9.1 chown warns when a '.' is used as separator. Fix this consistently also for documentation and scripts that are expected to use busybox's chown which (up to now) has no problem with '.'. Signed-off-by: Uwe Kleine-König --- config/busybox/Config.in | 4 ++-- config/busybox/networking/Config.in | 2 +- projectroot/usr/sbin/mysqlinit | 2 +- scripts/lib/ptxd_lib_dopermissions.awk | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/config/busybox/Config.in b/config/busybox/Config.in index 199cc6ab272f..329e2f8e8a1b 100644 --- a/config/busybox/Config.in +++ b/config/busybox/Config.in @@ -267,10 +267,10 @@ config BUSYBOX_FEATURE_SUID_CONFIG The file has to be owned by user root, group root and has to be writeable only by root: - (chown 0.0 /etc/busybox.conf; chmod 600 /etc/busybox.conf) + (chown 0:0 /etc/busybox.conf; chmod 600 /etc/busybox.conf) The busybox executable has to be owned by user root, group root and has to be setuid root for this to work: - (chown 0.0 /bin/busybox; chmod 4755 /bin/busybox) + (chown 0:0 /bin/busybox; chmod 4755 /bin/busybox) Robert 'sandman' Griebl has more information here: . diff --git a/config/busybox/networking/Config.in b/config/busybox/networking/Config.in index 3a3ad56d93f7..27e0f44ba811 100644 --- a/config/busybox/networking/Config.in +++ b/config/busybox/networking/Config.in @@ -959,7 +959,7 @@ config BUSYBOX_TELNETD FEATURE_SUID enabled. And finally, you should make certain that busybox has been installed setuid root: - chown root.root /bin/busybox + chown root:root /bin/busybox chmod 4755 /bin/busybox with all that done, telnetd _should_ work.... diff --git a/projectroot/usr/sbin/mysqlinit b/projectroot/usr/sbin/mysqlinit index 72b6d1f10cf5..c98946025264 100644 --- a/projectroot/usr/sbin/mysqlinit +++ b/projectroot/usr/sbin/mysqlinit @@ -5,7 +5,7 @@ MYSQLD_OPTS= # since mySQL runs as a regular user, we need to give its working directory # to it. -chown mysql.mysql "$1" +chown mysql:mysql "$1" chmod 0755 "$1" # now let mySQL do its initializing job diff --git a/scripts/lib/ptxd_lib_dopermissions.awk b/scripts/lib/ptxd_lib_dopermissions.awk index 56e951b45b75..9ab45d4979dd 100755 --- a/scripts/lib/ptxd_lib_dopermissions.awk +++ b/scripts/lib/ptxd_lib_dopermissions.awk @@ -7,14 +7,14 @@ BEGIN { $1 ~ "[df]" { printf("chmod %s '.%s'\n" \ - "chown %s.%s '.%s'\n", \ + "chown %s:%s '.%s'\n", \ $5, $2, $3, $4, $2); } $1 ~ "n" { printf("if [ ! \\( -b '.%s' -o -c '.%s' -o -p '.%s' \\) ]; then " \ " mknod -m %s '.%s' %s %s %s\n" \ - " chown %s.%s '.%s'\n" \ + " chown %s:%s '.%s'\n" \ "fi\n", \ $2, $2, $2, $5, $2, $6, $7, $8, $3, $4, $2); } -- 2.38.1