From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [ptxdist] [APPLIED] ptxd_lib_code_signing: Check for errors in cs_import_cert_from_pem()
Date: Fri, 11 Nov 2022 15:31:12 +0100 [thread overview]
Message-ID: <20221111143112.892934-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20221025085921.986289-1-u.kleine-koenig@pengutronix.de>
Thanks, applied as cdb645fbca7ac4b4752a2eb1223ba9baf29cb969.
Michael
[sent from post-receive hook]
On Fri, 11 Nov 2022 15:31:11 +0100, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> cs_import_cert_from_pem() uses a pipe command to do the necessary
> things. If the first command in that pipe fails the whole command should
> be considered failing. So add a call to check_pipe_status as is done in
> cs_import_privkey_from_pem().
>
> Fixes: 8f41183e0afe ("Add initial code signing support")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Message-Id: <20221025085921.986289-1-u.kleine-koenig@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
>
> diff --git a/scripts/lib/ptxd_lib_code_signing.sh b/scripts/lib/ptxd_lib_code_signing.sh
> index 5ba1a4666af4..bafdc16544d3 100644
> --- a/scripts/lib/ptxd_lib_code_signing.sh
> +++ b/scripts/lib/ptxd_lib_code_signing.sh
> @@ -213,6 +213,7 @@ cs_import_cert_from_pem() {
> "${openssl_keyopt[@]}" \
> -in "${pem}" -inform pem -outform der |
> softhsm_pkcs11_tool --type cert --write-object /dev/stdin --label "${role}"
> + check_pipe_status
> }
> export -f cs_import_cert_from_pem
>
prev parent reply other threads:[~2022-11-11 14:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 8:59 [ptxdist] [PATCH] " Uwe Kleine-König
2022-11-11 14:31 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221111143112.892934-1-m.olbrich@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox