From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 20 Sep 2022 16:29:18 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oaeFS-00AWjo-Mw for lore@lore.pengutronix.de; Tue, 20 Sep 2022 16:29:18 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1oaeFS-00053a-0D; Tue, 20 Sep 2022 16:29:18 +0200 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaeFI-00053I-1c; Tue, 20 Sep 2022 16:29:08 +0200 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1oaeFH-00043z-PH; Tue, 20 Sep 2022 16:29:07 +0200 Date: Tue, 20 Sep 2022 16:29:07 +0200 From: Michael Olbrich To: Marc Kleine-Budde Message-ID: <20220920142907.GZ2667@pengutronix.de> Mail-Followup-To: Marc Kleine-Budde , Alexander Dahl , ptxdist@pengutronix.de References: <20220920125705.2728029-1-mkl@pengutronix.de> <20220920125705.2728029-2-mkl@pengutronix.de> <20220920132029.v6bxv2kijh544lpg@pengutronix.de> <20220920141432.GY2667@pengutronix.de> <20220920142035.6ydavqvmhlw5vs32@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220920142035.6ydavqvmhlw5vs32@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [ptxdist] [PATCH 1/7] libcurl: version bump to 7.85 X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Alexander Dahl , ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Tue, Sep 20, 2022 at 04:20:35PM +0200, Marc Kleine-Budde wrote: > On 20.09.2022 16:14:32, Michael Olbrich wrote: > > On Tue, Sep 20, 2022 at 03:20:29PM +0200, Marc Kleine-Budde wrote: > > > On 20.09.2022 15:07:22, Alexander Dahl wrote: > > > > Hello Marc, > > > > > > > > Am Tue, Sep 20, 2022 at 02:56:59PM +0200 schrieb Marc Kleine-Budde: > > > > > Signed-off-by: Marc Kleine-Budde > > > > > --- > > > > > rules/libcurl.make | 9 ++++++++- > > > > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > > > > > > > diff --git a/rules/libcurl.make b/rules/libcurl.make > > > > > index 0d0ac9ea33d0..1ddefa9a5b4e 100644 > > > > > --- a/rules/libcurl.make > > > > > +++ b/rules/libcurl.make > > > > > @@ -105,7 +105,6 @@ LIBCURL_CONF_OPT := \ > > > > > --without-brotli \ > > > > > --without-zstd \ > > > > > --without-gssapi \ > > > > > - --with-default-ssl-backend=$(PTXCONF_LIBCURL_SSL_DEFAULT_BACKEND) \ > > > > > --with-random=/dev/urandom \ > > > > > --with-ca-bundle=$(PTXCONF_LIBCURL_SSL_CABUNDLE_PATH) \ > > > > > --with-ca-path=$(PTXCONF_LIBCURL_SSL_CAPATH_PATH) \ > > > > > @@ -126,6 +125,14 @@ LIBCURL_CONF_OPT := \ > > > > > --without-zsh-functions-dir \ > > > > > --without-fish-functions-dir > > > > > > > > > > +ifdef PTXCONF_LIBCURL_SSL > > > > > +LIBCURL_CONF_OPT += \ > > > > > + --with-default-ssl-backend=$(PTXCONF_LIBCURL_SSL_DEFAULT_BACKEND) > > > > > +else > > > > > +LIBCURL_CONF_OPT += \ > > > > > + --without-ssl > > > > > +endif > > > > > > > > The diff does not match patch subject. > > > > > > Oh, the version bump disappeared after rebasing to current master. Will > > > send a v2. > > > > Why do you need this stuff anyways? From looking at configure.ac, the > > existing options should work. What am I missing here? > > If configure is called with '--with-default-ssl-backend="no"' it fails: > > | checking if GSS-API support is requested... no > | checking whether to enable Windows native SSL/TLS... no > | checking whether to enable Secure Transport... no > | checking whether to enable Amiga native SSL/TLS (AmiSSL v5)... no > | configure: error: TLS not detected, you will not be able to use HTTPS, FTPS, NTLM and more. > | Use --with-openssl, --with-gnutls, --with-wolfssl, --with-mbedtls, --with-nss, --with-schannel, --with-secure-transport, --with-amissl, --with-bearssl or --with-rustls to address this. I think adding ptx/wwo --with{out,}-ssl should work. No need to make the backend conditional. Or $(call ptx/ifdef,PTXCONF_LIBCURL_SSL,,--without-ssl). Either one inserted at the correct place. Michael -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |