From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 19 Sep 2022 16:06:30 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oaHPq-009dAI-JB for lore@lore.pengutronix.de; Mon, 19 Sep 2022 16:06:30 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1oaHPp-0005z5-SP; Mon, 19 Sep 2022 16:06:29 +0200 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaHPk-0005lq-Vw; Mon, 19 Sep 2022 16:06:25 +0200 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1oaHPk-0000eG-9t; Mon, 19 Sep 2022 16:06:24 +0200 Date: Mon, 19 Sep 2022 16:06:24 +0200 From: Michael Olbrich To: Alexander Dahl Message-ID: <20220919140624.GG28082@pengutronix.de> Mail-Followup-To: Alexander Dahl , ptxdist@pengutronix.de References: <20220902102130.29131-1-ada@thorsis.com> <4843812.ST7Gozo1Tx@ada> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4843812.ST7Gozo1Tx@ada> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [ptxdist] [PATCH v3] libzmq: Add some conf env variables not automatically detected X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false Hi, On Fri, Sep 16, 2022 at 09:12:20AM +0200, Alexander Dahl wrote: > Am Freitag, 2. September 2022, 12:21:30 CEST schrieb Alexander Dahl: > > Follow up to the discussion on the last version bump. > > zmq does not (try to) detect these features when cross compiling, > > so we must assist. > > Output of prepare stage contains this now: > > > > checking whether EFD_CLOEXEC is supported... (cached) yes > > … > > checking whether SOCK_CLOEXEC is supported... (cached) yes > > checking whether O_CLOEXEC is supported... (cached) yes > > checking whether SO_BINDTODEVICE is supported... (cached) yes > > checking whether SO_KEEPALIVE is supported... (cached) yes > > checking whether TCP_KEEPCNT is supported... (cached) yes > > checking whether TCP_KEEPIDLE is supported... (cached) yes > > checking whether TCP_KEEPINTVL is supported... (cached) yes > > checking whether TCP_KEEPALIVE is supported... not during cross-compile > > checking whether SO_PRIORITY is supported... (cached) yes > > checking whether getrandom is supported... (cached) yes > > > > Link: > > https://lore.ptxdist.org/ptxdist/20220708151537.GK20240@pengutronix.de/T/#m > > 9b6e02442a30b09d25fe98258051ebd34ee4f94b Signed-off-by: Alexander Dahl > > > > --- > > > > Notes: > > v3: > > - Added s-o-b > > ping? Sorry, I missed this. It's in master now. Michael > > v2: > > - also enable getrandom(2) > > - reorganize comments to reflect glibc follows kernel, > > so years are not swapped > > > > rules/libzmq.make | 24 ++++++++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > > > diff --git a/rules/libzmq.make b/rules/libzmq.make > > index d221ef6ac..94a5f84d8 100644 > > --- a/rules/libzmq.make > > +++ b/rules/libzmq.make > > @@ -34,6 +34,30 @@ LIBZMQ_CONF_ENV := \ > > $(CROSS_ENV) \ > > ac_cv_lib_sodium_sodium_init=no > > > > +# Assume these are always available: > > +# - O_CLOEXEC (2007, kernel 2.6.23, glibc 2.7) > > +# - EFD_CLOEXEC (2008, kernel 2.6.27, glibc 2.9) > > +# - SOCK_CLOEXEC (2008, kernel 2.6.27, glibc 2.9) > > +# - SO_BINDTODEVICE (2009, kernel 2.6.31) > > +# - SO_KEEPALIVE (2009, kernel 2.6.31, glibc 1.x) > > +# - SO_PRIORITY (2009, kernel 2.6.31) > > +# - TCP_KEEPCNT (pre 2005/2013, pre kernel 2.6.12, glibc 2.18) > > +# - TCP_KEEPIDLE (pre 2005/2013, pre kernel 2.6.12, glibc 2.18) > > +# - TCP_KEEPINTVL (pre 2005/2013, pre kernel 2.6.12, glibc 2.18) > > +# - getrandom (2014/2017, kernel 3.17, glibc 2.25) > > +# Note: TCP_KEEPALIVE is not available in glibc/kernel. > > +LIBZMQ_CONF_ENV += \ > > + libzmq_cv_o_cloexec=yes \ > > + libzmq_cv_efd_cloexec=yes \ > > + libzmq_cv_sock_cloexec=yes \ > > + libzmq_cv_so_bindtodevice=yes \ > > + libzmq_cv_so_keepalive=yes \ > > + libzmq_cv_so_priority=yes \ > > + libzmq_cv_tcp_keepcnt=yes \ > > + libzmq_cv_tcp_keepidle=yes \ > > + libzmq_cv_tcp_keepintvl=yes \ > > + libzmq_cv_getrandom=yes > > + > > # > > # autoconf > > # > > > > base-commit: 20275946c697076ca6f696276117daf08ca6f4d1 > > > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |