From: Michael Olbrich <m.olbrich@pengutronix.de>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 1/3] blspec-entry: add linux-appendroot support
Date: Fri, 2 Sep 2022 11:22:42 +0200 [thread overview]
Message-ID: <20220902092242.GX951@pengutronix.de> (raw)
In-Reply-To: <20220902080342.4v2ryk5awaxaw7v6@pengutronix.de>
On Fri, Sep 02, 2022 at 10:03:42AM +0200, Marco Felsch wrote:
> On 22-09-02, Michael Olbrich wrote:
> > On Thu, Sep 01, 2022 at 10:59:39AM +0200, Marco Felsch wrote:
> > > Add a Kconfig switch to set the linxu-appendroot option to true. This
> > > can be very useful for the Barebox bootloader.
> > >
> > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > > ---
> > > platforms/blspec-entry.in | 10 ++++++++++
> > > projectroot/loader/entries/default.conf | 1 +
> > > rules/blspec-entry.make | 10 +++++++++-
> > > 3 files changed, 20 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/platforms/blspec-entry.in b/platforms/blspec-entry.in
> > > index aed65d40a..1a4ecb26c 100644
> > > --- a/platforms/blspec-entry.in
> > > +++ b/platforms/blspec-entry.in
> > > @@ -16,4 +16,14 @@ config BLSPEC_ENTRY_CMDLINE
> > > string
> > > prompt "kernel command-line"
> > >
> > > +config BLSPEC_ENTRY_APPENDROOT
> > > + bool
> > > + prompt "Set linux-appendroot to true"
> > > + help
> > > + If enabled this options adds 'linux-appendroot true' to the blspec
> > > + entry else 'linux-appendroot false' is added. This is a useful
> > > + Barebox specific option. Barebox will set the the 'root=' kernel
> > > + command line parameter to the source from which Barebox loaded the
> > > + kernel image if specified.
> > > +
> > > endif
> > > diff --git a/projectroot/loader/entries/default.conf b/projectroot/loader/entries/default.conf
> > > index 5650907ab..d28156975 100644
> > > --- a/projectroot/loader/entries/default.conf
> > > +++ b/projectroot/loader/entries/default.conf
> > > @@ -3,3 +3,4 @@ version @VERSION@
> > > options @CMDLINE@
> > > linux @KERNEL@
> > > @DEVICETREE@
> > > +@LINUXAPPENDROOT@
> > > diff --git a/rules/blspec-entry.make b/rules/blspec-entry.make
> > > index f393b1bda..c0d2416cf 100644
> > > --- a/rules/blspec-entry.make
> > > +++ b/rules/blspec-entry.make
> > > @@ -35,6 +35,12 @@ else
> > > BLSPEC_KERNEL_IMAGE = $(KERNEL_IMAGE)
> > > endif
> > >
> > > +ifdef PTXCONF_BLSPEC_ENTRY_APPENDROOT
> > > +BLSPEC_APPENDROOT = linux-appendroot\ttrue
> > > +else
> > > +BLSPEC_APPENDROOT = linux-appendroot\tfalse
> >
> > Hmm, that's the default, right? So use an empty string here. It keeps the
> > file shorter and (mostly) unchanged for those that keep the option
> > disabled. It's a non-standard option so I'd prefer to not have it here
> > unless it is explicitly enabled.
>
> Okay, I will do that. Just one question will it add a blank line instead
> or is the line taken by @LINUXAPPENDROOT@ completely gone?
It will be a blank line, but I think that's ok. You could merge it with the
@DEVICETREE@ line and add a '\n' at the beginning of the substitution.
But I'm not sure if it's worth it.
Michael
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2022-09-02 9:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 8:59 Marco Felsch
2022-09-01 8:59 ` [ptxdist] [PATCH 2/3] host-system-python3: add ply and pyyaml option Marco Felsch
2022-09-11 7:10 ` [ptxdist] [APPLIED] " Michael Olbrich
2022-09-01 8:59 ` [ptxdist] [PATCH 3/3] host-system-python3: order options alphabetical Marco Felsch
2022-09-11 7:10 ` [ptxdist] [APPLIED] " Michael Olbrich
2022-09-02 7:20 ` [ptxdist] [PATCH 1/3] blspec-entry: add linux-appendroot support Michael Olbrich
2022-09-02 8:03 ` Marco Felsch
2022-09-02 9:22 ` Michael Olbrich [this message]
2022-09-02 10:37 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220902092242.GX951@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=m.felsch@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox