From mboxrd@z Thu Jan  1 00:00:00 1970
Delivery-date: Fri, 29 Jul 2022 08:29:55 +0200
Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33])
	by lore.white.stw.pengutronix.de with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <ptxdist-bounces+lore=lore.pengutronix.de@pengutronix.de>)
	id 1oHJVT-003GKD-HG
	for lore@lore.pengutronix.de; Fri, 29 Jul 2022 08:29:55 +0200
Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de)
	by metis.ext.pengutronix.de with esmtp (Exim 4.92)
	(envelope-from <ptxdist-bounces@pengutronix.de>)
	id 1oHJVS-0005D7-MC; Fri, 29 Jul 2022 08:29:54 +0200
Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])
 by metis.ext.pengutronix.de with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <mol@pengutronix.de>)
 id 1oHJPf-0006VQ-32; Fri, 29 Jul 2022 08:23:55 +0200
Received: from [2a0a:edc0:0:1101:1d::39] (helo=dude03.red.stw.pengutronix.de)
 by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2)
 (envelope-from <mol@pengutronix.de>)
 id 1oHJPd-000SOu-Vi; Fri, 29 Jul 2022 08:23:53 +0200
Received: from mol by dude03.red.stw.pengutronix.de with local (Exim 4.94.2)
 (envelope-from <mol@pengutronix.de>)
 id 1oHJPd-00A2dz-2B; Fri, 29 Jul 2022 08:23:53 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Date: Fri, 29 Jul 2022 08:23:53 +0200
Message-Id: <20220729062353.2393400-1-m.olbrich@pengutronix.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220708071102.18393-5-ada@thorsis.com>
References: <20220708071102.18393-5-ada@thorsis.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [ptxdist] [APPLIED] libzmq: Prefer external libsodium over
 internal tweetnacl
X-BeenThere: ptxdist@pengutronix.de
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Cc: Alexander Dahl <ada@thorsis.com>
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
X-SA-Exim-Connect-IP: 127.0.0.1
X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false

Thanks, applied as 6fbe59dec2ceb561821749e3ad80c24c3c18bc07.

Michael

[sent from post-receive hook]

On Fri, 29 Jul 2022 08:23:52 +0200, Alexander Dahl <ada@thorsis.com> wrote:
> The external library is faster and seems to be better maintained.
> 
> Signed-off-by: Alexander Dahl <ada@thorsis.com>
> Message-Id: <20220708071102.18393-5-ada@thorsis.com>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/libzmq.in b/rules/libzmq.in
> index c272f845d8ed..f03831ecde0a 100644
> --- a/rules/libzmq.in
> +++ b/rules/libzmq.in
> @@ -3,6 +3,7 @@
>  config LIBZMQ
>  	tristate
>  	prompt "libzmq"
> +	select LIBSODIUM
>  	help
>  	  The zeroMQ lightweight messaging kernel is a library which extends the
>  	  standard socket interfaces with features traditionally provided by
> diff --git a/rules/libzmq.make b/rules/libzmq.make
> index a8eab129f1f1..d221ef6ac1db 100644
> --- a/rules/libzmq.make
> +++ b/rules/libzmq.make
> @@ -65,7 +65,7 @@ LIBZMQ_CONF_OPT		:= \
>  	--without-docs \
>  	--with-poller=epoll \
>  	--without-libgssapi_krb5 \
> -	--without-libsodium \
> +	--with-libsodium \
>  	--without-nss \
>  	--without-tls \
>  	--without-pgm \