From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 29 Jul 2022 08:26:58 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oHJSc-003G8Y-2g for lore@lore.pengutronix.de; Fri, 29 Jul 2022 08:26:58 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1oHJSb-00021A-D1; Fri, 29 Jul 2022 08:26:57 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oHJPL-00065U-LQ; Fri, 29 Jul 2022 08:23:35 +0200 Received: from [2a0a:edc0:0:1101:1d::39] (helo=dude03.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1oHJPK-000SNh-VL; Fri, 29 Jul 2022 08:23:34 +0200 Received: from mol by dude03.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1oHJPJ-00A2JL-SM; Fri, 29 Jul 2022 08:23:33 +0200 From: Michael Olbrich To: ptxdist@pengutronix.de Date: Fri, 29 Jul 2022 08:23:33 +0200 Message-Id: <20220729062333.2392120-1-m.olbrich@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220704121831.23787-6-ada@thorsis.com> References: <20220704121831.23787-6-ada@thorsis.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [ptxdist] [APPLIED] dropbear: Append hints to some menu prompts X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Alexander Dahl Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false Thanks, applied as 689eb5a63e35183cce4760a5fbdc1ede7c47e428. Michael [sent from post-receive hook] On Fri, 29 Jul 2022 08:23:33 +0200, Alexander Dahl wrote: > We present multiple options in the menu here, so add some more guidance > for the non experienced user. > > Signed-off-by: Alexander Dahl > Message-Id: <20220704121831.23787-6-ada@thorsis.com> > Signed-off-by: Michael Olbrich > > diff --git a/rules/dropbear.in b/rules/dropbear.in > index 25b92839b64e..33e8500a93ee 100644 > --- a/rules/dropbear.in > +++ b/rules/dropbear.in > @@ -150,7 +150,7 @@ config DROPBEAR_AES128 > > config DROPBEAR_3DES > bool > - prompt "3DES" > + prompt "3DES (legacy)" > help > DES is an IBM algorithm designed during the 1970s. > In 1976, NIST has officially adopted it as an encryption > @@ -182,7 +182,7 @@ config DROPBEAR_CHACHA20POLY1305 > > config DROPBEAR_CBC_CIPHERS > bool > - prompt "CBC mode ciphers" > + prompt "CBC mode ciphers (legacy)" > help > Enable CBC mode for ciphers. This has security issues though > is the most compatible with older SSH implementations. > @@ -196,11 +196,11 @@ config DROPBEAR_CTR_CIPHERS > CBC mode against certain attacks. This adds around 1kB to binary > size and is recommended for most cases. > > -comment "Integrity, at least one required --- sha2-256 is recommended as a default, sha1 for compatibility" > +comment "Message Integrity (HMAC), at least one required ---" > > config DROPBEAR_SHA1 > bool > - prompt "sha1" > + prompt "sha1 (compat)" > help > The Secure Hash Algorithm (SHA) was developed by NIST and > is specified in the Secure Hash Standard (SHS, FIPS 180). > @@ -212,7 +212,7 @@ config DROPBEAR_SHA1 > > config DROPBEAR_SHA1_96 > bool > - prompt "sha1-96" > + prompt "sha1-96 (legacy)" > help > The Secure Hash Algorithm (SHA) was developed by NIST and > is specified in the Secure Hash Standard (SHS, FIPS 180). > @@ -224,7 +224,7 @@ config DROPBEAR_SHA1_96 > > config DROPBEAR_SHA256 > bool > - prompt "sha256" > + prompt "sha256 (recommended)" > default y > help > SHA-2 is a set of cryptographic hash functions (SHA-224, SHA-256,