Re: [ptxdist] [PATCH 0/4] zeromq: version bump

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Fri, Jul 08, 2022 at 09:10:58AM +0200, Alexander Dahl wrote:
> Hello,
> 
> for a proprietary SDK in on of our BSPs we need a recent version of
> zeromq, so I took the opportunity to upgrade it.  The first three
> patches should be straight forward, although a lot of new configure
> options were introduced.
> 
> The fourth patch switches from embedded tweetnacl to external libsodium,
> which I sent for a version bump series yesterday.  I'm not 100% sure
> about that change, anyone with a better understanding of security
> implications might veto that patch.

I don't think there was an explicit decision to use the embedded library.
Using the external external libsodium make sense to me, so I applied the
patch with the rest.

Michael

> One thing more: buildroot sets some autoconf cache variables [1] which
> are reported in zeromq prepare step (configure) like this:
> 
>     checking whether EFD_CLOEXEC is supported... not during cross-compile
>     …
>     checking whether SOCK_CLOEXEC is supported... not during cross-compile
>     checking whether O_CLOEXEC is supported... not during cross-compile
>     checking whether SO_BINDTODEVICE is supported... not during cross-compile
>     checking whether SO_KEEPALIVE is supported... not during cross-compile
>     checking whether TCP_KEEPCNT is supported... not during cross-compile
>     checking whether TCP_KEEPIDLE is supported... not during cross-compile
>     checking whether TCP_KEEPINTVL is supported... not during cross-compile
>     checking whether TCP_KEEPALIVE is supported... not during cross-compile
>     checking whether SO_PRIORITY is supported... not during cross-compile
>     checking whether getrandom is supported... not during cross-compile
> 
> Not sure if this should be taken care of by ptxdist's receipe, too?  It
> could be added in a separate patch then.
> 
> Greets
> Alex
> 
> [1] https://git.busybox.net/buildroot/tree/package/zeromq/zeromq.mk
> 
> Alexander Dahl (4):
>   libzmq: Pin some more configure options
>   libzmq: Revise license and add license file hashes
>   libzmq: version bump 4.0.4 -> 4.3.4
>   libzmq: Prefer external libsodium over internal tweetnacl
> 
>  rules/libzmq.in   |  1 +
>  rules/libzmq.make | 41 ++++++++++++++++++++++++++++++++++-------
>  2 files changed, 35 insertions(+), 7 deletions(-)
> 
> 
> base-commit: 7384b37919cb66e12ff15b4264325cb5eba911c3
> -- 
> 2.30.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |