From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 08 Jul 2022 11:26:37 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1o9kFu-00ALHj-CE for lore@lore.pengutronix.de; Fri, 08 Jul 2022 11:26:37 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1o9kFw-0007AY-9i; Fri, 08 Jul 2022 11:26:36 +0200 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9kFc-0007A1-HN; Fri, 08 Jul 2022 11:26:16 +0200 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1o9kFc-0000UM-4e; Fri, 08 Jul 2022 11:26:16 +0200 Date: Fri, 8 Jul 2022 11:26:16 +0200 From: Michael Olbrich To: Alexander Dahl Message-ID: <20220708092616.GG20240@pengutronix.de> Mail-Followup-To: Alexander Dahl , ptxdist@pengutronix.de, Alexander Aring References: <20220708071102.18393-1-ada@thorsis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220708071102.18393-1-ada@thorsis.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [ptxdist] [PATCH 0/4] zeromq: version bump X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Alexander Aring , ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Fri, Jul 08, 2022 at 09:10:58AM +0200, Alexander Dahl wrote: > Hello, > > for a proprietary SDK in on of our BSPs we need a recent version of > zeromq, so I took the opportunity to upgrade it. The first three > patches should be straight forward, although a lot of new configure > options were introduced. > > The fourth patch switches from embedded tweetnacl to external libsodium, > which I sent for a version bump series yesterday. I'm not 100% sure > about that change, anyone with a better understanding of security > implications might veto that patch. > > One thing more: buildroot sets some autoconf cache variables [1] which > are reported in zeromq prepare step (configure) like this: > > checking whether EFD_CLOEXEC is supported... not during cross-compile > … > checking whether SOCK_CLOEXEC is supported... not during cross-compile > checking whether O_CLOEXEC is supported... not during cross-compile > checking whether SO_BINDTODEVICE is supported... not during cross-compile > checking whether SO_KEEPALIVE is supported... not during cross-compile > checking whether TCP_KEEPCNT is supported... not during cross-compile > checking whether TCP_KEEPIDLE is supported... not during cross-compile > checking whether TCP_KEEPINTVL is supported... not during cross-compile > checking whether TCP_KEEPALIVE is supported... not during cross-compile > checking whether SO_PRIORITY is supported... not during cross-compile > checking whether getrandom is supported... not during cross-compile > > Not sure if this should be taken care of by ptxdist's receipe, too? It > could be added in a separate patch then. Yes please. All of those features are available an any reasonably new Linux kernel and glibc. I think there are cache variables for all of those (e.g. libzmq_cv_efd_cloexec), so just add those to the _CONF_ENV. Michael > Greets > Alex > > [1] https://git.busybox.net/buildroot/tree/package/zeromq/zeromq.mk > > Alexander Dahl (4): > libzmq: Pin some more configure options > libzmq: Revise license and add license file hashes > libzmq: version bump 4.0.4 -> 4.3.4 > libzmq: Prefer external libsodium over internal tweetnacl > > rules/libzmq.in | 1 + > rules/libzmq.make | 41 ++++++++++++++++++++++++++++++++++------- > 2 files changed, 35 insertions(+), 7 deletions(-) > > > base-commit: 7384b37919cb66e12ff15b4264325cb5eba911c3 > -- > 2.30.2 > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |