From mboxrd@z Thu Jan  1 00:00:00 1970
Delivery-date: Mon, 20 Jun 2022 08:20:49 +0200
Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33])
	by lore.white.stw.pengutronix.de with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <ptxdist-bounces+lore=lore.pengutronix.de@pengutronix.de>)
	id 1o3AmF-007o4L-Ty
	for lore@lore.pengutronix.de; Mon, 20 Jun 2022 08:20:49 +0200
Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de)
	by metis.ext.pengutronix.de with esmtp (Exim 4.92)
	(envelope-from <ptxdist-bounces@pengutronix.de>)
	id 1o3AmE-000534-DR; Mon, 20 Jun 2022 08:20:46 +0200
Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])
 by metis.ext.pengutronix.de with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <mol@pengutronix.de>)
 id 1o3Akx-0004Qb-6U; Mon, 20 Jun 2022 08:19:27 +0200
Received: from [2a0a:edc0:0:1101:1d::39] (helo=dude03.red.stw.pengutronix.de)
 by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2)
 (envelope-from <mol@pengutronix.de>)
 id 1o3Aku-001afM-Qw; Mon, 20 Jun 2022 08:19:26 +0200
Received: from mol by dude03.red.stw.pengutronix.de with local (Exim 4.94.2)
 (envelope-from <mol@pengutronix.de>)
 id 1o3Akv-006FsW-Ju; Mon, 20 Jun 2022 08:19:25 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Date: Mon, 20 Jun 2022 08:19:25 +0200
Message-Id: <20220620061925.1490961-1-m.olbrich@pengutronix.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220430113724.6133-1-bruno.thomsen@gmail.com>
References: <20220430113724.6133-1-bruno.thomsen@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [ptxdist] [APPLIED] polkit: add pkexec install option
X-BeenThere: ptxdist@pengutronix.de
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Cc: Bruno Thomsen <bruno.thomsen@gmail.com>
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
X-SA-Exim-Connect-IP: 127.0.0.1
X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false

Thanks, applied as 0bbd0652f102aa42186ca1eb27fce5a0d4dc9d52.

Michael

[sent from post-receive hook]

On Mon, 20 Jun 2022 08:19:25 +0200, Bruno Thomsen <bruno.thomsen@gmail.com> wrote:
> Disable default install of pkexec SUID binary as it's an old way of
> executing a command as another user or with elevated privileges.
> 
> Fedora will also avoid installing pkexec[1], and put it in an optional
> compat RPM package.
> 
> [1] https://fedoraproject.org/wiki/Changes/polkit_recommends_pkla_pkexec
> 
> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> Message-Id: <20220430113724.6133-1-bruno.thomsen@gmail.com>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/polkit.in b/rules/polkit.in
> index 6085fbf783d6..8227cafbcaf8 100644
> --- a/rules/polkit.in
> +++ b/rules/polkit.in
> @@ -29,4 +29,14 @@ config POLKIT_SYSTEMD
>  	help
>  	  Use systemd for session tracking, else ConsoleKit is used
>  
> +comment "install options   ---"
> +
> +config POLKIT_PKEXEC
> +	bool
> +	prompt "Install pkexec"
> +	help
> +	  pkexec - Execute a command as another user or with elevated privileges.
> +
> +	  Old and obsolete tool. Use 'sudo' for this kind of task.
> +
>  endif
> diff --git a/rules/polkit.make b/rules/polkit.make
> index 4fa8d9c0edb1..368fbe3e4d3c 100644
> --- a/rules/polkit.make
> +++ b/rules/polkit.make
> @@ -96,7 +96,9 @@ endif
>  	@$(call install_copy, polkit, 0, 0, 0755, -, /usr/libexec/polkitd)
>  
>  # binaries with suid
> +ifdef PTXCONF_POLKIT_PKEXEC
>  	@$(call install_copy, polkit, 0, 0, 4755, -, /usr/bin/pkexec)
> +endif
>  	@$(call install_copy, polkit, 0, 0, 4755, -, \
>  		/usr/libexec/polkit-agent-helper-1)
>