From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 17 Jun 2022 12:58:22 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1o29gC-0057Rp-PO for lore@lore.pengutronix.de; Fri, 17 Jun 2022 12:58:22 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1o29gD-0000C6-5k; Fri, 17 Jun 2022 12:58:21 +0200 Received: from mout.kundenserver.de ([217.72.192.74]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o29ft-0000Ba-9c; Fri, 17 Jun 2022 12:58:01 +0200 Received: from methusalix.internal.home.lespocky.de ([92.117.61.140]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1M5PRT-1o1KKT0TR7-001SsO; Fri, 17 Jun 2022 12:58:00 +0200 Received: from falbala.internal.home.lespocky.de ([192.168.243.94]) by methusalix.internal.home.lespocky.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1o29fk-0007pK-SQ; Fri, 17 Jun 2022 12:57:58 +0200 Date: Fri, 17 Jun 2022 12:57:51 +0200 From: Alexander Dahl To: Enrico =?iso-8859-1?Q?J=F6rns?= , ptxdist@pengutronix.de, jlu@pengutronix.de Message-ID: <20220617105751.GD2412@falbala.internal.home.lespocky.de> Mail-Followup-To: Enrico =?iso-8859-1?Q?J=F6rns?= , ptxdist@pengutronix.de, jlu@pengutronix.de References: <20220615142217.990960-1-ejo@pengutronix.de> <20220615142217.990960-3-ejo@pengutronix.de> <20220617102750.GQ13709@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OaZoDhBhXzo6bW1J" Content-Disposition: inline In-Reply-To: <20220617102750.GQ13709@pengutronix.de> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-Scan-Signature: ce3633ab77e2f8ee4aa3f6f3793b08d1 X-Provags-ID: V03:K1:Ke8Qa4LN8+u1TRsusQ9UW9LYcNvgjDHTofDndhRNnVGAlXVRjT2 Y35Xdkw0zZ/dM8WgM4InHYlV4KTVaoNAlOw2Ht4e047gM46etqoy6eZ/Qfi6t9OMvRu3cgy H+9O1KGPQREsaqTZ+IkooQiglQbdsuoAurpNlEuXk5iWfnuHFe69UVwytC2dCkYJGJp8Pwc aoKPfdfPymg5Hg8fhgjBw== X-UI-Out-Filterresults: notjunk:1;V03:K0:LAjLY03NQCQ=:xtVl2RqE4paRHl8iqHRVBF RN35ZK2nGXCM7c/kU7CpHNPOyiWUVINYSsEjyCTWu8OklMzKNAXiMX4um9VRCsjVit/CwrSyx alk119FnqNMKy7ffvGgVxeTsxh4qQVzcbzFDsQkCJKMid6qVC/XG2Iy+kkfAG5YT1vmrsZ5V4 jG5Qhxy+VGMeUhoZAcHk82nFYKzRDnY9RwXm3CgsiYimug5qnq5B9gqphMRV1uSCmM7tyZpJo RFtvlbKoblYp6+/e85BC3JNNqpASBRbvnbhbsAJrOKm1lRNkwjKqoXYhyJOQDR6VSym0Yu1TN MioGVnFHn7AXa8VOnEbiMlrrEJoBKCey8+Tb5oo7iAODV14607pE1sUnY8WTIOQa/JBbfxAtx pLPdUJX5W5Mj6cYZTCx5O5kNwdulVuft8L+ut1nNx3aoW5vbbHeGY86xIdZv5ve7KqbeBYpIM W5ka0xOjRWuFB3t5LtvBw5zB3DByy+OXbzL9NJrSTc6cMHs1A0EBAVqeo4UHW3L2lqzcUv4/v /UIExs6u7ngxJbPe4imTTOp3bpFHItgSAEka7qjS64JowNIujG08K6x1PBBcuidqqSdN36JO4 s+MG4KNP8X/qq7pxrr0ucPbJ+KGlPYBafexeijoOjt8aa8Okk6CG5k++CDHk/LeumKyIFBrmD CrJsXa4TEaOjaJ62FjuXyHhwLcMY6fw4ODcGGl5r6piqNHDdu7KAajtY7s4oHHObcn/0R4Jmv uRfu6hr5bpLAy+kc0ObT6cojMjrx9DPVoK0EKw== X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.3 required=4.0 tests=AWL,BAYES_00, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH 2/5] RAUC: add option to enable streaming support X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false --OaZoDhBhXzo6bW1J Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Moin, On Fri, Jun 17, 2022 at 12:27:50PM +0200, Michael Olbrich wrote: > On Fri, Jun 17, 2022 at 11:47:19AM +0200, Enrico J=F6rns wrote: > > Am Freitag, dem 17.06.2022 um 08:28 +0200 schrieb Michael Olbrich: > > > On Wed, Jun 15, 2022 at 04:22:14PM +0200, Enrico Jorns wrote: > > > > Enable it by default so that default installation can benefit from = this. > > > > Can be deactivated for saving space or for deactivating network > > > > functionality. > > > > Web server must support HTTP range requests for this and NBD support > > > > must be enabled in kernel. > > > >=20 > > > > Signed-off-by: Enrico Jorns > > > > --- > > > > rules/rauc.in | 11 +++++++++++ > > > > rules/rauc.make | 1 + > > > > 2 files changed, 12 insertions(+) > > > >=20 > > > > diff --git a/rules/rauc.in b/rules/rauc.in > > > > index aee162b83..832967b44 100644 > > > > --- a/rules/rauc.in > > > > +++ b/rules/rauc.in > > > > @@ -13,6 +13,7 @@ menuconfig RAUC > > > > select BUSYBOX_FEATURE_SEAMLESS_GZ if BUSYBOX_TAR > > > > select DBUS if RAUC_SERVICE > > > > select LIBCURL if RAUC_NETWORK > > > > + select LIBNL3 if RAUC_STREAMING > > > > select JSON_GLIB if RAUC_JSON > > > > select UTIL_LINUX_NG_LIBFDISK if RAUC_GPT > > > > select SQUASHFS_TOOLS if RUNTIME > > > > @@ -44,6 +45,16 @@ config RAUC_NETWORK > > > > Note that network is primarily designed to be used for RAUC'S c= async > > > > capabilities, not for fetching full bundles. > > > > =20 > > > > +config RAUC_STREAMING > > > > + bool > > > > + prompt "Enable streaming support" > > > > + default y > > >=20 > > > Why 'default y'? I think most users won't need this. > >=20 > > I am not convinced that streaming is not required for most users. I gue= ss that > > being able to download bundles form HTTP directly is a use case that is= more and > > more common. With network and streaming enabled, one can download bundl= es only > > externally or install from USB sticks etc. > >=20 > > In Yocto we have this enabled by default, too. If it's ptxdist's philos= ophy to > > ship as little features as possible by default (i.e. focus on small siz= e), we > > can also make this default n. >=20 > The thing is, nobody changes the defaults unless they notice something is > not working as expected. And enabling things in PTXdist is easy. Despite how the default should be if one enables RAUC the first time, how does this behave when upgrading? I mean if I have RAUC enabled and running with some method, then this update comes along. Does ptxdist enable that option on migrate? I yes I would opt against making this default y, because that would just add a then unused feature. A >=20 > How does this work anyways? If I call 'rauc install ', will this > use streaming implicitly or does it require an explicit option? >=20 > How about 'default RAUC_NETWORK'? This way those that use networking also > get streaming by default. >=20 > I can do a fixup here if this makes sense. >=20 > Michael >=20 >=20 > > > > + select RAUC_NETWORK > > > > + help > > > > + Enables built-in HTTP(S) streaming support that allows RAUC to > > > > + access remote bundles via http/https and write images without t= he > > > > + need for intermediate storage on the target. > > > > + > > > > config RAUC_JSON > > > > bool > > > > prompt "JSON support" > > > > diff --git a/rules/rauc.make b/rules/rauc.make > > > > index 46d196bed..820583e59 100644 > > > > --- a/rules/rauc.make > > > > +++ b/rules/rauc.make > > > > @@ -43,6 +43,7 @@ RAUC_CONF_OPT :=3D \ > > > > --disable-valgrind \ > > > > --$(call ptx/endis,PTXCONF_RAUC_SERVICE)-service \ > > > > --$(call ptx/endis,PTXCONF_RAUC_NETWORK)-network \ > > > > + --$(call ptx/endis,PTXCONF_RAUC_STREAMING)-streaming \ > > > > --$(call ptx/endis,PTXCONF_RAUC_JSON)-json \ > > > > --$(call ptx/endis,PTXCONF_RAUC_GPT)-gpt \ > > > > --with-systemdunitdir=3D/usr/lib/systemd/system \ > > > > --=20 > > > > 2.30.2 > > > >=20 > > > >=20 > > > >=20 > > >=20 > >=20 > > --=20 > > Pengutronix e.K.=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0| Enrico J=F6rns=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0| > > Embedded Linux Consulting & Support=A0=A0=A0=A0=A0=A0=A0=A0| https://ww= w.pengutronix.de/ | > > Steuerwalder Str. 21=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0| Phone: +49-5121-206917-180=A0=A0| > > 31137 Hildesheim, Germany=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0| Fax:=A0=A0=A0+49-5121-206917-9=A0=A0=A0=A0| > >=20 >=20 > --=20 > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --=20 /"\ ASCII RIBBON | =BBWith the first link, the chain is forged. The first \ / CAMPAIGN | speech censured, the first thought forbidden, the X AGAINST | first freedom denied, chains us all irrevocably.=AB / \ HTML MAIL | (Jean-Luc Picard, quoting Judge Aaron Satie) --OaZoDhBhXzo6bW1J Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEwo7muQJjlc+Prwj6NK3NAHIhXMYFAmKsXisACgkQNK3NAHIh XMacWxAAsKM06d46uDvB9+kqvaQGS2q7XWSSB7Vwgux0mFJVX/sv03UwNO1W+6Pm x1TeC8gGWxRTFRYp0MVWS8RA+Gk0Hyu0YOIFiIlWQrHiPG8EY8SEXhg/1mQYkZTg Q900+nCaQcQjarYL/Ke2ttDZDtKnguix9LylFmu1e6MAnOxsXy+14fvSIdD64wZf KC6dtxCCqasQeg/QXwgML4gHUni+WQCMiaEcZJHzQb9eJ+LOUox7hoPE/ts9y8z5 bFBZD9Waf3SUlXC6+fAq8QK0Zrijrmohrf5m8dfCaITeifJ1BRUnOqURIV26bZdZ YQx+eiwq0h02CuVXor1kzOXMZo+7QagYOQBSKWiQMP6hSaCTuxAie4weRDz4Pf4s WIgmcpdnrCkm6ag1rY/3DtIMoeubXHUrlWxeesuSTHAi3xnm4MLp4vc7SHPL9IQG cZ0FT6C6o3RrwMIMyPS81uOrB9VphMiTteW3iDNh3L/35cl0G5lr81iA9tS7d4xh UhPU1LBX/UfCRmjT13PtIyqUs779+5ejPWRlEax/noy0fjiSI21Og0m/Vf4p2OlN EqjtD/LnDPoSJjYptjnh+LXLI1Ze0HfytyTcOIkNuyAkl+RhAqZbQ9DDEMXsoy5n ckrMkEdwkP/vsiewwUzcLB1niuVdJNqDd0jpfRUos/lT0+s1y7E= =tarP -----END PGP SIGNATURE----- --OaZoDhBhXzo6bW1J--