From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 16 Jun 2022 08:17:29 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1o1ioq-003coz-Mg for lore@lore.pengutronix.de; Thu, 16 Jun 2022 08:17:29 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1o1ior-0003cz-FR; Thu, 16 Jun 2022 08:17:29 +0200 Received: from mout.kundenserver.de ([212.227.126.135]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o1ioE-0003cd-Cs; Thu, 16 Jun 2022 08:16:54 +0200 Received: from methusalix.internal.home.lespocky.de ([92.117.53.219]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MdwRi-1nSwDn0Zb4-00b60W; Thu, 16 Jun 2022 08:16:41 +0200 Received: from falbala.internal.home.lespocky.de ([192.168.243.94]) by methusalix.internal.home.lespocky.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1o1iny-0005eb-1t; Thu, 16 Jun 2022 08:16:39 +0200 Date: Thu, 16 Jun 2022 08:16:33 +0200 From: Alexander Dahl To: Enrico =?iso-8859-1?Q?J=F6rns?= Message-ID: <20220616061632.GC2412@falbala.internal.home.lespocky.de> Mail-Followup-To: Enrico =?iso-8859-1?Q?J=F6rns?= , Alexander Dahl , ptxdist@pengutronix.de, jlu@pengutronix.de References: <20220615142217.990960-1-ejo@pengutronix.de> <20220615142217.990960-4-ejo@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uXxzq0nDebZQVNAZ" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-Scan-Signature: 2624b60548d4e13e95c5768e45248f76 X-Provags-ID: V03:K1:HRDub1oA/lm8VV384ebdkMjw38cE5D4g90fPAMHPvSfTHdwYVYt 4FkQ8ZpcmUbQRtBuSqZxg7uMAC9wsyyqWE2xO3muNb1ZVgoZitvG0O1W4K9vOp2PZRaiKCA mSP5ijwxqFpPYqBFqSzN1blt1Gf/Dtdl9Z4ska94t43mChZjhFOZ/qcQ8kJQtDu/1SrawYq F+MrPPuRtCzvdT5YR7/DA== X-UI-Out-Filterresults: notjunk:1;V03:K0:qf+Ps5wSwuk=:xzha88rBeKNah0hQivGemL nfVVq428vHZWbuWVcCLZ2EQEYHytV0CgVP8rnw9z7LVQ1Cekv7GfY4uZ3PNkHXsD8tLaajbA3 vjnzbIG16wbpnd9EvhTKTnmtch6zTViNo0kDA43Tq7Oe/JjytHc64VTUjizzMLpY37QiX0ymz h1T2j0Q8g5ERc68gwM0R1uXk24xNUQl+lxqzAGV+jLMVBb5F87G7zucDKpPDSqMKcvNhbwycY CKew0ucTKqgOLK+LvLzM1Z7Bh4LZmftgJ396bYCGO+0fwf2Ls/napRzAJJJ6T97YzMqMdxVVF cneiwWDkXjxVmmfGzk0EBzCU5ohinWuyEZBe/5dZCFudE8nsq9keXwaWNbU+YMGENKQDDjXCo zFGfn+dc1cdGwK3/e4K3eWosi9C/eCZoXbVm96RWDQmoNfse8VXCiaauWvahXwcD+vrkIhCYu HKnDJY01YpstXug9bPkHFLsaKo45NcmU5jvsCfWrhYyo3Nt85QT3DXWE/dk/EQEJTAhh+R2wN mf1ZfTrqbjFH94YCR7CTNdWsVJEql0FCQ+1sRugl5tCDEjHdLHHhczEPsAq8Rhpx/m7suGXPR BHFj4dd+Dp245oyI62+wMknO12F3XnGB3x5ALvQEFmMa97UleEh2+YrQYyjw8MGUQRoJxbHT3 fT90XTwFbC4UJ70ybTFoqABKHQNCVZ1iCQIJBTdd3GQLMRSO8eCkOKdA+d5gJ4jvIjGIXw11A umcYKUXISjaLo8YKefpJQTUMHZ5b2GrRCFwhoQ== X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.3 required=4.0 tests=AWL,BAYES_00, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH 3/5] RAUC: leverage --disable-create option to shrink size for target RAUC X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Alexander Dahl , ptxdist@pengutronix.de, jlu@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false --uXxzq0nDebZQVNAZ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Enrico, On Wed, Jun 15, 2022 at 11:03:21PM +0200, Enrico J=C3=B6rns wrote: > Hi Alex, >=20 > Am Mittwoch, dem 15.06.2022 um 17:48 +0200 schrieb Alexander Dahl: > > Hello Enrico, > >=20 > > this might be nitpicking, but still =E2=80=A6 > >=20 > > Am Wed, Jun 15, 2022 at 04:22:15PM +0200 schrieb Enrico Jorns: > > > We do not need bundle creation capabilities on the target in most cas= es, > > > thus make this optional (and disable by default). > > >=20 > > > Signed-off-by: Enrico Jorns > > > --- > > > rules/host-rauc.make | 1 + > > > rules/rauc.in | 10 ++++++++++ > > > rules/rauc.make | 1 + > > > 3 files changed, 12 insertions(+) > > >=20 > > > diff --git a/rules/host-rauc.make b/rules/host-rauc.make > > > index c78a518f6..1851aee9a 100644 > > > --- a/rules/host-rauc.make > > > +++ b/rules/host-rauc.make > > > @@ -23,6 +23,7 @@ HOST_RAUC_CONF_OPT :=3D \ > > > $(HOST_AUTOCONF) \ > > > --disable-code-coverage \ > > > --disable-valgrind \ > > > + --enable-create \ > >=20 > > From the cover letter I understood this is a new post 1.5 option, > > right? >=20 > almost, as the cover-letter explicitly notes this is a post 1.3 option. ;) >=20 > And this line is only for completeness. The added option in RAUC is seman= tically > --disable-create and --enable-create is the default. make rules in ptxdist pin down _all_ configure options, so if that was missing for 1.5 package it was already forgotten to set when upgrading =66rom 1.3 or 1.4. > > > --disable-service \ > > > --disable-network \ > > > --disable-json > > > diff --git a/rules/rauc.in b/rules/rauc.in > > > index 832967b44..e43692846 100644 > > > --- a/rules/rauc.in > > > +++ b/rules/rauc.in > > > @@ -27,6 +27,16 @@ menuconfig RAUC > > > =20 > > > if RAUC > > > =20 > > > +config RAUC_CREATE > > > + bool > > > + prompt "Enable bundle creation support on target" > > > + default n > > > + help > > > + Enables support for creating bundles on target. > > > + Disabling this will remove functionality required for bundle > > > + creation which is not required on the target in most cases and th= us > > > + allows to save space. > > > + > > > config RAUC_SERVICE > > > bool > > > prompt "Enable service (D-Bus) support" > > > diff --git a/rules/rauc.make b/rules/rauc.make > > > index 820583e59..e001956a5 100644 > > > --- a/rules/rauc.make > > > +++ b/rules/rauc.make > > > @@ -41,6 +41,7 @@ RAUC_CONF_OPT :=3D \ > > > $(GLOBAL_LARGE_FILE_OPTION) \ > > > --disable-code-coverage \ > > > --disable-valgrind \ > > > + --$(call ptx/endis,PTXCONF_RAUC_CREATE)-create \ > >=20 > > Same here. This should have set explicitly to a sensible default with > > the package update. Making this optional would just change that line > > then instead of adding it. >=20 > See above. The ptxdist default for RAUC_CREATE ("n") leads to --disable-c= reate > which changes the RAUC default (which is --enable-create). I understand RAUC has some opinion what should be default. Some embedded build systems like buildroot stick with those defaults (for all options not explicitly set through menu). Others like ptxdist set all configure options. The script 'scripts/configure_helper.py' helps determining missing options not set. See example output for package host-rauc on a ptxdist 2021.06.0 based BSP: % ~/src/ptxdist/scripts/configure_helper.py -p host-rauc --- rules/host-rauc.make +++ rauc-1.5.1 @@ -1,6 +1,17 @@ --prefix=3D + --enable-debug=3Dyes/info/profile/no + --disable-largefile + --enable-compile-warnings=3Dno/yes/error + --disable-Werror --disable-code-coverage --disable-valgrind --disable-service + --disable-create --disable-network --disable-json + --enable-gpt + --with-gcov=3DGCOV + --with-systemdunitdir=3DDIR + --with-dbuspolicydir=3DDIR + --with-dbussystemservicedir=3DDIR + --with-dbusinterfacesdir=3DDIR You see --disable-create is not the only option not set in rules/host-rauc.make and I guess it might look similar for rauc.make? Pinning down the old options should go to a patch before bumping the version. Greets Alex >=20 > Regards, Enrico >=20 > > Greets > > Alex > >=20 > > > --$(call ptx/endis,PTXCONF_RAUC_SERVICE)-service \ > > > --$(call ptx/endis,PTXCONF_RAUC_NETWORK)-network \ > > > --$(call ptx/endis,PTXCONF_RAUC_STREAMING)-streaming \ > > > --=20 > > > 2.30.2 > > >=20 > > >=20 > >=20 > >=20 >=20 > --=20 > Pengutronix e.K.=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| Enrico J=C3=B6rns=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| > Embedded Linux Consulting & Support=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0| https://www.pengutronix.de/ | > Steuerwalder Str. 21=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0| Phone: +49-5121-206917-180=C2=A0=C2=A0| > 31137 Hildesheim, Germany=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| Fax:=C2=A0=C2= =A0=C2=A0+49-5121-206917-9=C2=A0=C2=A0=C2=A0=C2=A0| --=20 /"\ ASCII RIBBON | =C2=BBWith the first link, the chain is forged. The first \ / CAMPAIGN | speech censured, the first thought forbidden, the X AGAINST | first freedom denied, chains us all irrevocably.=C2=AB / \ HTML MAIL | (Jean-Luc Picard, quoting Judge Aaron Satie) --uXxzq0nDebZQVNAZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEwo7muQJjlc+Prwj6NK3NAHIhXMYFAmKqyrwACgkQNK3NAHIh XMbW9g/+JJJ2Mq/4Q3x3LXhKL85h+y5ZcWmNQm9kbygPaSYUZx5iMTc0MWbpXq87 ZBxcWXOMSt8W+2zRkvCCyUoJxsTc5Rud6mGkb4IvlPneZ56Kknar/QYLyTCCnnAy hsL5rIHi+TPGASco/y9Haiy2O/3YAnXF1dEo3NYhfvQsC5P2AvPEt5H52nP2UHs7 zrOTJLG7t5AO9Rzx08xNnAbzZF+on/K1HqWuzUP+1N/MH5Ma1KfxDUTfcVBP1qf4 X23mFlf226yFmJPsRiTSlhd6OUb+2uGpnZ7JLJtGmW5TF7pxxfc5LBM6yvj/024T tgmv5zJHtanKOw91H+Yphv/oNYWkULpOoyNhzLJp0lVG/5pxxAZfUirbPHi6PANa n6aL7W3p5zPJnu4rApIYQsFBZAuSIrVxraLqH/UGMHNS0zPcALWYRnnh4iTwZ1rs yA3JgAjNHGrEwoZybIJTi2S0a2aLfw9Gd2szqTKfRTXBJRrr72lNs+8FMzWmpCjN kLZwzIEyKAwm2js7nL8ESqokj/G4cswm2vl8JGTzFsX+oGRBcWBLNcby16QrCdoW 5hlYQHGIdQOM0FZp2tu3lAF07W4HpcEtBUEwwwQWUCiuK/gQ4DunlVQ2BLGAa2iU 1RnIH18lyGkE2u8MnICpFPvH0dcDmTCWtK+h7vYzxDi8ZEhqRg0= =mwUC -----END PGP SIGNATURE----- --uXxzq0nDebZQVNAZ--