From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 03 Jun 2022 08:24:14 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nx0jG-001Urb-Sx for lore@lore.pengutronix.de; Fri, 03 Jun 2022 08:24:14 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1nx0jF-0008Ug-T3; Fri, 03 Jun 2022 08:24:13 +0200 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nx0ie-0008UX-Pl; Fri, 03 Jun 2022 08:23:36 +0200 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nx0ie-0003WG-Ep; Fri, 03 Jun 2022 08:23:36 +0200 Date: Fri, 3 Jun 2022 08:23:36 +0200 From: Michael Olbrich To: Andreas Helmcke Message-ID: <20220603062336.GV16749@pengutronix.de> Mail-Followup-To: Andreas Helmcke , ptxdist@pengutronix.de References: <2192a0b7-00e1-1b7f-b40f-ec62ff39bf5f@ela-soft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2192a0b7-00e1-1b7f-b40f-ec62ff39bf5f@ela-soft.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 08:20:23 up 64 days, 18:50, 65 users, load average: 0.10, 0.09, 0.09 User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [ptxdist] [PATCH 2/2] lighttpd: reenable PHP support via "fast cgi" X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Mon, May 30, 2022 at 06:57:39PM +0200, Andreas Helmcke wrote: > With PHP8 at hand, the lighttpd's "fast cgi" feature can be used again. > > Signed-off-by: Juergen Borleis > Signed-off-by: Andreas Helmcke > --- > rules/lighttpd.in | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/rules/lighttpd.in b/rules/lighttpd.in > index 18827467f..ab8f41ca4 100644 > --- a/rules/lighttpd.in > +++ b/rules/lighttpd.in > @@ -17,6 +17,7 @@ menuconfig LIGHTTPD > select OPENSSL if LIGHTTPD_OPENSSL > select LUA if LIGHTTPD_LUA > select LUA_INSTALL_LIBLUA if LIGHTTPD_LUA > + select PHP8 if LIGHTTPD_MOD_FASTCGI_PHP && RUNTIME > select BUSYBOX_START_STOP_DAEMON if LIGHTTPD_STARTSCRIPT > select BUSYBOX_FEATURE_START_STOP_DAEMON_FANCY if LIGHTTPD_STARTSCRIPT > select BUSYBOX_FEATURE_START_STOP_DAEMON_LONG_OPTIONS if LIGHTTPD_STARTSCRIPT > @@ -132,12 +133,14 @@ if LIGHTTPD_MOD_FASTCGI > config LIGHTTPD_MOD_FASTCGI_PHP > bool > - depends on BROKEN > prompt "setup php handling with fastcgi" > help > Enables the necessary packages and configuration files > to enable PHP support in lighttpd add an empty line here. > +comment "PHP CGI SAPI must be enabled" > + depends on LIGHTTPD_MOD_FASTCGI_PHP && !PHP8_SAPI_CGI What happens if PHP8_SAPI_CGI is not enabled? I think it would be better to have: config LIGHTTPD_MOD_FASTCGI_PHP depends on !PHP8_SAPI_CGI [...] comment "PHP CGI SAPI must be enabled for PHP support" depends on !PHP8_SAPI_CGI This way, one of the two is visible and you cannot enable lighttpd PHP support unless PHP is configured correctly. Michael > + > endif > config LIGHTTPD_MOD_MAGNET > -- > 2.34.1 > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |