mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
* [ptxdist] [PATCH v2] gst-plugins-good1: select SYSTEMD_UDEV_PERSISTENT_V4L for systemd/v4l2 use case
@ 2022-03-24 15:51 Bastian Krause
  2022-03-30  7:25 ` [ptxdist] [APPLIED] " Michael Olbrich
  0 siblings, 1 reply; 2+ messages in thread
From: Bastian Krause @ 2022-03-24 15:51 UTC (permalink / raw)
  To: ptxdist; +Cc: Bastian Krause

Without SYSTEMD_UDEV_PERSISTENT_V4L v4l2deviceprovider (and
gst-device-monitor-1.0) will not find any v4l2 devices.

Signed-off-by: Bastian Krause <bst@pengutronix.de>
---
Changes since (implicit) v1:
- select SYSTEMD only if GST_PLUGINS_GOOD1_V4L2 is enabled
- add RUNTIME condition since these are runtime dependencies
---
 rules/gst-plugins-good1.in | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/rules/gst-plugins-good1.in b/rules/gst-plugins-good1.in
index aeac2cbc8..ab1d382ac 100644
--- a/rules/gst-plugins-good1.in
+++ b/rules/gst-plugins-good1.in
@@ -27,6 +27,8 @@ menuconfig GST_PLUGINS_GOOD1
 	select QT5_MODULE_QTDECLARATIVE	if GST_PLUGINS_GOOD1_QT5
 	select LIBSHOUT			if GST_PLUGINS_GOOD1_SHOUT2
 	select LIBSOUP			if GST_PLUGINS_GOOD1_SOUP
+	select SYSTEMD			if GST_PLUGINS_GOOD1_V4L2 && GST_PLUGINS_GOOD1_SYSTEMD && RUNTIME
+	select SYSTEMD_UDEV_PERSISTENT_V4L	if GST_PLUGINS_GOOD1_V4L2 && GST_PLUGINS_GOOD1_SYSTEMD && RUNTIME
 	select SPEEX			if GST_PLUGINS_GOOD1_SPEEX
 	select TWOLAME			if GST_PLUGINS_GOOD1_TWOLAME
 	select LIBGUDEV			if GST_PLUGINS_GOOD1_V4L2
@@ -356,6 +358,10 @@ config GST_PLUGINS_GOOD1_SPEEX
 	help
 	  Speex audio codec plugin
 
+config GST_PLUGINS_GOOD1_SYSTEMD
+	bool
+	default INITMETHOD_SYSTEMD
+
 config GST_PLUGINS_GOOD1_TAGLIB
 	bool
 	# needs libtag
-- 
2.30.2


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [ptxdist] [APPLIED] gst-plugins-good1: select SYSTEMD_UDEV_PERSISTENT_V4L for systemd/v4l2 use case
  2022-03-24 15:51 [ptxdist] [PATCH v2] gst-plugins-good1: select SYSTEMD_UDEV_PERSISTENT_V4L for systemd/v4l2 use case Bastian Krause
@ 2022-03-30  7:25 ` Michael Olbrich
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Olbrich @ 2022-03-30  7:25 UTC (permalink / raw)
  To: ptxdist; +Cc: Bastian Krause

Thanks, applied as 2f2a77e99e76a5722a66b872c05f6cb860a4cb2c.

Michael

[sent from post-receive hook]

On Wed, 30 Mar 2022 09:25:36 +0200, Bastian Krause <bst@pengutronix.de> wrote:
> Without SYSTEMD_UDEV_PERSISTENT_V4L v4l2deviceprovider (and
> gst-device-monitor-1.0) will not find any v4l2 devices.
> 
> Signed-off-by: Bastian Krause <bst@pengutronix.de>
> Message-Id: <20220324155137.4161708-1-bst@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/gst-plugins-good1.in b/rules/gst-plugins-good1.in
> index aeac2cbc85b0..ab1d382ac53d 100644
> --- a/rules/gst-plugins-good1.in
> +++ b/rules/gst-plugins-good1.in
> @@ -27,6 +27,8 @@ menuconfig GST_PLUGINS_GOOD1
>  	select QT5_MODULE_QTDECLARATIVE	if GST_PLUGINS_GOOD1_QT5
>  	select LIBSHOUT			if GST_PLUGINS_GOOD1_SHOUT2
>  	select LIBSOUP			if GST_PLUGINS_GOOD1_SOUP
> +	select SYSTEMD			if GST_PLUGINS_GOOD1_V4L2 && GST_PLUGINS_GOOD1_SYSTEMD && RUNTIME
> +	select SYSTEMD_UDEV_PERSISTENT_V4L	if GST_PLUGINS_GOOD1_V4L2 && GST_PLUGINS_GOOD1_SYSTEMD && RUNTIME
>  	select SPEEX			if GST_PLUGINS_GOOD1_SPEEX
>  	select TWOLAME			if GST_PLUGINS_GOOD1_TWOLAME
>  	select LIBGUDEV			if GST_PLUGINS_GOOD1_V4L2
> @@ -356,6 +358,10 @@ config GST_PLUGINS_GOOD1_SPEEX
>  	help
>  	  Speex audio codec plugin
>  
> +config GST_PLUGINS_GOOD1_SYSTEMD
> +	bool
> +	default INITMETHOD_SYSTEMD
> +
>  config GST_PLUGINS_GOOD1_TAGLIB
>  	bool
>  	# needs libtag

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-03-30  7:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-24 15:51 [ptxdist] [PATCH v2] gst-plugins-good1: select SYSTEMD_UDEV_PERSISTENT_V4L for systemd/v4l2 use case Bastian Krause
2022-03-30  7:25 ` [ptxdist] [APPLIED] " Michael Olbrich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox