mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 3/4] optee-client: bump to 3.16.0
Date: Fri, 25 Mar 2022 09:50:44 +0100	[thread overview]
Message-ID: <20220325085044.GQ9895@pengutronix.de> (raw)
In-Reply-To: <e831697018341c63713dfcb3603a0d08fe435674.camel@pengutronix.de>

On Fri, Mar 25, 2022 at 09:34:10AM +0100, Rouven Czerwinski wrote:
> On Fri, 2022-03-25 at 09:03 +0100, Michael Olbrich wrote:
> > On Wed, Mar 23, 2022 at 12:06:39PM +0100, Rouven Czerwinski wrote:
> > > Only a bump, no other adjustments necessary.
> > 
> > So my check scripts complain because tee-supplicant has an rpath that does
> > not exist: /usr/lib/tee-supplicant/plugins.
> > 
> > It is used to load plugins from that directory (dlopen() uses the rpath if
> > filename without path is used).
> > 
> > I'm not sure how this should be handled. Do we need plugins at all? It
> > seems optional. Add an option that should be selected by plugins?
> > Are there any security implications?
> 
> There are, since the op-tee client will load any plugins installed into
> this directory. This can be disabled with CFG_TEE_SUPP_PLUGINS=n, which
> should be added to the makefile and should remove your warning. Should
> I sent a v2 or do you want to fixup locally?

I'll fix it locally.

> > If necessary I'll just ignore this in my checks, but before I do that, I
> > want to make sure that this is actually correct.
> 
> Thanks for checking! I don't think we need plugin support at this
> point, so we should disable it as long as it stays unused.

Sounds good to me.

Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de


  reply	other threads:[~2022-03-25  8:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-23 11:06 [ptxdist] [PATCH 1/4] host-python3: add pyelftools, cryptography checks Rouven Czerwinski
2022-03-23 11:06 ` [ptxdist] [PATCH 2/4] optee: bump to 3.16.0, update deps Rouven Czerwinski
2022-03-30  7:25   ` [ptxdist] [APPLIED] " Michael Olbrich
2022-03-23 11:06 ` [ptxdist] [PATCH 3/4] optee-client: bump to 3.16.0 Rouven Czerwinski
2022-03-25  8:03   ` Michael Olbrich
2022-03-25  8:34     ` Rouven Czerwinski
2022-03-25  8:50       ` Michael Olbrich [this message]
2022-03-30  7:25   ` [ptxdist] [APPLIED] " Michael Olbrich
2022-03-23 11:06 ` [ptxdist] [PATCH 4/4] optee-test: bump to 3.16.0, move from staging Rouven Czerwinski
2022-03-30  7:25   ` [ptxdist] [APPLIED] " Michael Olbrich
2022-03-30  7:25 ` [ptxdist] [APPLIED] host-python3: add pyelftools, cryptography checks Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220325085044.GQ9895@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    --cc=r.czerwinski@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox