From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 09 Mar 2022 11:56:19 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nRtzP-005X0T-CV for lore@lore.pengutronix.de; Wed, 09 Mar 2022 11:56:19 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1nRtzO-00052n-5L; Wed, 09 Mar 2022 11:56:18 +0100 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nRtz7-00052L-P6; Wed, 09 Mar 2022 11:56:01 +0100 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nRtz7-0002XX-Fe; Wed, 09 Mar 2022 11:56:01 +0100 Date: Wed, 9 Mar 2022 11:56:01 +0100 From: Michael Olbrich To: Ahmad Fatoum Message-ID: <20220309105601.GB17921@pengutronix.de> Mail-Followup-To: Ahmad Fatoum , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , ptxdist@pengutronix.de References: <20220309104204.535553-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 11:54:44 up 88 days, 19:40, 91 users, load average: 0.07, 0.15, 0.17 User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [ptxdist] [PATCH] tf-a: Support enabling DEBUG via TF_A_EXTRA_ARGS X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de, Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Wed, Mar 09, 2022 at 11:47:23AM +0100, Ahmad Fatoum wrote: > On 09.03.22 11:42, Uwe Kleine-K=F6nig wrote: > > With DEBUG=3D1 the resulting images are located in a different folder, = so > > adapt the install target accordingly. Before this adaption the build > > either failed when DEBUG=3D1 was contained in TF_A_EXTRA_ARGS (because = no > > images were found in the release folder) or (IMHO worse) ptxdist picked > > up the build results of an earlier attempt where DEBUG > > wasn't set yet in TF_A_EXTRA_ARGS. > > = > > Also remove DEBUG=3D0 from the hardcoded set of options. This is the > > default in the tf-a Makefiles anyhow, and passing both DEBUG=3D0 and > > DEBUG=3D1 only results in confusion. > > = > > Signed-off-by: Uwe Kleine-K=F6nig > = > Acked-by: Ahmad Fatoum > = > > --- > > rules/tf-a.make | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > = > > diff --git a/rules/tf-a.make b/rules/tf-a.make > > index 25fdb0cd213a..72e1bab69371 100644 > > --- a/rules/tf-a.make > > +++ b/rules/tf-a.make > > @@ -45,7 +45,6 @@ TF_A_MAKE_OPT :=3D \ > > -C $(TF_A_DIR) \ > > CROSS_COMPILE=3D$(BOOTLOADER_CROSS_COMPILE) \ > > HOSTCC=3D$(HOSTCC) \ > > - DEBUG=3D0 \ > > ARCH=3D$(PTXCONF_TF_A_ARCH_STRING) \ > > ARM_ARCH_MAJOR=3D$(PTXCONF_TF_A_ARM_ARCH_MAJOR) \ > > BUILD_STRING=3D$(PTXCONF_TF_A_VERSION) \ > > @@ -90,7 +89,7 @@ $(STATEDIR)/tf-a.compile: > > # --------------------------------------------------------------------= -------- > > = > > tf-a/inst_plat =3D $(foreach artifact, \ > > - $(wildcard $(TF_A_BUILDDIR)/$(1)/release/$(TF_A_ARTIFACTS)), \ > > + $(wildcard $(TF_A_BUILDDIR)/$(1)/$(if $(find DEBUG=3D1,$(PTXCONF_TF_A= _EXTRA_ARGS)),debug,release)/$(TF_A_ARTIFACTS)), \ > = > Where is this $(find ...) documented? I know of $(findstring ...) It does not exists so the resulting string is always empty... Michael = > > install -v -D -m 644 $(artifact) \ > > $(2)/$(1)-$(notdir $(artifact))$(ptx/nl)) > > = > = > = > -- = > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > = > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request= @pengutronix.de -- = Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@p= engutronix.de