mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [ptxdist] [APPLIED] libva: drop obsolete GLX support
Date: Mon, 28 Feb 2022 13:09:51 +0100	[thread overview]
Message-ID: <20220228120951.2717392-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20220225163132.2929166-1-p.zabel@pengutronix.de>

Thanks, applied as b8c3f15f77cc5011b623ed1deaabba6192abd467.

Michael

[sent from post-receive hook]

On Mon, 28 Feb 2022 13:09:50 +0100, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> This was only required by gstreamer-vaapi1 < 1.16 [1]. Nothing requires
> libva GLX support now. Removing it and with it the MESALIB dependencies
> allows to enable VA support in Mesa without circular dependencies.
> 
> [1] 5384deb0679e ("gstreamer-vaapi1: fix dependency")
> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> Message-Id: <20220225163132.2929166-1-p.zabel@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/libva.in b/rules/libva.in
> index 8dd2229030fe..b0ba96e5c698 100644
> --- a/rules/libva.in
> +++ b/rules/libva.in
> @@ -4,12 +4,9 @@ menuconfig LIBVA
>  	tristate
>  	select HOST_MESON
>  	select LIBDRM
> -	select XORG_LIB_X11		if LIBVA_X11 || LIBVA_GLX
> +	select XORG_LIB_X11		if LIBVA_X11
>  	select XORG_LIB_XEXT		if LIBVA_X11
>  	select XORG_LIB_XFIXES		if LIBVA_X11
> -	select MESALIB			if LIBVA_GLX
> -	select MESALIB_GLX		if LIBVA_GLX
> -	select MESALIB_OPENGL		if LIBVA_GLX
>  	select WAYLAND			if LIBVA_WAYLAND
>  	prompt "libva                         "
>  	help
> @@ -21,11 +18,6 @@ config LIBVA_X11
>  	bool
>  	prompt "X11 API support"
>  
> -config LIBVA_GLX
> -	bool
> -	select LIBVA_X11
> -	prompt "GLX API support"
> -
>  config LIBVA_WAYLAND
>  	bool
>  	prompt "Wayland API support"
> diff --git a/rules/libva.make b/rules/libva.make
> index 7649bbb0ba97..7a16a188d820 100644
> --- a/rules/libva.make
> +++ b/rules/libva.make
> @@ -31,7 +31,6 @@ LIBVA_LICENSE_FILES := \
>  
>  LIBVA_ENABLE-y				:= drm
>  LIBVA_ENABLE-$(PTXCONF_LIBVA_X11)	+= x11
> -LIBVA_ENABLE-$(PTXCONF_LIBVA_GLX)	+= glx
>  LIBVA_ENABLE-$(PTXCONF_LIBVA_WAYLAND)	+= wayland
>  
>  LIBVA_CONF_TOOL	:= meson
> @@ -41,7 +40,7 @@ LIBVA_CONF_OPT	:= \
>  	-Ddriverdir='' \
>  	-Denable_docs=false \
>  	-Denable_va_messaging=true \
> -	-Dwith_glx=$(call ptx/yesno, PTXCONF_LIBVA_GLX) \
> +	-Dwith_glx=no \
>  	-Dwith_wayland=$(call ptx/yesno, PTXCONF_LIBVA_WAYLAND) \
>  	-Dwith_x11=$(call ptx/yesno, PTXCONF_LIBVA_X11)
>  

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de


      parent reply	other threads:[~2022-02-28 12:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-25 16:31 [ptxdist] [PATCH 1/2] " Philipp Zabel
2022-02-25 16:31 ` [ptxdist] [PATCH 2/2] mesalib: enable VA support Philipp Zabel
2022-02-28  7:01   ` Michael Olbrich
2022-02-28 12:09 ` Michael Olbrich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220228120951.2717392-1-m.olbrich@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=p.zabel@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox