From: Michael Olbrich <m.olbrich@pengutronix.de>
To: Felix Mellmann <flix.ptxdist@benfm.de>
Cc: ptxdist@pengutronix.de, rich_ogrady@grayhill.com
Subject: Re: [ptxdist] ptxdist-2022.01.1 commit 2fafa7c4308db8d1e79dc3b5d2c9cb3400a16ff8
Date: Fri, 11 Feb 2022 08:21:43 +0100 [thread overview]
Message-ID: <20220211072143.GA1873@pengutronix.de> (raw)
In-Reply-To: <71d6ac45-ef44-327d-c65f-7c1a507fc22d@benfm.de>
Hi,
On Thu, Feb 10, 2022 at 05:49:19PM +0100, Felix Mellmann wrote:
> On 10.02.22 15:28, rich_ogrady@grayhill.com wrote:
> > It seems that the subject commit breaks ptxd_make_dtb()(for me at least).
> >
> > ptxd_make_dtb()is using the variable dtb_kernel_dir to locate both the
> > dtc script and the dts files.
> > The dtc command needs to be from the build tree yet the dts files will
> > be from the src tree. If building the kernel OOT this causes the dtc
> > command to not be found.
> Ah, thats the reason. I was also wondering why I ran into strange errors. At
> the moment I manually build host-dtc before targetinstall kernel.
And I have a dtc in $PATH so I never noticed that this was broken :-/.
Sorry about that.
> Maybe one could add host-dtc to the dependencies when building the device
> trees along with the kernel?
You can do that for now, but the real fix is to use the correct path.
The dtc is in the kernel build tree not the source tree...
Michael
> > The patch that fixes it for me is below but I cant tell if that breaks
> > the original intent.
> >
> > --- a/scripts/lib/ptxd_make_world_dtb.sh
> > +++ b/scripts/lib/ptxd_make_world_dtb.sh
> > @@ -14,7 +14,7 @@
> >
> > dtb_kernel_dir="${pkg_kernel_src:-${pkg_dir}}"
> >
> > - dtc="${dtb_kernel_dir}/scripts/dtc/dtc"
> > + dtc="${pkg_build_dir}/scripts/dtc/dtc"
> > if [ ! -x "${dtc}" ]; then
> > dtc=dtc
> > fi
> >
> > Rich OGrady
> >
> > _______________________________________________
> > ptxdist mailing list
> > ptxdist@pengutronix.de
> > To unsubscribe, send a mail with subject "unsubscribe" toptxdist-request@pengutronix.de
> Best regards,
>
> Felix
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
next parent reply other threads:[~2022-02-11 7:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <OF0FB74C20.BA6A5443-ON862587E5.004F768C-862587E5.004F8280@grayhill.com>
[not found] ` <71d6ac45-ef44-327d-c65f-7c1a507fc22d@benfm.de>
2022-02-11 7:21 ` Michael Olbrich [this message]
2022-02-11 7:23 ` [ptxdist] [PATCH] ptxd_make_dtb: fix dtc selection Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220211072143.GA1873@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=flix.ptxdist@benfm.de \
--cc=ptxdist@pengutronix.de \
--cc=rich_ogrady@grayhill.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox