From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 07 Feb 2022 11:39:26 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nH1Qc-008B48-Ey for lore@lore.pengutronix.de; Mon, 07 Feb 2022 11:39:26 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1nH1Qb-0002BZ-RS; Mon, 07 Feb 2022 11:39:25 +0100 Received: from mout.kundenserver.de ([212.227.126.131]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nH1QR-0002BQ-5l for ptxdist@pengutronix.de; Mon, 07 Feb 2022 11:39:15 +0100 Received: from methusalix.internal.home.lespocky.de ([92.117.40.133]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MDQRy-1nRQlI1Ryw-00AUCS for ; Mon, 07 Feb 2022 11:39:14 +0100 Received: from falbala.internal.home.lespocky.de ([192.168.243.94]) by methusalix.internal.home.lespocky.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nH1QN-00061M-AK for ptxdist@pengutronix.de; Mon, 07 Feb 2022 11:39:13 +0100 Date: Mon, 7 Feb 2022 11:39:10 +0100 From: Alexander Dahl To: ptxdist@pengutronix.de Message-ID: <20220207103909.GB538@falbala.internal.home.lespocky.de> Mail-Followup-To: ptxdist@pengutronix.de References: <20220204162809.830058-1-clemens.gruber@pqgruber.com> <20220207073936.GQ11273@pengutronix.de> MIME-Version: 1.0 In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-Scan-Signature: 8f70d5a829509043eb0f2416cc2ab15d X-Provags-ID: V03:K1:t4LIPCXD+MdFuwKTZyjY70vU4PYCj+P8PwWNR41dTBMXE3YcDiG 5WoBPZ4D0ZGeoy0fMEnn/WS/VqCI16aDbtBt5teDoCwjpWyu6J/q5JwfvkS5chG/oNWJV/B CJqea6NpQadO8+0KsisR7EURl8KJB1+V+/5YsIc7s1ASKP6N11QNdoSXhmhHxu4/eTEnRqe cCw5bYd1mboQ79RfNVNfg== X-UI-Out-Filterresults: notjunk:1;V03:K0:VdTcT6bJycI=:jz5X25637szjO2Gy8Uw/S0 CtEGGFw2Kp1E3TSjNsnWqwt7cCt2DdviFnjlwI5yjQjQfZth5L99pBK/7QfXLMStcR126dJ3e 1WjjvHHIcGywL65WyZdQFLt7zD1khrS4BWiu8Fq6kGkN83B4FvYIKrCjoo7zVAIvXZhZYenj5 +PFPn0PEvdeM1YyU0qj0jALX+QCfmXjHOBg4rCni9unVnMSv2uxMFB8PfgFo3eJVXpROZ/PVm dxsymZBisnUL9Z/yTVuOf/fsNM64BLEOHdp7bjYY38IIJvsAxtUfoagAanVqaMZG5Kck5ZG/v Y8pI1p1Ppt6+GYzow5J/R/SoNGPIq98qQgxvY54781BJ5ccmoIsUlPjQQh9yCZ8gLDbMdZk4k cnv0OuuKVUW+L4QDGgCUU/TscJRP/H6YFIdhTnr+9CQ1D8OEI74fheF7o2WfJ94o5YxffUKW8 mh7YAzxj5IiUmzNKqNruAIFpSEPa7yRerjvJdgNeU8O6jRk0Oxaw0aLQpeTfl5jYUfKKBArDs 6VLQTe/4V653uKW446i4EfVOPOWhBGLfTXddvrshJohdP+B5gvWqtArbp3jIm2AJIqK2B+Dnc Ys3IptK3sQ97dgym7MbRjv8nD4Eg64AnMoTkRRppi4DyWDVH9PeNbyXhNcIVw8HErzns/drfU V+FZoHIru8d+YCRNXULF5aa6yfPZU9T50erxRxXvf6BgJ4BhfqFgGG1BfhUhYLoc5B/c= X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.3 required=4.0 tests=AWL,BAYES_00, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH 1/3] hiredis: new package X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: multipart/mixed; boundary="===============0489218026==" Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false --===============0489218026== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PmA2V3Z32TCmWXqI" Content-Disposition: inline --PmA2V3Z32TCmWXqI Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hei hei, On Mon, Feb 07, 2022 at 10:03:21AM +0100, Clemens Gruber wrote: > On Mon, Feb 07, 2022 at 08:39:36AM +0100, Michael Olbrich wrote: > > On Fri, Feb 04, 2022 at 05:28:07PM +0100, Clemens Gruber wrote: > > > Adds a new package for hiredis, a minimalistic C client library for > > > Redis. > > >=20 > > > Signed-off-by: Clemens Gruber > > > --- > > > rules/hiredis.in | 8 ++++++ > > > rules/hiredis.make | 61 ++++++++++++++++++++++++++++++++++++++++++++= ++ > > > 2 files changed, 69 insertions(+) > > > create mode 100644 rules/hiredis.in > > > create mode 100644 rules/hiredis.make > > >=20 > > > diff --git a/rules/hiredis.in b/rules/hiredis.in > > > new file mode 100644 > > > index 000000000..d416d69c4 > > > --- /dev/null > > > +++ b/rules/hiredis.in > > > @@ -0,0 +1,8 @@ > > > +## SECTION=3Dsystem_libraries > > > + > > > +config HIREDIS > > > + tristate > > > + select HOST_CMAKE > > > + prompt "hiredis " > > > + help > > > + Hiredis is a minimalistic C client library for the Redis database. > > > diff --git a/rules/hiredis.make b/rules/hiredis.make > > > new file mode 100644 > > > index 000000000..10e6d81d2 > > > --- /dev/null > > > +++ b/rules/hiredis.make > > > @@ -0,0 +1,61 @@ > > > +# -*-makefile-*- > > > +# > > > +# Copyright (C) 2022 by Clemens Gruber > > > +# > > > +# For further information about the PTXdist project and license cond= itions > > > +# see the README file. > > > +# > > > + > > > +# > > > +# We provide this package > > > +# > > > +PACKAGES-$(PTXCONF_HIREDIS) +=3D hiredis > > > + > > > +# > > > +# Paths and names > > > +# > > > +HIREDIS_VERSION :=3D 1.0.2 > > > +HIREDIS_MD5 :=3D 58e8313188f66ed1be1c220d14a7752e > > > +HIREDIS :=3D hiredis-$(HIREDIS_VERSION) > > > +HIREDIS_SUFFIX :=3D tar.gz > > > +HIREDIS_URL :=3D https://github.com/redis/hiredis/archive/v$(HIREDIS= _VERSION).$(HIREDIS_SUFFIX) > > > +HIREDIS_SOURCE :=3D $(SRCDIR)/$(HIREDIS).$(HIREDIS_SUFFIX) > > > +HIREDIS_DIR :=3D $(BUILDDIR)/$(HIREDIS) > > > +HIREDIS_LICENSE :=3D BSD-3-Clause > >=20 > > Please add _LICENSE_FILES as well. > >=20 > > > + > > > +# ------------------------------------------------------------------= ---------- > > > +# Prepare > > > +# ------------------------------------------------------------------= ---------- > > > + > > > +# > > > +# cmake > > > +# > > > +HIREDIS_CONF_TOOL :=3D cmake > > > + > > > +HIREDIS_CONF_OPT :=3D \ > > > + $(CROSS_CMAKE_USR) \ > > > + -DDISABLE_TESTS=3DON \ > > > + -DENABLE_SSL=3DOFF > > > + > > > + > > > +# ------------------------------------------------------------------= ---------- > > > +# Target-Install > > > +# ------------------------------------------------------------------= ---------- > > > + > > > +$(STATEDIR)/hiredis.targetinstall: > > > + @$(call targetinfo) > > > + > > > + @$(call install_init, hiredis) > > > + @$(call install_fixup, hiredis,PRIORITY,optional) > > > + @$(call install_fixup, hiredis,SECTION,base) > > > + @$(call install_fixup, hiredis,AUTHOR,"Clemens Gruber ") > > > + @$(call install_fixup, hiredis,DESCRIPTION,"Minimalistic C client f= or Redis") > > > + > > > + @$(call install_lib, hiredis, 0, 0, 0644, libhiredis) > > > + @$(call install_link, hiredis, libhiredis.so.1.0.0, /usr/lib/libhir= edis.so) > >=20 > > In general, this link should not be needed. If it really is needed then > > please add a comment why. >=20 > Maybe you can help me out here: If I don't call install_link, the > libhiredis.so link is not present in my rootfs image, even though it is > present in platform-xyz/packages/hiredis-1.0.2/usr/lib and in > platform-xyz/root/usr/lib I would expect this. Usually you have three pieces: libfoo.so.1.0.0 (real binary file) libfoo.so.1 (symlink to libfoo.so.1.0.0, used at runtime by users of the li= b) libfoo.so (symlink, used at build time) > Still in my rootfs image, there is only /usr/lib/libhiredis.so.1.0.0 > It is a normal root.ext2 image with ext2fs type ext4. >=20 > Any idea why that is? No idea why that is, but without further knowledge of that lib I would expect to see libhiredis.so.1 on the target instead of libhiredis.so (which is probably only needed in sysroot-target). Greets Alex --=20 /"\ ASCII RIBBON | =BBWith the first link, the chain is forged. The first \ / CAMPAIGN | speech censured, the first thought forbidden, the X AGAINST | first freedom denied, chains us all irrevocably.=AB / \ HTML MAIL | (Jean-Luc Picard, quoting Judge Aaron Satie) --PmA2V3Z32TCmWXqI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEwo7muQJjlc+Prwj6NK3NAHIhXMYFAmIA9soACgkQNK3NAHIh XMYqxA//SuO5YS2HWfxv+P1dot9SDfy6KQnRvaYDlwGlZTWc1HKcMqKh3bv+fKAT Ywwy9ATm+IBD/16kovtU7bH7fkzGvZh8Scf62Thk89/MUlBPJWPXZAq3OmXq8GHG 8+DAup2/fnY0ybpPlFRFujMWJLrNfetvsT2UIh9JnS+CZXnmRsrjtJ7w51eCGhFV GO8tmAKqbBwJiHmaMB0dAGzYsTmP+lW9mbzYPoTS6+YWXkJ9M1WF/8RPb1WP+Fl/ 2rhooxL0kaFFjnGfyCSRw+rDSxq9Yaxa0rN1S3jR9NvucYYLjRbdx5JWMi23l5SR T1rn96LS9U2u4taMCdq0pFJXBp1axKGBPTz/r8fxreFOpp94H14cwUhMh477OSFI ogbM/bED16TA1lOyMliwMuVJyfYfLekpEGyKWmQQnGD3YIIP5lX27hQEmR6LJh9L aWj/V75Tp4NB9t47zqhpKDlIIdUJk8zvbQmUN8ixSagkp1q11CJjRcCBmfYlNabr 4KA5Aa5Xr3rp1PLUcL5XZQHe/wQiHfurN16BN0CtJ6IzhUmQhAL5SKFoi2T9/Yjy aqvvGoE7Zd3lelkk6mNORI4RH0EvSK12LxAg3cezEDjnCboR1LohLoICg15RCUni DxOMQF3Ji2yRgsG2GeSf7rJLdpbumdon4dlkEqL3WqGSI6G4CgU= =i1fI -----END PGP SIGNATURE----- --PmA2V3Z32TCmWXqI-- --===============0489218026== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de --===============0489218026==--