From: Alexander Dahl <post@lespocky.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 1/3] hiredis: new package
Date: Mon, 7 Feb 2022 11:39:10 +0100 [thread overview]
Message-ID: <20220207103909.GB538@falbala.internal.home.lespocky.de> (raw)
In-Reply-To: <YgDgWcZD6dQDMb+F@workstation>
[-- Attachment #1.1: Type: text/plain, Size: 4608 bytes --]
Hei hei,
On Mon, Feb 07, 2022 at 10:03:21AM +0100, Clemens Gruber wrote:
> On Mon, Feb 07, 2022 at 08:39:36AM +0100, Michael Olbrich wrote:
> > On Fri, Feb 04, 2022 at 05:28:07PM +0100, Clemens Gruber wrote:
> > > Adds a new package for hiredis, a minimalistic C client library for
> > > Redis.
> > >
> > > Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>
> > > ---
> > > rules/hiredis.in | 8 ++++++
> > > rules/hiredis.make | 61 ++++++++++++++++++++++++++++++++++++++++++++++
> > > 2 files changed, 69 insertions(+)
> > > create mode 100644 rules/hiredis.in
> > > create mode 100644 rules/hiredis.make
> > >
> > > diff --git a/rules/hiredis.in b/rules/hiredis.in
> > > new file mode 100644
> > > index 000000000..d416d69c4
> > > --- /dev/null
> > > +++ b/rules/hiredis.in
> > > @@ -0,0 +1,8 @@
> > > +## SECTION=system_libraries
> > > +
> > > +config HIREDIS
> > > + tristate
> > > + select HOST_CMAKE
> > > + prompt "hiredis "
> > > + help
> > > + Hiredis is a minimalistic C client library for the Redis database.
> > > diff --git a/rules/hiredis.make b/rules/hiredis.make
> > > new file mode 100644
> > > index 000000000..10e6d81d2
> > > --- /dev/null
> > > +++ b/rules/hiredis.make
> > > @@ -0,0 +1,61 @@
> > > +# -*-makefile-*-
> > > +#
> > > +# Copyright (C) 2022 by Clemens Gruber <clemens.gruber@pqgruber.com>
> > > +#
> > > +# For further information about the PTXdist project and license conditions
> > > +# see the README file.
> > > +#
> > > +
> > > +#
> > > +# We provide this package
> > > +#
> > > +PACKAGES-$(PTXCONF_HIREDIS) += hiredis
> > > +
> > > +#
> > > +# Paths and names
> > > +#
> > > +HIREDIS_VERSION := 1.0.2
> > > +HIREDIS_MD5 := 58e8313188f66ed1be1c220d14a7752e
> > > +HIREDIS := hiredis-$(HIREDIS_VERSION)
> > > +HIREDIS_SUFFIX := tar.gz
> > > +HIREDIS_URL := https://github.com/redis/hiredis/archive/v$(HIREDIS_VERSION).$(HIREDIS_SUFFIX)
> > > +HIREDIS_SOURCE := $(SRCDIR)/$(HIREDIS).$(HIREDIS_SUFFIX)
> > > +HIREDIS_DIR := $(BUILDDIR)/$(HIREDIS)
> > > +HIREDIS_LICENSE := BSD-3-Clause
> >
> > Please add _LICENSE_FILES as well.
> >
> > > +
> > > +# ----------------------------------------------------------------------------
> > > +# Prepare
> > > +# ----------------------------------------------------------------------------
> > > +
> > > +#
> > > +# cmake
> > > +#
> > > +HIREDIS_CONF_TOOL := cmake
> > > +
> > > +HIREDIS_CONF_OPT := \
> > > + $(CROSS_CMAKE_USR) \
> > > + -DDISABLE_TESTS=ON \
> > > + -DENABLE_SSL=OFF
> > > +
> > > +
> > > +# ----------------------------------------------------------------------------
> > > +# Target-Install
> > > +# ----------------------------------------------------------------------------
> > > +
> > > +$(STATEDIR)/hiredis.targetinstall:
> > > + @$(call targetinfo)
> > > +
> > > + @$(call install_init, hiredis)
> > > + @$(call install_fixup, hiredis,PRIORITY,optional)
> > > + @$(call install_fixup, hiredis,SECTION,base)
> > > + @$(call install_fixup, hiredis,AUTHOR,"Clemens Gruber <clemens.gruber@pqgruber.com>")
> > > + @$(call install_fixup, hiredis,DESCRIPTION,"Minimalistic C client for Redis")
> > > +
> > > + @$(call install_lib, hiredis, 0, 0, 0644, libhiredis)
> > > + @$(call install_link, hiredis, libhiredis.so.1.0.0, /usr/lib/libhiredis.so)
> >
> > In general, this link should not be needed. If it really is needed then
> > please add a comment why.
>
> Maybe you can help me out here: If I don't call install_link, the
> libhiredis.so link is not present in my rootfs image, even though it is
> present in platform-xyz/packages/hiredis-1.0.2/usr/lib and in
> platform-xyz/root/usr/lib
I would expect this. Usually you have three pieces:
libfoo.so.1.0.0 (real binary file)
libfoo.so.1 (symlink to libfoo.so.1.0.0, used at runtime by users of the lib)
libfoo.so (symlink, used at build time)
> Still in my rootfs image, there is only /usr/lib/libhiredis.so.1.0.0
> It is a normal root.ext2 image with ext2fs type ext4.
>
> Any idea why that is?
No idea why that is, but without further knowledge of that lib I would
expect to see libhiredis.so.1 on the target instead of libhiredis.so
(which is probably only needed in sysroot-target).
Greets
Alex
--
/"\ ASCII RIBBON | »With the first link, the chain is forged. The first
\ / CAMPAIGN | speech censured, the first thought forbidden, the
X AGAINST | first freedom denied, chains us all irrevocably.«
/ \ HTML MAIL | (Jean-Luc Picard, quoting Judge Aaron Satie)
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 181 bytes --]
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
next prev parent reply other threads:[~2022-02-07 10:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 16:28 Clemens Gruber
2022-02-04 16:28 ` [ptxdist] [PATCH 2/3] systemd: add option for openssl support Clemens Gruber
2022-02-14 12:43 ` [ptxdist] [APPLIED] " Michael Olbrich
2022-02-04 16:28 ` [ptxdist] [PATCH 3/3] protobuf: version bump 3.7.1 -> 3.19.4 Clemens Gruber
2022-02-11 9:43 ` Michael Olbrich
2022-02-11 14:30 ` Clemens Gruber
2022-02-07 7:39 ` [ptxdist] [PATCH 1/3] hiredis: new package Michael Olbrich
2022-02-07 9:03 ` Clemens Gruber
2022-02-07 10:39 ` Alexander Dahl [this message]
2022-02-07 12:54 ` Clemens Gruber
2022-02-07 13:11 ` Alexander Dahl
2022-02-07 13:33 ` Clemens Gruber
2022-02-07 15:22 ` Michael Olbrich
2022-02-07 15:25 ` Michael Olbrich
2022-02-07 15:51 ` Clemens Gruber
2022-02-07 16:30 ` Alexander Dahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220207103909.GB538@falbala.internal.home.lespocky.de \
--to=post@lespocky.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox