From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Sat, 29 Jan 2022 16:37:15 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nDpmt-00HKLI-4J for lore@lore.pengutronix.de; Sat, 29 Jan 2022 16:37:15 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1nDpms-0001iT-8a; Sat, 29 Jan 2022 16:37:14 +0100 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nDpm9-0001iJ-Hn; Sat, 29 Jan 2022 16:36:29 +0100 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nDpm8-0003ij-Gq; Sat, 29 Jan 2022 16:36:28 +0100 Date: Sat, 29 Jan 2022 16:36:28 +0100 From: Michael Olbrich To: Christian Melki Message-ID: <20220129153628.GG11273@pengutronix.de> Mail-Followup-To: Christian Melki , "ptxdist@pengutronix.de" References: <20220127143532.2212796-1-christian.melki@t2data.com> <20220127143532.2212796-11-christian.melki@t2data.com> <20220128183236.GE11273@pengutronix.de> <36c721f5-a9cc-d55c-cde3-1fa9a0568053@t2data.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <36c721f5-a9cc-d55c-cde3-1fa9a0568053@t2data.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 16:35:16 up 50 days, 20 min, 59 users, load average: 0.25, 0.14, 0.10 User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [ptxdist] [PATCH] tpm2-tss: Version bump. 2.3.1 -> 3.1.0 X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: "ptxdist@pengutronix.de" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Sat, Jan 29, 2022 at 09:29:43AM +0100, Christian Melki wrote: > On 1/28/22 19:32, Michael Olbrich wrote: > > On Fri, Jan 28, 2022 at 06:22:19PM +0100, Christian Melki wrote: > >> On 1/28/22 17:16, Michael Olbrich wrote: > >>> On Thu, Jan 27, 2022 at 03:35:30PM +0100, Christian Melki wrote: > >>>> Approx. 2,5 year worth of fixes. > >>>> https://github.com/tpm2-software/tpm2-tss/releases > >>>> Fixes CVE-2020-24455 (three times over). > >>>> tpm2-tss now depends on JSON_C and LIBCURL. > >>>> Remove changed configuration options. > >>> > >>> Fails to build here: > >>> > >>> checking for groupadd... no > >>> configure: error: Missing required program 'groupadd': ensure it is installed and on PATH. > >>> > >>> Adding a group should not be done during install anyways and it would fail, > >>> so I think this should work: > >>> > >>> TPM2_TSS_CONF_ENV := \ > >>> $(CROSS_ENV) \ > >>> GROUPADD=: \ > >>> USERADD=: > >>> > >>> Michael > >>> > >> > >> Didn't see that one coming. How abusive! > >> From a makefile none the less. > >> I have the required binaries on my development machine so I didn't notice. > >> Now, I've tried your suggestion, but I can't see that it helps? > >> > >> Looks like the entire thing goes about the binaries in a very static > >> fashion. > >> > >> .. > >> define make_tss_user_and_group > >> (id -g tss 2>/dev/null || groupadd -r tss) && \ > >> (id -u tss 2>/dev/null || useradd -r -g tss tss) > >> endef > > > > @$(call make_tss_user_and_group) || echo "WARNING Failed to create the tss user and group" > > > > so any error here is ignored. We just need to get through the configure > > check. > > > > ack. > > TPM2_TSS_CONF_ENV := \ > $(CROSS_ENV) \ > ac_cv_prog_result_groupadd=yes \ > ac_cv_prog_result_useradd=yes > > should work for getting through configure? I think so. You should see a "(cached)" in the configure output for those checks. Michael -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de