Re: [ptxdist] [PATCH v5 2/5] add package for rockchip firmware binaries

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Fri, Jan 28, 2022 at 01:46:25PM +0100, Michael Riesch wrote:
> On 1/28/22 13:31, Michael Olbrich wrote:
> > On Mon, Jan 24, 2022 at 01:09:39PM +0100, Michael Riesch wrote:
> >> Rockchip provides the SDRAM initialization as well as BL31/BL32
> >> firmware for their SoCs in binary form. Add a package that downloads
> >> those binaries for further use in e.g., barebox.
> >>
> >> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> >> [revised and extended Kconfig]
> >> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
> >> ---
> >>  platforms/firmware-rockchip.in | 41 +++++++++++++++++++
> >>  rules/firmware-rockchip.make   | 74 ++++++++++++++++++++++++++++++++++
> >>  2 files changed, 115 insertions(+)
> >>  create mode 100644 platforms/firmware-rockchip.in
> >>  create mode 100644 rules/firmware-rockchip.make
> >>
> >> diff --git a/platforms/firmware-rockchip.in b/platforms/firmware-rockchip.in
> >> new file mode 100644
> >> index 000000000..aa702416d
> >> --- /dev/null
> >> +++ b/platforms/firmware-rockchip.in
> >> @@ -0,0 +1,41 @@
> >> +## SECTION=non_free_firmware
> >> +
> >> +menuconfig FIRMWARE_ROCKCHIP
> >> +	bool
> >> +	prompt "Rockchip firmware binaries    "
> >> +	help
> >> +	  Rockchip prebuilt SDRAM initialization and TF-A binaries.
> >> +
> >> +if FIRMWARE_ROCKCHIP
> >> +
> >> +config FIRMWARE_ROCKCHIP_RK3566_SDRAM
> > 
> > I still don't like the sub-options here. But I'm still thinking about
> > whether this part should go into PTXdist itself, so no need to touch this
> > for now.
> 
> Care to give us some insight in your current state of reasoning as to
> whether or not this should enter ptxdist?

It's still somewhat unclear to me, but it seems that all of these files are
only useful for one specific board. I'm reluctant to add it just for that.

But it could also serve as an example for this whole infrastructure...

Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de