From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Bastian Krause <bst@pengutronix.de>
Subject: Re: [ptxdist] [APPLIED] vim: fix xxd install location
Date: Fri, 21 Jan 2022 15:24:25 +0100 [thread overview]
Message-ID: <20220121142425.2136665-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20220119155544.3364301-1-bst@pengutronix.de>
Thanks, applied as d67b82df99ffce2a36870a3805af2d4873a63aed.
Michael
[sent from post-receive hook]
On Fri, 21 Jan 2022 15:24:24 +0100, Bastian Krause <bst@pengutronix.de> wrote:
> Installing xxd to /usr/bin/vim is obviously wrong. In case
> PTXCONF_VIM_VIM and PTXCONF_VIM_XXD are enabled, vim is even
> overwritten. Fix that by installing xxd to /usr/bin/xxd.
>
> Fixes: c538cff7e ("vim: add install options")
> Signed-off-by: Bastian Krause <bst@pengutronix.de>
> Message-Id: <20220119155544.3364301-1-bst@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
>
> diff --git a/rules/vim.make b/rules/vim.make
> index 6965e25370f5..a21b92f590bf 100644
> --- a/rules/vim.make
> +++ b/rules/vim.make
> @@ -118,7 +118,7 @@ ifdef PTXCONF_VIM_VIM
> endif
>
> ifdef PTXCONF_VIM_XXD
> - @$(call install_copy, vim, 0, 0, 0755, $(VIM_DIR)/$(VIM_SUBDIR)/xxd/xxd, /usr/bin/vim)
> + @$(call install_copy, vim, 0, 0, 0755, $(VIM_DIR)/$(VIM_SUBDIR)/xxd/xxd, /usr/bin/xxd)
> endif
> @$(call install_finish, vim)
>
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
prev parent reply other threads:[~2022-01-21 14:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 15:55 [ptxdist] [PATCH] " Bastian Krause
2022-01-21 14:24 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220121142425.2136665-1-m.olbrich@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=bst@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox