From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Sat, 11 Dec 2021 16:59:36 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mw4me-003L1p-Po for lore@lore.pengutronix.de; Sat, 11 Dec 2021 16:59:36 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mw4md-0002co-Mh; Sat, 11 Dec 2021 16:59:35 +0100 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mw4lx-0002ce-7V; Sat, 11 Dec 2021 16:58:53 +0100 Received: from rhi by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1mw4lw-0004D4-61; Sat, 11 Dec 2021 16:58:52 +0100 Date: Sat, 11 Dec 2021 16:58:52 +0100 From: Roland Hieber To: Alexander Dahl Message-ID: <20211211155852.vvtfmsft7xrdc2tx@pengutronix.de> References: <20211205221106.240253-1-rhi@pengutronix.de> <3608335.H6dVxhGl9V@ada> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3608335.H6dVxhGl9V@ada> User-Agent: NeoMutt/20180716 Subject: Re: [ptxdist] [PATCH 1/2] dropbear: license review X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Fri, Dec 10, 2021 at 09:48:06AM +0100, Alexander Dahl wrote: > Hello Roland, > > Am Sonntag, 5. Dezember 2021, 23:11:05 CET schrieb Roland Hieber: > > Commit 80326bc43e7 (2020-11-16, Alexander Dahl: "dropbear: version bump > > 2019.78 -> 2020.79") mentioned: > > > > The curve25519 implementation was replaced with the one by TweetNaCl, > > which induced a change in 'LICENSE' summary. The old implementation was > > licensed BSD-3-Clause and the new is public domain. > > > > This was wrong; even though curve25519.c is based on the public domain > > TweetNaCl library, as mentioned in LICENSE, it carries a BSD-2-Clause > > license header like most other files. Therefore remove the first > > public_domain sub-expression. > > That header is actual MIT license. See the spdx-license-match tool or for > reference: > > https://metadata.ftp-master.debian.org/changelogs//main/d/dropbear/ > dropbear_2020.81-3_copyright > > This does not affect the diff of your patch, but the commit message would not > be correct. Oh indded, you're right. Michael, can you do an :s/it carries a BSD-2-Clause/it carries an MIT/ when applying the patch? - Roland > > With that changed: > > Acked-by: Alexander Dahl > > > The second public_domain sub-expression referred to the libtomcrypt > > license, which is licensed as, alternatively, WTFPL, or "LibTomCrypt is > > public domain. As should all quality software be.". Classify it as a > > custom license, as we deprecated the public_domain license identifier in > > commit 76d1f680233955839298 (2021-08-06, Roland Hieber: "doc: working > > with licensing information in packages"). > > > > Fixes: 80326bc43e71d1b012b3 ("dropbear: version bump 2019.78 -> 2020.79") > > Cc: Alexander Dahl > > Signed-off-by: Roland Hieber > > Ack. > > Greets > Alex > > > --- > > rules/dropbear.make | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/rules/dropbear.make b/rules/dropbear.make > > index 102825ed6ab4..678bd7d85778 100644 > > --- a/rules/dropbear.make > > +++ b/rules/dropbear.make > > @@ -24,7 +24,7 @@ DROPBEAR_URL := > > http://matt.ucc.asn.au/dropbear/releases/$(DROPBEAR).$(DROPBEAR > > DROPBEAR_SOURCE := $(SRCDIR)/$(DROPBEAR).$(DROPBEAR_SUFFIX) > > DROPBEAR_DIR := $(BUILDDIR)/$(DROPBEAR) > > DROPBEAR_LICENSE := \ > > - MIT AND BSD-2-Clause AND public_domain AND SSH-short AND (public_domain OR > > WTFPL) AND Unlicense + MIT AND BSD-2-Clause AND SSH-short AND (custom OR > > WTFPL) AND Unlicense DROPBEAR_LICENSE_FILES := \ > > file://LICENSE;md5=25cf44512b7bc8966a48b6b1a9b7605f \ > > file://libtomcrypt/LICENSE;md5=71baacc459522324ef3e2b9e052e8180 \ > > > -- > > > > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de > -- Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de