Re: [ptxdist] ptxdist make license-report failing

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Wed, Dec 08, 2021 at 09:20:38PM -0500, Jon Ringle wrote:
> On Wed, Dec 8, 2021 at 8:11 PM Michael Olbrich <m.olbrich@pengutronix.de>
> wrote:
> > On Tue, Nov 30, 2021 at 09:18:25AM +0100, Nicholai Juul Hansen wrote:
> > > The license report scripts are not able to handle packages with #md5= in
> > > the URL, which is not uncommon in the python packages.
> >
> > As far as I can tell, the #md5=... part of the URL is optional. At least it
> > was for the URLs I came across in the past.
> >
> > > I have not been able to find a "nice" place to add a fix that I could
> > > submit to the developers,
> > > but you should be able to work around this issue by running a command
> > > combining grep and sed/awk in the report directory.
> > >
> > > You can check if this is the issue by running 'grep -r "#md5=" ./' in the
> > > report folder and check if you have any packages with #md5= that is not
> > > escaped with \
> >
> > We already escape other stuff in ptxd_make_latex_escape() in
> > scripts/lib/ptxd_make_world_license.sh, so that should be fixable.
> >
> >
> I didn't have any hits grep'ing for "#md5=", but I did get some hits just
> grep'ing for "#":
> 
> ~/git/rootfs/platform-ec2k/report$ grep -r "#"
> license-report.tex:{\huge \vfill for project \vfill GridPoint-rootfs# Set
> automatically in rules/os-release.make}
> license-report.log:! You can't use `macro parameter character #' in
> horizontal mode.
> license-report.log:l.36 ...vfill for project \vfill GridPoint-rootfs#
> license-report.aux:\gdef\contentsline#1#2#3#4{\oldcontentsline{#1}{#2}{#3}}
> license-report.aux:\gdef\newlabel#1#2{\newlabelxx{#1}#2}
> license-report.aux:\gdef\newlabelxx#1#2#3#4#5#6{\oldnewlabel{#1}{{#2}{#3}}}
> license-report.aux:\gdef\HyperFirstAtBeginDocument#1{#1}
> 
> This is coming from my selected_ptxconfig:
> PTXCONF_PROJECT_VERSION="# Set automatically in rules/os-release.make"
> 
> Escaping the # in the ptxconfig fixed the issue.

PTXCONF_PROJECT_VERSION is escaped with ptxd_make_latex_escape() as well,
so if that is fixed, then it should work as expected as well.

Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de