Re: [ptxdist] [PATCH 2/2] timezone: Support for zonetab1970

[Gavin Schenk <g.schenk@eckelmann.de>]

Hi,

this is still in my queue so I send a gentle ping.

> > > @@ -252,4 +252,13 @@ config TIMEZONE_ZULU
> > >  bool
> > >  prompt "Zulu"
> > >
> > > +config TIMEZONE_ZONETAB_1970
> > > +bool
> > > +prompt "zone1970.tab"
> > I think `default y if SYSTEMD_TIMEDATE` would be useful here.
> 
> I think "default y if SYSTEMD_TIMEDATE" is a good idea, but does not make a real
> difference.
> 
> Without any of the other TIMEZONE_* options the result would be an empty zone1970.tab.
> I just checked the behaviour on my target.
> 
> With an empty zone1970.tab:
> root 09:13 : /usr/share/zoneinfo # timedatectl list-timezones
> UTC
> 
> Without the file the behaviour is the same:
> root 09:13 : /usr/share/zoneinfo # timedatectl list-timezones
> UTC
> 
> The folder /usr/share/zoneinfo of course contains more timezones on this target.
> 
> So the dependency is more like "if SYSTEMD_TIMEDATE and at least one TIMEZONE_*
> option is set select TIMEZONE_ZONETAB_1970" Can you express that in Kconfig?

RFC
Is a dependency not required here?
If not, can you please apply this series?
If dep is required, is `default y if SYSTEMD_TIMEDATE` the way to go?
If not can you help me to do it right I cannot express it the way I want.


Regards
Gavin

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de