From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 05 Nov 2021 16:48:38 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mj1SI-0001HH-9E for lore@lore.pengutronix.de; Fri, 05 Nov 2021 16:48:38 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mj1SH-00087H-HA; Fri, 05 Nov 2021 16:48:37 +0100 Received: from mail.thorsis.com ([92.198.35.195]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mj1RW-0007Zo-HT; Fri, 05 Nov 2021 16:47:51 +0100 Received: from localhost (localhost [127.0.0.1]) by mail.thorsis.com (Postfix) with ESMTP id B90E3E5C; Fri, 5 Nov 2021 16:47:49 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail.thorsis.com Received: from mail.thorsis.com ([127.0.0.1]) by localhost (mail.thorsis.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id r3DAFAuU3ILp; Fri, 5 Nov 2021 16:47:49 +0100 (CET) Received: by mail.thorsis.com (Postfix, from userid 109) id 8B127E0D; Fri, 5 Nov 2021 16:47:49 +0100 (CET) Received: from adahl by ada.ifak-system.com with local (Exim 4.92) (envelope-from ) id 1mj1RG-0005DK-Pl; Fri, 05 Nov 2021 16:47:34 +0100 From: Alexander Dahl To: ptxdist@pengutronix.de Date: Fri, 5 Nov 2021 16:47:29 +0100 Message-Id: <20211105154734.19983-4-ada@thorsis.com> In-Reply-To: <20211105154734.19983-1-ada@thorsis.com> References: <20211105154734.19983-1-ada@thorsis.com> X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Subject: [ptxdist] [PATCH v3 3/8] dropbear: Move shell variables to new common shell lib X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Denis Osterland-Heim , Michael Olbrich , Bruno Thomsen , Alexander Stein MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false init script and rc-once script use some common variables and targetinstall replace happens twice for each, so to make things less complex put those common variables in a common place. While at it, remove that DROPBEAR_xxxKEY_DEFAULT indirection, which probably originates in the init script from Debian, which seems was the base for developing this script at least 15 years ago. The lib will be extended with more variables later. Signed-off-by: Alexander Dahl --- Notes: v2 -> v3 -------- - adapted to DSS key support removal projectroot/etc/init.d/dropbear | 6 ++---- projectroot/etc/rc.once.d/dropbear | 5 +---- projectroot/usr/lib/init/dropbear.sh | 3 +++ rules/dropbear.make | 8 ++++---- 4 files changed, 10 insertions(+), 12 deletions(-) create mode 100644 projectroot/usr/lib/init/dropbear.sh diff --git a/projectroot/etc/init.d/dropbear b/projectroot/etc/init.d/dropbear index 4d6530bdc..b394eab15 100644 --- a/projectroot/etc/init.d/dropbear +++ b/projectroot/etc/init.d/dropbear @@ -7,14 +7,12 @@ NAME=dropbear DROPBEAR_PORT=22 DROPBEAR_EXTRA_ARGS= -# test ! -h /var/service/dropbear || exit 0 +. /usr/lib/init/dropbear.sh -DROPBEAR_RSAKEY_DEFAULT="@KEYDIR@/dropbear_rsa_host_key" +# test ! -h /var/service/dropbear || exit 0 test -z "$DROPBEAR_BANNER" || \ DROPBEAR_EXTRA_ARGS="$DROPBEAR_EXTRA_ARGS -b $DROPBEAR_BANNER" -test -n "$DROPBEAR_RSAKEY" || \ - DROPBEAR_RSAKEY=$DROPBEAR_RSAKEY_DEFAULT test -n "$DROPBEAR_KEYTYPES" || \ DROPBEAR_KEYTYPES="rsa" diff --git a/projectroot/etc/rc.once.d/dropbear b/projectroot/etc/rc.once.d/dropbear index 451236097..b70f5f22e 100644 --- a/projectroot/etc/rc.once.d/dropbear +++ b/projectroot/etc/rc.once.d/dropbear @@ -2,10 +2,7 @@ PATH=/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin -DROPBEAR_RSAKEY_DEFAULT="@KEYDIR@/dropbear_rsa_host_key" - -test -n "$DROPBEAR_RSAKEY" || \ - DROPBEAR_RSAKEY=$DROPBEAR_RSAKEY_DEFAULT +. /usr/lib/init/dropbear.sh gen_key() { diff --git a/projectroot/usr/lib/init/dropbear.sh b/projectroot/usr/lib/init/dropbear.sh new file mode 100644 index 000000000..7b94429b4 --- /dev/null +++ b/projectroot/usr/lib/init/dropbear.sh @@ -0,0 +1,3 @@ +#!/bin/sh + +DROPBEAR_RSAKEY='@KEYDIR@/dropbear_rsa_host_key' diff --git a/rules/dropbear.make b/rules/dropbear.make index 501b94764..bdf855fe3 100644 --- a/rules/dropbear.make +++ b/rules/dropbear.make @@ -273,6 +273,10 @@ $(STATEDIR)/dropbear.targetinstall: @$(call install_fixup, dropbear,AUTHOR,"Robert Schwebel ") @$(call install_fixup, dropbear,DESCRIPTION,missing) + @$(call install_alternative, dropbear, 0, 0, 0644, /usr/lib/init/dropbear.sh) + @$(call install_replace, dropbear, /usr/lib/init/dropbear.sh, \ + @KEYDIR@, $(PTXCONF_DROPBEAR_KEY_DIR)) + ifdef PTXCONF_DROPBEAR_DROPBEAR @$(call install_copy, dropbear, 0, 0, 0755, -, \ /usr/sbin/dropbear) @@ -283,8 +287,6 @@ ifdef PTXCONF_DROPBEAR_DROPBEAR_KEY /usr/bin/dropbearkey) @$(call install_alternative, dropbear, 0, 0, 0755, /etc/rc.once.d/dropbear, n) - @$(call install_replace, dropbear, /etc/rc.once.d/dropbear, \ - @KEYDIR@, $(PTXCONF_DROPBEAR_KEY_DIR)) endif ifdef PTXCONF_DROPBEAR_DROPBEAR_CONVERT @@ -305,8 +307,6 @@ endif ifdef PTXCONF_DROPBEAR_STARTSCRIPT @$(call install_alternative, dropbear, 0, 0, 0755, /etc/init.d/dropbear, n) - @$(call install_replace, dropbear, /etc/init.d/dropbear, \ - @KEYDIR@, $(PTXCONF_DROPBEAR_KEY_DIR)) ifneq ($(call remove_quotes,$(PTXCONF_DROPBEAR_BBINIT_LINK)),) @$(call install_link, dropbear, \ -- 2.30.2 _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de