mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Alexander Dahl <ada@thorsis.com>
Subject: Re: [ptxdist] [APPLIED] gpsd: Make more prepare options configurable
Date: Fri,  5 Nov 2021 08:55:27 +0100	[thread overview]
Message-ID: <20211105075527.3115933-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20211025130910.7257-3-ada@thorsis.com>

Thanks, applied as 1de43bc97bee64fdece777c5498328722eede2f3.

Michael

[sent from post-receive hook]

On Fri, 05 Nov 2021 08:55:26 +0100, Alexander Dahl <ada@thorsis.com> wrote:
> With squelch=no gpsd produces no logging output at all, not even when
> using -D3 or higher as parameter.
> 
> Signed-off-by: Alexander Dahl <ada@thorsis.com>
> Message-Id: <20211025130910.7257-3-ada@thorsis.com>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/gpsd.in b/rules/gpsd.in
> index deebe6bbc0c7..f14fcb7cc510 100644
> --- a/rules/gpsd.in
> +++ b/rules/gpsd.in
> @@ -68,6 +68,19 @@ config GPSD_USB
>  
>  comment "Other options    ---"
>  
> +config GPSD_DEBUG
> +	bool
> +	prompt "debug support"
> +	help
> +	  Client debug support, debug information in build, install
> +	  gpsdebuginfo.
> +
> +config GPSD_LOGGING
> +	bool
> +	prompt "log/hexdump"
> +	help
> +	  If unset: squelch gpsd_log/gpsd_hexdump to save cpu.
> +
>  config GPSD_LIBGPSMM
>  	bool
>  	prompt "C++ class wrappers"
> diff --git a/rules/gpsd.make b/rules/gpsd.make
> index 75c497e632f7..c804cfebf2fb 100644
> --- a/rules/gpsd.make
> +++ b/rules/gpsd.make
> @@ -61,11 +61,12 @@ GPSD_CONF_OPT	= \
>  	aivdm=$(call ptx/yesno, PTXCONF_GPSD_DRIVER_AIVDM) \
>  	ashtech=$(call ptx/yesno, PTXCONF_GPSD_DRIVER_ASHTECH) \
>  	bluez=$(call ptx/yesno, PTXCONF_GPSD_BLUEZ) \
> -	clientdebug=no \
> +	clientdebug=$(call ptx/yesno, PTXCONF_GPSD_DEBUG) \
>  	control_socket=yes \
>  	coveraging=no \
>  	dbus_export=$(call ptx/yesno, PTXCONF_GPSD_DBUS) \
> -	debug=no \
> +	debug=$(call ptx/yesno, PTXCONF_GPSD_DEBUG) \
> +	debug_opt=false \
>  	earthmate=$(call ptx/yesno, PTXCONF_GPSD_DRIVER_EARTHMATE) \
>  	evermore=$(call ptx/yesno, PTXCONF_GPSD_DRIVER_EVERMORE) \
>  	force_global=yes \
> @@ -111,7 +112,7 @@ GPSD_CONF_OPT	= \
>  	sirf=$(call ptx/yesno, PTXCONF_GPSD_DRIVER_SIRF) \
>  	skytraq=$(call ptx/yesno, PTXCONF_GPSD_DRIVER_SKYTRAQ) \
>  	socket_export=$(call ptx/yesno, PTXCONF_GPSD_SOCKET) \
> -	squelch=yes \
> +	squelch=$(call ptx/noyes, PTXCONF_GPSD_LOGGING) \
>  	superstar2=$(call ptx/yesno, PTXCONF_GPSD_DRIVER_SUPERSTAR2) \
>  	sysconfdir=/etc \
>  	systemd=$(call ptx/yesno, PTXCONF_GPSD_SYSTEMD) \
> @@ -184,6 +185,9 @@ endif
>  ifdef PTXCONF_GPSD_PYTHON
>  	@$(call install_glob, gpsd, 0, 0, -, \
>  		/usr/lib/python$(PYTHON3_MAJORMINOR), *.py)
> +endif
> +ifdef PTXCONF_GPSD_DEBUG
> +	@$(call install_copy, gpsd, 0, 0, 0755, -, /usr/bin/gpsdebuginfo)
>  endif
>  	@$(call install_finish, gpsd)
>  

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de


      reply	other threads:[~2021-11-05  7:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-25 13:09 [ptxdist] [PATCH 0/2] gpsd: Allow logging Alexander Dahl
2021-10-25 13:09 ` [ptxdist] [PATCH 1/2] Add macro 'noyes' as reverse of 'yesno' Alexander Dahl
2021-11-05  7:55   ` [ptxdist] [APPLIED] " Michael Olbrich
2021-10-25 13:09 ` [ptxdist] [PATCH 2/2] gpsd: Make more prepare options configurable Alexander Dahl
2021-11-05  7:55   ` Michael Olbrich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211105075527.3115933-1-m.olbrich@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ada@thorsis.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox