mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Gavin Schenk <g.schenk@eckelmann.de>
To: <ptxdist@pengutronix.de>
Subject: Re: [ptxdist] [PATCH 2/2] timezone: Support for zonetab1970
Date: Tue, 2 Nov 2021 09:34:17 +0100	[thread overview]
Message-ID: <20211102083417.3pjvkdct2gvddj32@NB061.eckelmann.group> (raw)
In-Reply-To: <532056888e9249b9926407fe40c4879965ff1805.camel@diehl.com>

Hi

> > @@ -252,4 +252,13 @@ config TIMEZONE_ZULU
> >  bool
> >  prompt "Zulu"
> >
> > +config TIMEZONE_ZONETAB_1970
> > +bool
> > +prompt "zone1970.tab"
> I think `default y if SYSTEMD_TIMEDATE` would be useful here.

I think "default y if SYSTEMD_TIMEDATE" is a good idea, but does not make a real
difference.

Without any of the other TIMEZONE_* options the result would be an empty zone1970.tab.
I just checked the behaviour on my target.

With an empty zone1970.tab:
root 09:13 : /usr/share/zoneinfo # timedatectl list-timezones
UTC

Without the file the behaviour is the same:
root 09:13 : /usr/share/zoneinfo # timedatectl list-timezones
UTC

The folder /usr/share/zoneinfo of course contains more timezones on this target.

So the dependency is more like "if SYSTEMD_TIMEDATE and at least one TIMEZONE_*
option is set select TIMEZONE_ZONETAB_1970" Can you express that in Kconfig?

Regards
Gavin

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de


  reply	other threads:[~2021-11-02  8:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-01 11:38 [ptxdist] [PATCH 0/2] Using systemd/timedatectl to handle timedate Gavin Schenk
2021-11-01 11:38 ` [ptxdist] [PATCH 1/2] host-tz-database: Version bump 2020d -> 2021e Gavin Schenk
2021-11-01 12:46   ` Alexander Dahl
2021-12-17 14:59     ` Alexander Dahl
2021-12-18  7:35       ` [ptxdist] [PATCH v2 " Gavin Schenk
2021-12-18  7:42   ` [ptxdist] [APPLIED] " Michael Olbrich
2021-11-01 11:38 ` [ptxdist] [PATCH 2/2] timezone: Support for zonetab1970 Gavin Schenk
2021-11-02  5:56   ` Denis Osterland-Heim
2021-11-02  8:34     ` Gavin Schenk [this message]
2021-11-22 11:32       ` Gavin Schenk
2021-11-25 15:52   ` Michael Olbrich
2021-12-03 15:23     ` [ptxdist] [PATCH v2] " Gavin Schenk
2021-12-08  7:40       ` Michael Olbrich
2021-12-15 13:50         ` [ptxdist] [PATCH v3] " Gavin Schenk
2021-12-17 13:27           ` [ptxdist] [APPLIED] " Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211102083417.3pjvkdct2gvddj32@NB061.eckelmann.group \
    --to=g.schenk@eckelmann.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox