From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 11 Oct 2021 14:54:41 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mZupF-0001wc-LT for lore@lore.pengutronix.de; Mon, 11 Oct 2021 14:54:41 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mZupF-0002Zq-At; Mon, 11 Oct 2021 14:54:41 +0200 Received: from mail.thorsis.com ([92.198.35.195]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mZuoj-0002ZX-Ve; Mon, 11 Oct 2021 14:54:10 +0200 Received: from localhost (localhost [127.0.0.1]) by mail.thorsis.com (Postfix) with ESMTP id 7654A24F3; Mon, 11 Oct 2021 14:54:08 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.thorsis.com Received: from mail.thorsis.com ([127.0.0.1]) by localhost (mail.thorsis.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h3G6JCMJbCLp; Mon, 11 Oct 2021 14:54:04 +0200 (CEST) Received: by mail.thorsis.com (Postfix, from userid 109) id 95C85293F; Mon, 11 Oct 2021 14:54:04 +0200 (CEST) Received: from adahl by ada.ifak-system.com with local (Exim 4.92) (envelope-from ) id 1mZuob-0007v8-SB; Mon, 11 Oct 2021 14:54:01 +0200 From: Alexander Dahl To: ptxdist@pengutronix.de Date: Mon, 11 Oct 2021 14:54:01 +0200 Message-Id: <20211011125401.30402-1-ada@thorsis.com> X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Subject: [ptxdist] [RFC PATCH] rc-once: openssh: Do not overwrite existing keys X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Marc Kleine-Budde , Alexander Stein MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false When storing your keys not in rootfs but on a separate data partition (using symbolic links or overlay fs), keys are overwritten on each firmware upgrade which lets rc-once run again (which happens when using opkg upgrade/update or RAUC in an A/B scheme for example). Changing keys are at best annoying, but may be interpreted as an attack as well. For dropbear the same behaviour was implemented with ac97e77eedf7 ("[dropbear] rc.once: only generate keys if they aren't present yet"). Signed-off-by: Alexander Dahl --- projectroot/etc/rc.once.d/openssh | 1 + 1 file changed, 1 insertion(+) diff --git a/projectroot/etc/rc.once.d/openssh b/projectroot/etc/rc.once.d/openssh index 545586f07..595e28477 100644 --- a/projectroot/etc/rc.once.d/openssh +++ b/projectroot/etc/rc.once.d/openssh @@ -27,6 +27,7 @@ create_keys() { hostkeys="$(get_hostkeys)" || return for keyfile in $hostkeys; do + [ -e "$keyfile" ] && continue create_key "$keyfile" || return done } base-commit: 51994d1b518323d2975491090a2452d34b1a39f9 -- 2.30.2 _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de