mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Christian Melki <christian.melki@t2data.com>
Subject: Re: [ptxdist] [APPLIED] pre/Rules.make: Let CMAKE_INSTALL_LIBDIR be relative, as per spec.
Date: Thu,  7 Oct 2021 12:18:19 +0200	[thread overview]
Message-ID: <20211007101819.3922856-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20210809083621.3676-1-christian.melki@t2data.com>

Thanks, applied as 3fa9174fa8ce494337253620f87ed2c9de631cec.

Michael

[sent from post-receive hook]

On Thu, 07 Oct 2021 12:18:19 +0200, Christian Melki <christian.melki@t2data.com> wrote:
> This means that packages that assume that this variable is absolute
> will have to be modified.
> Adding something like -DCMAKE_INSTALL_LIBDIR=/usr/$(CROSS_LIB_DIR),
> after CROSS_CMAKE_USR to your CONF_OPT will probably suffice.
> 
> Signed-off-by: Christian Melki <christian.melki@t2data.com>
> Reviewed-by: Denis Osterland-Heim <denis.osterland@diehl.com>
> Tested-by: Alexander Dahl <ada@thorsis.com>
> Message-Id: <20210809083621.3676-1-christian.melki@t2data.com>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/pre/Rules.make b/rules/pre/Rules.make
> index 54a677c474d2..0943a51b7a1d 100644
> --- a/rules/pre/Rules.make
> +++ b/rules/pre/Rules.make
> @@ -233,7 +233,7 @@ CROSS_AUTOCONF_ROOT := $(CROSS_AUTOCONF_SYSROOT_ROOT) $(CROSS_AUTOCONF_ARCH)
>  
>  CROSS_CMAKE_USR	 := \
>  	-DCMAKE_INSTALL_PREFIX=/usr \
> -	-DCMAKE_INSTALL_LIBDIR=/usr/$(CROSS_LIB_DIR) \
> +	-DCMAKE_INSTALL_LIBDIR=$(CROSS_LIB_DIR) \
>  	-DCMAKE_INSTALL_SYSCONFDIR=/etc \
>  	-DCMAKE_BUILD_TYPE:STRING=RelWithDebInfo \
>  	-DCMAKE_TOOLCHAIN_FILE='${PTXDIST_CMAKE_TOOLCHAIN_TARGET}'

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de


      parent reply	other threads:[~2021-10-07 10:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-09  8:36 [ptxdist] [PATCH] " Christian Melki
2021-08-10  5:45 ` Denis Osterland-Heim
2021-08-25 14:58   ` Alexander Dahl
2021-10-07 10:18 ` Michael Olbrich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211007101819.3922856-1-m.olbrich@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=christian.melki@t2data.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox