mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: Roland Hieber <rhi@pengutronix.de>, ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH v3 1/5] kernel: make sure that kbuild can extract keys from the HSM
Date: Wed, 29 Sep 2021 13:54:00 +0200	[thread overview]
Message-ID: <20210929115400.GF2560099@pengutronix.de> (raw)
In-Reply-To: <20210912205925.23644-1-rhi@pengutronix.de>

On Sun, Sep 12, 2021 at 10:59:21PM +0200, Roland Hieber wrote:
> CODE_SIGNING_ENV provides the config files and the PKCS11 engine for
> OpenSSL and SoftHSM, which kbuild calls when signing the kernel modules.
> 
> Fixes: 3ffb3585dd13de9e20d1 (2021-07-23, "kernel: add support for module signing")
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
> PATCH v3:
>  - new in v3, and yet another case of "how did this ever work before?"
> ---
>  rules/kernel.make | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/rules/kernel.make b/rules/kernel.make
> index 9caff677918e..7a4642f3d07f 100644
> --- a/rules/kernel.make
> +++ b/rules/kernel.make
> @@ -187,6 +187,9 @@ $(STATEDIR)/kernel.tags:
>  # Compile
>  # ----------------------------------------------------------------------------
>  
> +KERNEL_MAKE_ENV		+= \
> +	$(CODE_SIGNING_ENV)
> +
>  KERNEL_MAKE_OPT		= \
>  	$(call kernel/deprecated, KERNEL_MAKE_OPT) \
>  	$(KERNEL_SHARED_OPT) \
> @@ -254,6 +257,9 @@ endif
>  # Install
>  # ----------------------------------------------------------------------------
>  
> +KERNEL_INSTALL_ENV	+= \
> +	$(CODE_SIGNING_ENV)

This should not be needed. KERNEL_MAKE_ENV should be used for compile and
install. Build with '-v' to see the commandline.

Michael

> +
>  KERNEL_INSTALL_OPT = \
>  	$(KERNEL_BASE_OPT) \
>  	modules_install
> -- 
> 2.30.2
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de


      parent reply	other threads:[~2021-09-29 11:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-12 20:59 Roland Hieber
2021-09-12 20:59 ` [ptxdist] [PATCH v3 2/5] ptxd_lib_code_signing: return success in case of ERROR_CA_NOT_YET_SET Roland Hieber
2021-09-12 20:59 ` [ptxdist] [PATCH v3 3/5] libptxdist: introduce ptxd_exec_silent_stderr Roland Hieber
2021-09-12 20:59 ` [ptxdist] [PATCH v3 4/5] ptxd_lib_code_signing: provide consumer functions with some environment Roland Hieber
2021-09-12 20:59 ` [ptxdist] [PATCH v3 5/5] ptxd_lib_code_signing: add key whitelist checks Roland Hieber
2021-09-29 12:08   ` Michael Olbrich
2021-09-29 11:54 ` Michael Olbrich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210929115400.GF2560099@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    --cc=rhi@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox