From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 29 Sep 2021 13:50:07 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mVY6B-0007KR-Lg for lore@lore.pengutronix.de; Wed, 29 Sep 2021 13:50:07 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mVY6B-0004ip-9t; Wed, 29 Sep 2021 13:50:07 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mVY5s-0004iJ-FB; Wed, 29 Sep 2021 13:49:48 +0200 Received: from [2a0a:edc0:0:1101:1d::39] (helo=dude03.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mVY5r-0004xX-Rm; Wed, 29 Sep 2021 13:49:47 +0200 Received: from mol by dude03.red.stw.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1mVY5r-00AmKQ-Om; Wed, 29 Sep 2021 13:49:47 +0200 Date: Wed, 29 Sep 2021 13:49:47 +0200 From: Michael Olbrich To: Christian Melki Message-ID: <20210929114947.GD2560099@pengutronix.de> Mail-Followup-To: Christian Melki , ptxdist@pengutronix.de References: <20210910090523.3227433-1-christian.melki@t2data.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210910090523.3227433-1-christian.melki@t2data.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [ptxdist] [PATCH] rules/libgpg-error.make: Remove broken triplet handling. X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false "libgpg-error: " as subject prefix. On Fri, Sep 10, 2021 at 11:05:23AM +0200, Christian Melki wrote: > libgpg-error, historically being rather cross-compile unfriendly, > has gotten better in the later releases. Please mention here that the header is now generated at configure time to explain why this stuff is no longer needed. > Also, this type of triplet handling is broken for triplets without > vendor and various other cases. > This creates more problems than it solves. Remove. You're Signed-off-by is missing. This also applied to your other patches. Michael > --- > rules/libgpg-error.make | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/rules/libgpg-error.make b/rules/libgpg-error.make > index 194cd21db..c04d02210 100644 > --- a/rules/libgpg-error.make > +++ b/rules/libgpg-error.make > @@ -30,10 +30,6 @@ LIBGPG_ERROR_LICENSE_FILES := \ > file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \ > file://COPYING.LIB;md5=2d5025d4aa3495befef8f17206a5b0a1 > > -# Use '=' to delay $(shell ...) calls until this is needed > -LIBGPG_ERROR_TARGET = $(patsubst %-gnueabihf,%-gnueabi,$(patsubst i%86-unknown-linux-gnu,i686-unknown-linux-gnu,$(shell target=$(PTXCONF_GNU_TARGET); echo $${target/-*-linux/-unknown-linux}))) > -LIBGPG_ERROR_TARGET_PTX := $(call remove_quotes, $(PTXCONF_GNU_TARGET)) > - > # ---------------------------------------------------------------------------- > # Prepare > # ---------------------------------------------------------------------------- > @@ -55,15 +51,6 @@ LIBGPG_ERROR_CONF_OPT := \ > --disable-doc \ > --disable-tests > > -$(STATEDIR)/libgpg-error.prepare: > - @$(call targetinfo) > - @if [ ! -e $(LIBGPG_ERROR_DIR)/src/syscfg/lock-obj-pub.$(LIBGPG_ERROR_TARGET_PTX).h ]; then \ > - cp -v $(LIBGPG_ERROR_DIR)/src/syscfg/lock-obj-pub.$(LIBGPG_ERROR_TARGET).h \ > - $(LIBGPG_ERROR_DIR)/src/syscfg/lock-obj-pub.$(LIBGPG_ERROR_TARGET_PTX).h; \ > - fi > - @$(call world/prepare, LIBGPG_ERROR) > - @$(call touch) > - > # ---------------------------------------------------------------------------- > # Target-Install > # ---------------------------------------------------------------------------- > -- > 2.30.2 > > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de