From: Michael Olbrich <m.olbrich@pengutronix.de>
To: Christian Melki <christian.melki@t2data.com>
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] rules/libgpg-error.make: Remove broken triplet handling.
Date: Wed, 29 Sep 2021 13:49:47 +0200 [thread overview]
Message-ID: <20210929114947.GD2560099@pengutronix.de> (raw)
In-Reply-To: <20210910090523.3227433-1-christian.melki@t2data.com>
"libgpg-error: " as subject prefix.
On Fri, Sep 10, 2021 at 11:05:23AM +0200, Christian Melki wrote:
> libgpg-error, historically being rather cross-compile unfriendly,
> has gotten better in the later releases.
Please mention here that the header is now generated at configure time to
explain why this stuff is no longer needed.
> Also, this type of triplet handling is broken for triplets without
> vendor and various other cases.
> This creates more problems than it solves. Remove.
You're Signed-off-by is missing. This also applied to your other patches.
Michael
> ---
> rules/libgpg-error.make | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/rules/libgpg-error.make b/rules/libgpg-error.make
> index 194cd21db..c04d02210 100644
> --- a/rules/libgpg-error.make
> +++ b/rules/libgpg-error.make
> @@ -30,10 +30,6 @@ LIBGPG_ERROR_LICENSE_FILES := \
> file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \
> file://COPYING.LIB;md5=2d5025d4aa3495befef8f17206a5b0a1
>
> -# Use '=' to delay $(shell ...) calls until this is needed
> -LIBGPG_ERROR_TARGET = $(patsubst %-gnueabihf,%-gnueabi,$(patsubst i%86-unknown-linux-gnu,i686-unknown-linux-gnu,$(shell target=$(PTXCONF_GNU_TARGET); echo $${target/-*-linux/-unknown-linux})))
> -LIBGPG_ERROR_TARGET_PTX := $(call remove_quotes, $(PTXCONF_GNU_TARGET))
> -
> # ----------------------------------------------------------------------------
> # Prepare
> # ----------------------------------------------------------------------------
> @@ -55,15 +51,6 @@ LIBGPG_ERROR_CONF_OPT := \
> --disable-doc \
> --disable-tests
>
> -$(STATEDIR)/libgpg-error.prepare:
> - @$(call targetinfo)
> - @if [ ! -e $(LIBGPG_ERROR_DIR)/src/syscfg/lock-obj-pub.$(LIBGPG_ERROR_TARGET_PTX).h ]; then \
> - cp -v $(LIBGPG_ERROR_DIR)/src/syscfg/lock-obj-pub.$(LIBGPG_ERROR_TARGET).h \
> - $(LIBGPG_ERROR_DIR)/src/syscfg/lock-obj-pub.$(LIBGPG_ERROR_TARGET_PTX).h; \
> - fi
> - @$(call world/prepare, LIBGPG_ERROR)
> - @$(call touch)
> -
> # ----------------------------------------------------------------------------
> # Target-Install
> # ----------------------------------------------------------------------------
> --
> 2.30.2
>
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
prev parent reply other threads:[~2021-09-29 11:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 9:05 Christian Melki
2021-09-29 11:49 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210929114947.GD2560099@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=christian.melki@t2data.com \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox