* [ptxdist] [PATCH] rules/module-init-tools: Enable zlib compression support.
@ 2021-09-09 12:01 Christian Melki
2021-09-29 11:26 ` Michael Olbrich
0 siblings, 1 reply; 5+ messages in thread
From: Christian Melki @ 2021-09-09 12:01 UTC (permalink / raw)
To: ptxdist
Let old and trusty module-init-tools handle zlib compressed kernel modules.
---
rules/module-init-tools.in | 7 +++++++
rules/module-init-tools.make | 4 +++-
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/rules/module-init-tools.in b/rules/module-init-tools.in
index 765de6b97..010f68bf2 100644
--- a/rules/module-init-tools.in
+++ b/rules/module-init-tools.in
@@ -4,6 +4,7 @@
menuconfig MODULE_INIT_TOOLS
tristate
prompt "module-init-tools "
+ select ZLIB if MODULE_INIT_TOOLS_ZLIB
help
This package contains a set of programs for loading, inserting
and removing kernel modules for Linux (versions 2.5.48 and
@@ -11,6 +12,12 @@ menuconfig MODULE_INIT_TOOLS
if MODULE_INIT_TOOLS
+config MODULE_INIT_TOOLS_ZLIB
+ bool
+ prompt "zlib compression support"
+ help
+ Enable support for gz compressed kernel modules
+
config MODULE_INIT_TOOLS_INSMOD
bool
prompt "Install insmod on target"
diff --git a/rules/module-init-tools.make b/rules/module-init-tools.make
index a4aa68175..da5a892bf 100644
--- a/rules/module-init-tools.make
+++ b/rules/module-init-tools.make
@@ -35,7 +35,9 @@ MODULE_INIT_TOOLS_MAKEVARS := MAN5="" MAN8=""
#
# autoconf
#
-MODULE_INIT_TOOLS_AUTOCONF := $(CROSS_AUTOCONF_USR)
+MODULE_INIT_TOOLS_AUTOCONF := \
+ $(CROSS_AUTOCONF_USR) \
+ --$(call ptx/endis, PTXCONF_MODULE_INIT_TOOLS_ZLIB)-zlib-dynamic
# ----------------------------------------------------------------------------
# Target-Install
--
2.30.2
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ptxdist] [PATCH] rules/module-init-tools: Enable zlib compression support.
2021-09-09 12:01 [ptxdist] [PATCH] rules/module-init-tools: Enable zlib compression support Christian Melki
@ 2021-09-29 11:26 ` Michael Olbrich
2021-10-08 20:28 ` Christian Melki
0 siblings, 1 reply; 5+ messages in thread
From: Michael Olbrich @ 2021-09-29 11:26 UTC (permalink / raw)
To: Christian Melki; +Cc: ptxdist
On Thu, Sep 09, 2021 at 02:01:16PM +0200, Christian Melki wrote:
> Let old and trusty module-init-tools handle zlib compressed kernel modules.
Any reason why you use this instead of libkmod? The module-init-tools are
no longer maintained, so I would actually prefer to move the package to
staging and remove it eventually. Unless there is a specific use-case for
them that does not work with libkmod?
Michael
> ---
> rules/module-init-tools.in | 7 +++++++
> rules/module-init-tools.make | 4 +++-
> 2 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/rules/module-init-tools.in b/rules/module-init-tools.in
> index 765de6b97..010f68bf2 100644
> --- a/rules/module-init-tools.in
> +++ b/rules/module-init-tools.in
> @@ -4,6 +4,7 @@
> menuconfig MODULE_INIT_TOOLS
> tristate
> prompt "module-init-tools "
> + select ZLIB if MODULE_INIT_TOOLS_ZLIB
> help
> This package contains a set of programs for loading, inserting
> and removing kernel modules for Linux (versions 2.5.48 and
> @@ -11,6 +12,12 @@ menuconfig MODULE_INIT_TOOLS
>
> if MODULE_INIT_TOOLS
>
> +config MODULE_INIT_TOOLS_ZLIB
> + bool
> + prompt "zlib compression support"
> + help
> + Enable support for gz compressed kernel modules
> +
> config MODULE_INIT_TOOLS_INSMOD
> bool
> prompt "Install insmod on target"
> diff --git a/rules/module-init-tools.make b/rules/module-init-tools.make
> index a4aa68175..da5a892bf 100644
> --- a/rules/module-init-tools.make
> +++ b/rules/module-init-tools.make
> @@ -35,7 +35,9 @@ MODULE_INIT_TOOLS_MAKEVARS := MAN5="" MAN8=""
> #
> # autoconf
> #
> -MODULE_INIT_TOOLS_AUTOCONF := $(CROSS_AUTOCONF_USR)
> +MODULE_INIT_TOOLS_AUTOCONF := \
> + $(CROSS_AUTOCONF_USR) \
> + --$(call ptx/endis, PTXCONF_MODULE_INIT_TOOLS_ZLIB)-zlib-dynamic
>
> # ----------------------------------------------------------------------------
> # Target-Install
> --
> 2.30.2
>
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ptxdist] [PATCH] rules/module-init-tools: Enable zlib compression support.
2021-09-29 11:26 ` Michael Olbrich
@ 2021-10-08 20:28 ` Christian Melki
2021-10-11 6:48 ` Michael Olbrich
0 siblings, 1 reply; 5+ messages in thread
From: Christian Melki @ 2021-10-08 20:28 UTC (permalink / raw)
To: ptxdist
On 9/29/21 13:26, Michael Olbrich wrote:
> On Thu, Sep 09, 2021 at 02:01:16PM +0200, Christian Melki wrote:
>> Let old and trusty module-init-tools handle zlib compressed kernel modules.
>
> Any reason why you use this instead of libkmod? The module-init-tools are
> no longer maintained, so I would actually prefer to move the package to
> staging and remove it eventually. Unless there is a specific use-case for
> them that does not work with libkmod?
>
> Michael
>
Nope. No reason. Just compressed module support in case someone uses it.
I don't mind either way. But if it doesn't move to staging then you
might as well add compressed module support? I see no harm.
While we're at it.. Why "staging" for obsoleted packages?
How about obsolete for obsolescence and staging for the fashionable
kids? I think it makes it a whole lot clearer if you're unfamiliar with
whatever package.
>> ---
>> rules/module-init-tools.in | 7 +++++++
>> rules/module-init-tools.make | 4 +++-
>> 2 files changed, 10 insertions(+), 1 deletion(-)
>>
>> diff --git a/rules/module-init-tools.in b/rules/module-init-tools.in
>> index 765de6b97..010f68bf2 100644
>> --- a/rules/module-init-tools.in
>> +++ b/rules/module-init-tools.in
>> @@ -4,6 +4,7 @@
>> menuconfig MODULE_INIT_TOOLS
>> tristate
>> prompt "module-init-tools "
>> + select ZLIB if MODULE_INIT_TOOLS_ZLIB
>> help
>> This package contains a set of programs for loading, inserting
>> and removing kernel modules for Linux (versions 2.5.48 and
>> @@ -11,6 +12,12 @@ menuconfig MODULE_INIT_TOOLS
>>
>> if MODULE_INIT_TOOLS
>>
>> +config MODULE_INIT_TOOLS_ZLIB
>> + bool
>> + prompt "zlib compression support"
>> + help
>> + Enable support for gz compressed kernel modules
>> +
>> config MODULE_INIT_TOOLS_INSMOD
>> bool
>> prompt "Install insmod on target"
>> diff --git a/rules/module-init-tools.make b/rules/module-init-tools.make
>> index a4aa68175..da5a892bf 100644
>> --- a/rules/module-init-tools.make
>> +++ b/rules/module-init-tools.make
>> @@ -35,7 +35,9 @@ MODULE_INIT_TOOLS_MAKEVARS := MAN5="" MAN8=""
>> #
>> # autoconf
>> #
>> -MODULE_INIT_TOOLS_AUTOCONF := $(CROSS_AUTOCONF_USR)
>> +MODULE_INIT_TOOLS_AUTOCONF := \
>> + $(CROSS_AUTOCONF_USR) \
>> + --$(call ptx/endis, PTXCONF_MODULE_INIT_TOOLS_ZLIB)-zlib-dynamic
>>
>> # ----------------------------------------------------------------------------
>> # Target-Install
>> --
>> 2.30.2
>>
>>
>> _______________________________________________
>> ptxdist mailing list
>> ptxdist@pengutronix.de
>> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
>>
>
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ptxdist] [PATCH] rules/module-init-tools: Enable zlib compression support.
2021-10-08 20:28 ` Christian Melki
@ 2021-10-11 6:48 ` Michael Olbrich
2021-10-11 7:44 ` Christian Melki
0 siblings, 1 reply; 5+ messages in thread
From: Michael Olbrich @ 2021-10-11 6:48 UTC (permalink / raw)
To: Christian Melki; +Cc: ptxdist
On Fri, Oct 08, 2021 at 10:28:37PM +0200, Christian Melki wrote:
> On 9/29/21 13:26, Michael Olbrich wrote:
> > On Thu, Sep 09, 2021 at 02:01:16PM +0200, Christian Melki wrote:
> >> Let old and trusty module-init-tools handle zlib compressed kernel modules.
> >
> > Any reason why you use this instead of libkmod? The module-init-tools are
> > no longer maintained, so I would actually prefer to move the package to
> > staging and remove it eventually. Unless there is a specific use-case for
> > them that does not work with libkmod?
> >
> > Michael
> >
>
> Nope. No reason. Just compressed module support in case someone uses it.
> I don't mind either way. But if it doesn't move to staging then you
> might as well add compressed module support? I see no harm.
I'll move it to staging. I just wanted to make sure that there isn't a
use-case that requires it specifically.
> While we're at it.. Why "staging" for obsoleted packages?
It started out as a place for badly maintained (in ptxdist) packages to
give people a chance to update and improve the rules before I remove them
completely.
I didn't want to create a different section for packages that just move
there to give people a change to update to something else.
> How about obsolete for obsolescence and staging for the fashionable
> kids? I think it makes it a whole lot clearer if you're unfamiliar with
> whatever package.
The problem is, that there are always grey areas. So I want to keep all in
one section. When I move a package to staging, then I put a comment in the
menu file that should tell you why it's there.
Michael
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ptxdist] [PATCH] rules/module-init-tools: Enable zlib compression support.
2021-10-11 6:48 ` Michael Olbrich
@ 2021-10-11 7:44 ` Christian Melki
0 siblings, 0 replies; 5+ messages in thread
From: Christian Melki @ 2021-10-11 7:44 UTC (permalink / raw)
To: ptxdist
On 10/11/21 8:48 AM, Michael Olbrich wrote:
> On Fri, Oct 08, 2021 at 10:28:37PM +0200, Christian Melki wrote:
>> On 9/29/21 13:26, Michael Olbrich wrote:
>>> On Thu, Sep 09, 2021 at 02:01:16PM +0200, Christian Melki wrote:
>>>> Let old and trusty module-init-tools handle zlib compressed kernel modules.
>>>
>>> Any reason why you use this instead of libkmod? The module-init-tools are
>>> no longer maintained, so I would actually prefer to move the package to
>>> staging and remove it eventually. Unless there is a specific use-case for
>>> them that does not work with libkmod?
>>>
>>> Michael
>>>
>>
>> Nope. No reason. Just compressed module support in case someone uses it.
>> I don't mind either way. But if it doesn't move to staging then you
>> might as well add compressed module support? I see no harm.
>
> I'll move it to staging. I just wanted to make sure that there isn't a
> use-case that requires it specifically.
>
>> While we're at it.. Why "staging" for obsoleted packages?
>
> It started out as a place for badly maintained (in ptxdist) packages to
> give people a chance to update and improve the rules before I remove them
> completely.
> I didn't want to create a different section for packages that just move
> there to give people a change to update to something else.
>
>> How about obsolete for obsolescence and staging for the fashionable
>> kids? I think it makes it a whole lot clearer if you're unfamiliar with
>> whatever package.
>
> The problem is, that there are always grey areas. So I want to keep all in
> one section. When I move a package to staging, then I put a comment in the
> menu file that should tell you why it's there.
Ack. Thanks for taking time to explain it.
> Michael
>
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-11 7:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-09 12:01 [ptxdist] [PATCH] rules/module-init-tools: Enable zlib compression support Christian Melki
2021-09-29 11:26 ` Michael Olbrich
2021-10-08 20:28 ` Christian Melki
2021-10-11 6:48 ` Michael Olbrich
2021-10-11 7:44 ` Christian Melki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox