From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 29 Sep 2021 13:26:40 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mVXjU-0006az-JX for lore@lore.pengutronix.de; Wed, 29 Sep 2021 13:26:40 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mVXjU-0002JU-2s; Wed, 29 Sep 2021 13:26:40 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mVXj1-0002JJ-PW; Wed, 29 Sep 2021 13:26:11 +0200 Received: from [2a0a:edc0:0:1101:1d::39] (helo=dude03.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mVXj1-0004vi-4D; Wed, 29 Sep 2021 13:26:11 +0200 Received: from mol by dude03.red.stw.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1mVXj1-00Alh3-1B; Wed, 29 Sep 2021 13:26:11 +0200 Date: Wed, 29 Sep 2021 13:26:11 +0200 From: Michael Olbrich To: Christian Melki Message-ID: <20210929112610.GC2560099@pengutronix.de> Mail-Followup-To: Christian Melki , ptxdist@pengutronix.de References: <20210909120116.2278825-1-christian.melki@t2data.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210909120116.2278825-1-christian.melki@t2data.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [ptxdist] [PATCH] rules/module-init-tools: Enable zlib compression support. X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Thu, Sep 09, 2021 at 02:01:16PM +0200, Christian Melki wrote: > Let old and trusty module-init-tools handle zlib compressed kernel modules. Any reason why you use this instead of libkmod? The module-init-tools are no longer maintained, so I would actually prefer to move the package to staging and remove it eventually. Unless there is a specific use-case for them that does not work with libkmod? Michael > --- > rules/module-init-tools.in | 7 +++++++ > rules/module-init-tools.make | 4 +++- > 2 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/rules/module-init-tools.in b/rules/module-init-tools.in > index 765de6b97..010f68bf2 100644 > --- a/rules/module-init-tools.in > +++ b/rules/module-init-tools.in > @@ -4,6 +4,7 @@ > menuconfig MODULE_INIT_TOOLS > tristate > prompt "module-init-tools " > + select ZLIB if MODULE_INIT_TOOLS_ZLIB > help > This package contains a set of programs for loading, inserting > and removing kernel modules for Linux (versions 2.5.48 and > @@ -11,6 +12,12 @@ menuconfig MODULE_INIT_TOOLS > > if MODULE_INIT_TOOLS > > +config MODULE_INIT_TOOLS_ZLIB > + bool > + prompt "zlib compression support" > + help > + Enable support for gz compressed kernel modules > + > config MODULE_INIT_TOOLS_INSMOD > bool > prompt "Install insmod on target" > diff --git a/rules/module-init-tools.make b/rules/module-init-tools.make > index a4aa68175..da5a892bf 100644 > --- a/rules/module-init-tools.make > +++ b/rules/module-init-tools.make > @@ -35,7 +35,9 @@ MODULE_INIT_TOOLS_MAKEVARS := MAN5="" MAN8="" > # > # autoconf > # > -MODULE_INIT_TOOLS_AUTOCONF := $(CROSS_AUTOCONF_USR) > +MODULE_INIT_TOOLS_AUTOCONF := \ > + $(CROSS_AUTOCONF_USR) \ > + --$(call ptx/endis, PTXCONF_MODULE_INIT_TOOLS_ZLIB)-zlib-dynamic > > # ---------------------------------------------------------------------------- > # Target-Install > -- > 2.30.2 > > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de