Re: [ptxdist] [PATCH 2/2] gt: add gadget-tool

[Roland Hieber <rhi@pengutronix.de>]

On Thu, Sep 23, 2021 at 09:45:40AM +0200, Michael Grzeschik wrote:
> Gadget-tool is a tool to setup configfs gadget device descriptions
> via a tree based declarative scheme format. This makes poking around
> in configfs with several shell commands obsolete. It depends on libusbgx
> and libconfig.
> 
> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> ---
>  rules/gt.in   | 11 ++++++++++
>  rules/gt.make | 56 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 67 insertions(+)
>  create mode 100644 rules/gt.in
>  create mode 100644 rules/gt.make
> 
> diff --git a/rules/gt.in b/rules/gt.in
> new file mode 100644
> index 000000000..5084a554b
> --- /dev/null
> +++ b/rules/gt.in
> @@ -0,0 +1,11 @@
> +## SECTION=shell_and_console
> +
> +config GT
> +	tristate
> +	select HOST_CMAKE
> +	select LIBUSBGX
> +	select LIBUSBGX_SCHEMES
> +	select LIBCONFIG
> +	prompt "gadget-tool (gt)"
> +	help
> +	  Gadget-tool - Linux command line tool for setting USB gadget using configFS
> diff --git a/rules/gt.make b/rules/gt.make
> new file mode 100644
> index 000000000..d94e42ca8
> --- /dev/null
> +++ b/rules/gt.make
> @@ -0,0 +1,56 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2021 by Michael Grzeschik <m.grzeschik@pengutronix.de>
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_GT) += gt
> +
> +#
> +# Paths and names
> +#
> +GT_VERSION	:= 31b13554
> +GT_MD5		:= 083a1e9f8c55812c0ef148a8ab0af862
> +GT		:= gt-$(GT_VERSION)
> +GT_SUFFIX	:= tar.bz2
> +GT_URL		:= https://github.com/linux-usb-gadgets/gt.git;tag=$(GT_VERSION)

You should be able to use GitHub's archive URLs, e.g.

    https://github.com/linux-usb-gadgets/gt/archive/$(GT_VERSION).$(GT_SUFFIX)

This way PTXdist doesn't need to clone the whole git repo first. But
both ways are fine I think.

> +GT_SOURCE	:= $(SRCDIR)/$(GT).$(GT_SUFFIX)
> +GT_DIR		:= $(BUILDDIR)/$(GT)/source
> +GT_LICENSE	:= Apache-2.0
> +GT_LICENSE_FILES	:= \
> +	file://../LICENSE;md5=785f417ec07d653f268e6eb621218d5do

Please also include at least one license statement [1], e.g. from main.c:

        file://main.c;startline=2;endline=14;md5=239ab3ef885c745f3896a83f17482d6d

[1]: see https://www.ptxdist.org/doc/dev_licenses.html#finding-licensing-information

> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +GT_CONF_TOOL	:= cmake
> +GT_CONF_OPT	:= \
> +	$(CROSS_CMAKE_USR)
> +
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/gt.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, gt)
> +	@$(call install_fixup, gt, PRIORITY, optional)
> +	@$(call install_fixup, gt, SECTION, base)
> +	@$(call install_fixup, gt, AUTHOR, "Michael Grzeschik <m.grzeschik@pengutronix.de>")
> +	@$(call install_fixup, gt, DESCRIPTION, missing)
> +
> +	@$(call install_copy, gt, 0, 0, 0755, -, /usr/bin/gt)
> +	@$(call install_copy, gt, 0, 0, 0755, $(GT_PKGDIR)/usr/etc/gt/gt.conf, /etc/gt/gt.conf)

The conf file doesn't need the execute bit, does it?

 - Roland

> +
> +	@$(call install_finish, gt)
> +
> +	@$(call touch)
> +
> +# vim: syntax=make
> -- 
> 2.30.2
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de