Re: [ptxdist] [PATCH v2 1/5] ptxd_make_world_common: make the package name available to scripts

[Roland Hieber <rhi@pengutronix.de>]

On Fri, Sep 03, 2021 at 02:48:53PM +0200, Michael Olbrich wrote:
> On Mon, Aug 09, 2021 at 10:06:04AM +0200, Roland Hieber wrote:
> > Variables named ${pkg} are already widely used throughout the code base
> > for different purposes, so name it ${pkg_name} instead.
> > 
> > Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> > ---
> > Turned out I didn't need it for this series, but I still think it's
> > useful in general.
> 
> I'd like to drop this. This environment will be part of a commandline and
> that's long enough as it is. So I'd like to avoid adding anything that's
> not strictly needed. We've had issues in the past with commandlines that
> exceed the limit.

Mhm, yes, makes sense.

 - Roland

> > PATCH v2: no changes
> > 
> > PATCH v1: https://lore.ptxdist.org/ptxdist/20210804142330.32739-1-rhi@pengutronix.de
> > ---
> >  rules/post/ptxd_make_world_common.make | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/rules/post/ptxd_make_world_common.make b/rules/post/ptxd_make_world_common.make
> > index e5cf50214e9c..c9d22c6884a3 100644
> > --- a/rules/post/ptxd_make_world_common.make
> > +++ b/rules/post/ptxd_make_world_common.make
> > @@ -69,6 +69,7 @@ world/env/impl = \
> >  	pkg_makefile="$(call ptx/escape,$($(1)_MAKEFILE))"			\
> >  	pkg_infile="$(call ptx/escape,$($(1)_INFILE))"				\
> >  										\
> > +	pkg_name="$(call ptx/escape,$(PTX_MAP_TO_package_$(1)))"                \
> >  	pkg_pkg="$(call ptx/escape,$($(1)))"					\
> >  	pkg_version="$(call ptx/escape,$($(1)_VERSION))"			\
> >  	pkg_config="$(call ptx/escape,$($(1)_CONFIG))"				\
> > -- 
> > 2.30.2
> > 
> > 
> > _______________________________________________
> > ptxdist mailing list
> > ptxdist@pengutronix.de
> > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> > 
> 
> -- 
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de