From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 03 Sep 2021 14:49:01 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mM8cv-0007AR-Ay for lore@lore.pengutronix.de; Fri, 03 Sep 2021 14:49:01 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mM8cv-00063V-3B; Fri, 03 Sep 2021 14:49:01 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mM8cn-000639-PE; Fri, 03 Sep 2021 14:48:53 +0200 Received: from [2a0a:edc0:0:1101:1d::39] (helo=dude03.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mM8cn-0008JA-9C; Fri, 03 Sep 2021 14:48:53 +0200 Received: from mol by dude03.red.stw.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1mM8cn-00Gv8I-8Y; Fri, 03 Sep 2021 14:48:53 +0200 Date: Fri, 3 Sep 2021 14:48:53 +0200 From: Michael Olbrich To: Roland Hieber , ptxdist@pengutronix.de Message-ID: <20210903124853.GB4027748@pengutronix.de> Mail-Followup-To: Roland Hieber , ptxdist@pengutronix.de References: <20210809080608.23475-1-rhi@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210809080608.23475-1-rhi@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [ptxdist] [PATCH v2 1/5] ptxd_make_world_common: make the package name available to scripts X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Mon, Aug 09, 2021 at 10:06:04AM +0200, Roland Hieber wrote: > Variables named ${pkg} are already widely used throughout the code base > for different purposes, so name it ${pkg_name} instead. > > Signed-off-by: Roland Hieber > --- > Turned out I didn't need it for this series, but I still think it's > useful in general. I'd like to drop this. This environment will be part of a commandline and that's long enough as it is. So I'd like to avoid adding anything that's not strictly needed. We've had issues in the past with commandlines that exceed the limit. Michael > PATCH v2: no changes > > PATCH v1: https://lore.ptxdist.org/ptxdist/20210804142330.32739-1-rhi@pengutronix.de > --- > rules/post/ptxd_make_world_common.make | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/rules/post/ptxd_make_world_common.make b/rules/post/ptxd_make_world_common.make > index e5cf50214e9c..c9d22c6884a3 100644 > --- a/rules/post/ptxd_make_world_common.make > +++ b/rules/post/ptxd_make_world_common.make > @@ -69,6 +69,7 @@ world/env/impl = \ > pkg_makefile="$(call ptx/escape,$($(1)_MAKEFILE))" \ > pkg_infile="$(call ptx/escape,$($(1)_INFILE))" \ > \ > + pkg_name="$(call ptx/escape,$(PTX_MAP_TO_package_$(1)))" \ > pkg_pkg="$(call ptx/escape,$($(1)))" \ > pkg_version="$(call ptx/escape,$($(1)_VERSION))" \ > pkg_config="$(call ptx/escape,$($(1)_CONFIG))" \ > -- > 2.30.2 > > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de