mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: Roland Hieber <rhi@pengutronix.de>, ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH v2 1/5] ptxd_make_world_common: make the package name available to scripts
Date: Fri, 3 Sep 2021 14:48:53 +0200	[thread overview]
Message-ID: <20210903124853.GB4027748@pengutronix.de> (raw)
In-Reply-To: <20210809080608.23475-1-rhi@pengutronix.de>

On Mon, Aug 09, 2021 at 10:06:04AM +0200, Roland Hieber wrote:
> Variables named ${pkg} are already widely used throughout the code base
> for different purposes, so name it ${pkg_name} instead.
> 
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
> Turned out I didn't need it for this series, but I still think it's
> useful in general.

I'd like to drop this. This environment will be part of a commandline and
that's long enough as it is. So I'd like to avoid adding anything that's
not strictly needed. We've had issues in the past with commandlines that
exceed the limit.

Michael

> PATCH v2: no changes
> 
> PATCH v1: https://lore.ptxdist.org/ptxdist/20210804142330.32739-1-rhi@pengutronix.de
> ---
>  rules/post/ptxd_make_world_common.make | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/rules/post/ptxd_make_world_common.make b/rules/post/ptxd_make_world_common.make
> index e5cf50214e9c..c9d22c6884a3 100644
> --- a/rules/post/ptxd_make_world_common.make
> +++ b/rules/post/ptxd_make_world_common.make
> @@ -69,6 +69,7 @@ world/env/impl = \
>  	pkg_makefile="$(call ptx/escape,$($(1)_MAKEFILE))"			\
>  	pkg_infile="$(call ptx/escape,$($(1)_INFILE))"				\
>  										\
> +	pkg_name="$(call ptx/escape,$(PTX_MAP_TO_package_$(1)))"                \
>  	pkg_pkg="$(call ptx/escape,$($(1)))"					\
>  	pkg_version="$(call ptx/escape,$($(1)_VERSION))"			\
>  	pkg_config="$(call ptx/escape,$($(1)_CONFIG))"				\
> -- 
> 2.30.2
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de


  parent reply	other threads:[~2021-09-03 12:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-09  8:06 Roland Hieber
2021-08-09  8:06 ` [ptxdist] [PATCH v2 2/5] libptxdist: introduce ptxd_exec_silent_stderr Roland Hieber
2021-08-09  8:06 ` [ptxdist] [PATCH v2 3/5] ptxd_lib_code_signing: refactor hard-coded SoftHSM PIN in PKCS11 URIs Roland Hieber
2021-09-03 12:46   ` Michael Olbrich
2021-09-08 11:27     ` Roland Hieber
2021-09-08 14:01       ` Michael Olbrich
2021-08-09  8:06 ` [ptxdist] [PATCH v2 4/5] ptxd_lib_code_signing: provide consumer functions with some environment Roland Hieber
2021-09-03 12:54   ` Michael Olbrich
2021-09-08 11:30     ` Roland Hieber
2021-09-08 14:08       ` Michael Olbrich
2021-09-08 20:53   ` Roland Hieber
2021-08-09  8:06 ` [ptxdist] [PATCH v2 5/5] ptxd_lib_code_signing: add key whitelist checks Roland Hieber
2021-08-09  9:30   ` Roland Hieber
2021-09-03 13:17   ` Michael Olbrich
2021-09-08 11:43     ` Roland Hieber
2021-09-12 20:33       ` Roland Hieber
2021-09-29 11:51         ` Michael Olbrich
2021-09-03 12:48 ` Michael Olbrich [this message]
2021-09-08 10:17   ` [ptxdist] [PATCH v2 1/5] ptxd_make_world_common: make the package name available to scripts Roland Hieber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210903124853.GB4027748@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    --cc=rhi@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox